Commit Graph
5316 Commits
Author SHA1 Message Date
Sébastien Han aed084e44c Merge pull request #5931 from aruniiird/mds_pools_optional_in_external_script
ceph: Allowing ceph filesystem argument to be optional
2020-08-03 16:09:32 +02:00
Blaine Gardner cb6881e401 Merge pull request #5909 from SUSE/ceph-add-daemon-type-label
ceph: add ceph_daemon_type label to Ceph daemon pods
2020-07-31 09:40:48 -06:00
Travis Nielsen 5c4bf31e99 Merge pull request #5935 from thotz/deleteOBCResourceLogError
ceph: use deleteOBCResourceLogError instead of deleteOBCResource
2020-07-31 07:25:30 -06:00
Jiffin Tony Thottan 091679cbeb ceph: use deleteOBCResourceLogError instead of deleteOBCResource
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-07-31 15:41:35 +05:30
Jiffin Tony Thottan 59f1e8364e ceph: fix up deleteOBCResourceLogError
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-07-31 15:41:31 +05:30
Arun Kumar Mohan cba605a930 ceph: provide storageclass-es if there are valid parameters
'ceph-rgw' storageclass will be provided only if 'rgw_endpoint' exists
'cephfs' storageclass will be provided only if ceph-fs and/or data-pool
parameters are valid.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-07-31 11:13:36 +05:30
Arun Kumar Mohan 18b32023c5 ceph: allowing ceph filesystem argument to be optional
If we are unable to get or infer a default value for ceph filesystem
script won't be throwing an error.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-07-31 11:13:31 +05:30
Travis Nielsen e0ea87a353 Merge pull request #5674 from thotz/quotaobc
ceph: adding support for quota in object bucket claims
2020-07-30 22:51:58 -06:00
Travis Nielsen 1df67bb603 Merge pull request #5933 from subhamkrai/close-file
ceph: closing file which are open for writing
2020-07-30 19:28:39 -06:00
Travis Nielsen ec029653cd Merge pull request #5800 from thotz/bucketpolicydesigndoc
docs: design doc for bucket policy feature
2020-07-30 13:12:38 -06:00
Travis Nielsen 91a1f2dc9e Merge pull request #5921 from binoue/add-event-log-file
ci: create Kubernetes Event log file
2020-07-30 11:24:03 -06:00
Blaine Gardner dcf8ae2526 ceph: rename pod labels function for more clarity
Rename PodLabels function to CephDaemonAppLabels for more clarity about
what the function's purpose is.

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2020-07-30 11:16:30 -06:00
Blaine Gardner 6ceaef8610 ceph: add new "ceph_daemon_type" label to nfs pods
Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2020-07-30 11:16:29 -06:00
Blaine Gardner 62cbaaec02 ceph: add new "ceph_daemon_type" label to osd pods
Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2020-07-30 11:16:26 -06:00
Blaine Gardner 9b6114c192 ceph: add 'ceph_daemon_type' label to pod labels
This can help users identify the daemon type similarly to how
'ceph_daemon_id' helps identify the daemon ID. This also makes it so
scripts users create don't have to parse "app=rook-ceph-<daemonType>"
into "<daemonType>" if they desire that bit of info.

Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
2020-07-30 11:16:22 -06:00
subhamkrai c938849cf8 ceph: closing file which are open for writing
using defer for closing file which are open
for writing is not safe. so closing file again
following  below steps:
1. open files
2. defer file.close()
3. write
4.file.close()

these will make sure files are closed.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-30 22:37:56 +05:30
Sébastien Han fd57eff0f8 Merge pull request #5906 from subhamkrai/gosec-CI
ci: adding gosec tool in ci
2020-07-30 10:21:02 +02:00
subhamkrai 22216899b9 ci: adding gosec tool in ci
this commit will add gosec check in ci
and it will help us increase code quality.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-30 13:36:17 +05:30
Sébastien Han 44355a921b Merge pull request #5920 from binoue/fix-log-output
ci: fix log output
2020-07-30 08:59:12 +02:00
Sébastien Han ef434e8f68 Merge pull request #5913 from Madhu-1/csi-del
ceph: update clusterrole of operator for csidrivers
2020-07-30 08:42:58 +02:00
Travis Nielsen 034d128623 Merge pull request #5923 from subhamkrai/allgosec-error
ceph: handling all the gosec errors
2020-07-29 23:31:23 -06:00
subhamkrai 0279025e9e ceph: handling all the gosec errors
a few of the gosec errors were left. so
this commit will resolve all the errors.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-30 08:19:55 +05:30
binoue 937b77f8e6 ceph: revised according to the review comments
revised according to the review comments

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
2020-07-30 07:44:08 +09:00
binoue bb224733f6 ceph: fix log output
fix log output

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
2020-07-30 07:26:20 +09:00
Travis Nielsen 4bc2cf1dc1 Merge pull request #5925 from nixpanic/ceph/POOL_NO_REDUNDANCY
ceph: do not warn about no redundancy in test cluster
2020-07-29 13:35:32 -06:00
Niels de Vos bb2b4096d1 ceph: do not warn about no redundancy in test cluster
In test environments the default pool size is set to 1, so there is no
redundancy. This causes recent Ceph versions to complain with
HEALTH_WARN as POOL_NO_REDUNDANCY get set.

By disabling the mon_warn_on_pool_no_redundancy option in ceph.conf, the
warning is not reported and the cluster is marked HEALTHY.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-07-29 13:25:12 -06:00
Travis Nielsen eec88e79b0 Merge pull request #5917 from travisn/enable-1.4-backport-bot
ci: Enable 1.4 backport bot
2020-07-29 11:25:53 -06:00
Travis Nielsen 6302b54c27 ci: add mergify backport target for release-1.4
With the v1.4 release we will need mergify to support
the automatic backports based on the PR label.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-07-29 10:03:55 -06:00
Travis Nielsen 4abaaf083c ci: remove 1.1 backport target
There is no longer a need to support backports to v1.1,
so removing the mergify rule.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-07-29 09:55:28 -06:00
Sébastien Han f4ca7127d4 Merge pull request #5919 from cybozu-go/fix-chart
ceph: remove duplicated lines from Helm chart
2020-07-29 17:33:23 +02:00
Sébastien Han a3d30edb64 Merge pull request #5916 from travisn/reduce-stale-pr-timeout
ci: Reduce the PR stale time to 90 days
2020-07-29 09:15:08 +02:00
binoue 9a44b95f68 ceph: create event log file
Currently, rook CI is not logging Kubernetes Events, but it sometimes gives hints
for bugs.
Therefore, this PR adds a function to collect and log Kubernetes Events.

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
2020-07-29 16:02:05 +09:00
Madhu Rajanna 28f0471106 ceph: update clusterrole of operator for csidrivers
updated the clusterrole of the rook operator
to delete the csidrivers object when csi-drivers
are disabled, without the required access rook operator
cannot delete the csidrivers object.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-07-29 09:41:26 +05:30
Travis Nielsen fd29a8691e Merge pull request #4868 from nizamial09/file_permission
rook: Changing the file and directory permissions to most narrow poss…
2020-07-28 21:45:12 -06:00
Masayuki Ishii e89a1f1738 ceph: remove duplicated lines from Helm chart
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
2020-07-29 00:17:48 +00:00
Travis Nielsen 998b3f29ea ceph: reduce the file permissions to fix gosec errors
File permissions need to be reduced to the minimum to avoid config
files from being accessed. While a connection to the pod would be
required to access the files, min privileges are set just as
another layer of security. This fixes gosec error G306.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-07-28 15:46:24 -06:00
Nizamudeen 041618dacb ceph: change the file and directory permissions to most narrow possible
This commit fixes where there are areas in which files and directories are
written and created with statically defined permissions. Many of these
permissions are rather open, potentially allowing other system tenants to
view and interact with their contents, which may be sensitive.

Fixed G303: Poor file permissions used for directory by using the most narrow permission

Resoves: https://github.com/rook/rook/issues/4580

Signed-off-by: Nizamudeen <nia@redhat.com>
2020-07-28 15:46:12 -06:00
Travis Nielsen 785e866dd2 ci: reduce the PR stale time to 90 days
The stalebot has not been closing PRs that are stale.
Reducing the timeout from 6 months to 3 months.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-07-28 15:31:15 -06:00
Travis Nielsen da142be079 Merge pull request #5894 from subhamkrai/gosec-error-G104
ceph: handling gosec errors code g104  and g404
v1.4.0-alpha.0
2020-07-28 14:35:59 -06:00
subhamkrai de8e93274d ceph: handling gosec errors code g104
this commit handles all the gosec g104
(i.e Audit errors not checked) error.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-28 23:52:23 +05:30
Travis Nielsen 704e80d1b5 Merge pull request #5912 from rohantmp/rohantmp-patch-1
Core: Add comment warning to keep k8sutil hashing consistent for name…
2020-07-28 10:41:47 -06:00
Travis Nielsen 1ee29b9c63 Merge pull request #5895 from subhamkrai/nosec-error
ceph: suppress gosec errors for g204,g304,g101
2020-07-28 08:25:58 -06:00
Travis Nielsen 9e6429b4c8 Merge pull request #5893 from subhamkrai/gosec-error-G601
ceph: handling gosec error code g601
2020-07-28 08:25:00 -06:00
Travis Nielsen f6b7aac3b6 Merge pull request #5908 from leseb/split-osd-files
ceph: split osd code in files
2020-07-28 07:37:46 -06:00
Rohan Joseph 82b062f91d core: add comment warning to keep k8sutil hashing consistent
The name generation utils need to provide consistent outputs across
versions so that names generated based on values are consistent and
older generated keys are not lost.

Signed-off-by: Rohan CJ <rohantmp@gmail.com>
2020-07-28 12:51:54 +05:30
Sébastien Han c2db463eb2 Merge pull request #5907 from aruniiird/rgw_endpoint_validations_optional
ceph: make 'rgw_endpoint' check/validation also optional
2020-07-28 08:42:52 +02:00
Jiffin Tony Thottan f4240cb31d ceph: add quota support for obc
Closes: #5274
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-07-28 12:00:11 +05:30
Jiffin Tony Thottan 96a53389b1 ceph: adding new quota apis
Adding new apis such as EnableUserQuota() for enabling quota,
SetQuotaUserObjectMax() and SetQuotaUserMaxSize() for setting user specific quotas
for objects and size respectively. Please note the size is quota is determined in GBs.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-07-28 12:00:04 +05:30
Jiffin Tony Thottan 5a6cafcdfc ceph: add missing explaination for apis in user.go
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-07-28 11:59:57 +05:30
Jiffin Tony Thottan cf61966205 ceph: remove rgwerrno from setuserquota
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-07-28 11:59:51 +05:30