Commit Graph
10408 Commits
Author SHA1 Message Date
StepSecurity Bot beef4e2cde test: limit permissions in github actions
Automatic PR from app.stepsecurity.io (initiated by BlaineEXE) to limit 
permissions in github actions to only those needed.

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
2023-10-24 18:05:30 +00:00
Travis Nielsen 0de9d7ea0e Merge pull request #13092 from BlaineEXE/readme-snyk-badge
docs: update "synk" -> "snyk" spelling
2023-10-24 11:35:34 -06:00
Travis Nielsen d8f252d10d Merge pull request #13094 from rook/snyk-update
security: update snyk ignores for MPL-2.0
2023-10-24 10:59:33 -06:00
Blaine Gardner bb492e1329 security: update snyk ignores for MPL-2.0
Update the snyk ignores related to Vault MPL-2.0 licenses.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-10-24 10:05:22 -06:00
Travis Nielsen aa4835c853 Merge pull request #13078 from rkachach/fix_issue_namespace
namespace: adding namespace to all rook-ceph namespaces references
2023-10-24 09:47:46 -06:00
Blaine Gardner 1d830207a2 docs: update "synk" -> "snyk" spelling
Update some old typos that say "synk" instead of "snyk".
out of sync. This should fix the top-level README.md to use the latest
snyk security scan badge -- as opposed to only referring to the last one
that used the misspelled file from about a month ago.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-10-24 09:09:38 -06:00
Travis Nielsen 8229e9e73e Merge pull request #13080 from rkachach/fix_issue_13079
namespace: adding a dedicated entry for operator namespace in common
2023-10-24 08:27:06 -06:00
Redouane Kachach 745d6dc86f docs: adding specific instructions to create operator namespace
When a user attempts to adhere to the current documentation to use alternative
namespaces for both the operator and the cluster, they fail because
our common YAML file only has a single namespace for the cluster. This
change adds specific instructions to create operator namespace.

Closes: https://github.com/rook/rook/issues/13079

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-10-24 16:10:35 +02:00
Redouane Kachach ff081cc4ae namespace: adding namespace to all rook-ceph namespaces references
To make it easier for the user to switch to a namespace other than the
default 'rook-ceph', the tag '# namespace:cluster' must be inserted in
all the places where this namespace is used. This way, a simple 'sed'
command can update all the Yaml files to the new namespace.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-10-24 14:17:17 +02:00
Travis Nielsen ffaf4a1b3f Merge pull request #13072 from travisn/crash-keyring
core: Crash collector keyring requires rw access for the mgr profile
2023-10-23 11:56:58 -06:00
Travis Nielsen 9d214b9cfe Merge pull request #13061 from parth-gr/external-pool-enable
external: automatically init the rbd pool
2023-10-23 10:37:42 -06:00
parth-gr 40008bf18d external: automatically init the rbd pool
Sometimes the pool is not enabled and the ceph cluster
shows health warning, so automatically initalize the pool
from the script

Signed-off-by: parth-gr <paarora@redhat.com>
2023-10-23 20:45:50 +05:30
Travis Nielsen dc5b3629d5 Merge pull request #13075 from rook/dependabot/go_modules/github-dependencies-1e6a735343
build(deps): bump the github-dependencies group with 1 update
2023-10-23 07:32:41 -06:00
Travis Nielsen b76c576a3e Merge pull request #13074 from rook/dependabot/go_modules/k8s-dependencies-12c32a9cf1
build(deps): bump the k8s-dependencies group with 5 updates
2023-10-23 07:32:04 -06:00
dependabot[bot] b6aefea144 build(deps): bump the github-dependencies group with 1 update
Bumps the github-dependencies group with 1 update: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go).

- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.45.25...v1.46.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-10-23 12:29:06 +00:00
dependabot[bot] 559720f4ce build(deps): bump the k8s-dependencies group with 5 updates
Bumps the k8s-dependencies group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.28.2` | `0.28.3` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.28.2` | `0.28.3` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.28.2` | `0.28.3` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.28.2` | `0.28.3` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.16.2` | `0.16.3` |


Updates `k8s.io/api` from 0.28.2 to 0.28.3
- [Commits](https://github.com/kubernetes/api/compare/v0.28.2...v0.28.3)

Updates `k8s.io/apiextensions-apiserver` from 0.28.2 to 0.28.3
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.28.2...v0.28.3)

Updates `k8s.io/cli-runtime` from 0.28.2 to 0.28.3
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.28.2...v0.28.3)

Updates `k8s.io/cloud-provider` from 0.28.2 to 0.28.3
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.28.2...v0.28.3)

Updates `sigs.k8s.io/controller-runtime` from 0.16.2 to 0.16.3
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.16.2...v0.16.3)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-10-23 12:27:51 +00:00
travisn a421143ddd Revert "core: use crash profile in crash daemon keyring"
This reverts commit fab23d3407.
The mgr requires rw access for the cron job that collects
the crashes.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2023-10-20 15:46:36 -06:00
Travis Nielsen 4b701da916 Merge pull request #13050 from rkachach/fix_issue_13010
docs: adding specific instructions to upgrade Rook toolbox
2023-10-18 09:06:19 -06:00
Travis Nielsen affaa3c19d Merge pull request #13057 from subhamkrai/fix-make-docs
ci: debug docs-check ci
2023-10-18 09:01:30 -06:00
Redouane Kachach 0e132f45a6 docs: adding specific instructions to upgrade Rook toolbox
Closes: https://github.com/rook/rook/issues/13010

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-10-18 14:33:46 +02:00
subhamkrai b186150e1c ci: fix mkdocs deprecated imports
migrate to using mkdocs-material's material.extensions.emoji.twemoji
and material.extensions.emoji.to_svg in place of the respective
materialx.emoji.twemoji and materialx.emoji.to_svg. Also, this requires
latest version of mkdocs-material.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-10-18 15:54:46 +05:30
Travis Nielsen 918b544bbe Merge pull request #13046 from wb14123/log-non-node
osd: print warning message if no matching node found for osd
2023-10-17 11:32:28 -06:00
Bin WangandTravis Nielsen 4a705b46b0 osd: print warning message if no matching node found for osd
As seen in https://github.com/rook/rook/issues/1988, it's a common
mistake to configure rook nodes with names that don't match Kubernetes's
node label. This PR prints more detailed message to help debugging
problem.

Signed-off-by: Bin Wang <bin.wang@mail.binwang.me>

Add break according to review comment

Co-authored-by: Travis Nielsen <tnielsen@redhat.com>

Update log message according to review comment

Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
2023-10-16 18:37:25 -04:00
Travis Nielsen 2421391508 Merge pull request #13045 from wb14123/dashboard-doc
doc: fix document about viewing dashboard outside of cluster
2023-10-16 11:10:14 -06:00
Travis Nielsen dfdb716bbe Merge pull request #13049 from rook/dependabot/go_modules/github-dependencies-1878a07e91
build(deps): bump the github-dependencies group with 3 updates
2023-10-16 10:07:48 -06:00
dependabot[bot] dd7a7b3f61 build(deps): bump the github-dependencies group with 3 updates
Bumps the github-dependencies group with 3 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go), [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph) and [github.com/google/go-cmp](https://github.com/google/go-cmp).


Updates `github.com/aws/aws-sdk-go` from 1.45.24 to 1.45.25
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.45.24...v1.45.25)

Updates `github.com/ceph/go-ceph` from 0.23.0 to 0.24.0
- [Release notes](https://github.com/ceph/go-ceph/releases)
- [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md)
- [Commits](https://github.com/ceph/go-ceph/compare/v0.23.0...v0.24.0)

Updates `github.com/google/go-cmp` from 0.5.9 to 0.6.0
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.5.9...v0.6.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/ceph/go-ceph
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/google/go-cmp
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-10-16 12:22:42 +00:00
Bin Wang 25d89d2b68 doc: fix document about viewing dashboard outside of cluster
https://github.com/rook/rook/pull/11845 added dynamic label `mgr_role`.
The example yaml files are updated but this doc is missed.

I think it would be better to refer to `deploy/examples` but I find all
other places are not doing that. So keep it inlined to be consistent.

Signed-off-by: Bin Wang <bin.wang@mail.binwang.me>
2023-10-15 23:00:06 -04:00
Travis Nielsen 1dae1aa59e Merge pull request #13036 from BlaineEXE/test-notsecret
test: mark unit test secrets as not secret
2023-10-13 10:15:55 -06:00
Travis Nielsen f26f334578 Merge pull request #13032 from BlaineEXE/update-libopenstorage-secrets-lib
build: update to latest libopenstorage/secrets lib
2023-10-12 13:01:35 -06:00
Blaine Gardner 55d106b993 build: update to latest libopenstorage/secrets lib
Update to the latest version of libopenstorage/secrets which does not
have a dependency on Hashicorp Vault libraries that are licensed under
the Business Source License (BUSL-1.1). The latest version of the
library has been modified to use Vault's open source API that is
licensed under Mozilla Public License (MPL-2.0).

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-10-12 11:52:29 -06:00
Blaine Gardner 38c262c004 Merge pull request #13028 from Madhu-1/fix-cosi-doc
cosi: fix problem in cosi document
2023-10-12 11:42:18 -06:00
Travis Nielsen 76e4464ab3 Merge pull request #12165 from cybozu-go/osd-prevent-to-fallback-to-lvm-mode-in-osd-on-lvm-creation
osd: prevent to fallback to lvm mode in osd on lvm creation
2023-10-12 11:08:51 -06:00
Travis Nielsen 75d8a79aac Merge pull request #13041 from iamniting/scc
Enhance SCC Function to Support Multiple Namespaces
2023-10-12 10:54:37 -06:00
Travis Nielsen b1c7d46e15 Merge pull request #13037 from rook/dependabot/go_modules/golang.org/x/net-0.17.0
build(deps): bump golang.org/x/net from 0.15.0 to 0.17.0
2023-10-12 09:34:35 -06:00
Nitin Goyal 86afa591ba security: enhance SCC Function to Support Multiple Namespaces
Currently, the function receives a single namespace string and appends
it to the users. This approach is insufficient when dealing with
multiple CephClusters running in different namespaces, as there will be
only one SCC. This update modifies the function to create users for all
specified namespaces, ensuring compatibility with multiple namespaces.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
2023-10-12 19:56:19 +05:30
Travis Nielsen e0ab3220bd Merge pull request #13039 from Madhu-1/fix-csi-mountinfo
csi: fix indentation for mountinfo
2023-10-12 07:19:19 -06:00
Madhu Rajanna a2e0b0c46b cosi: fix problem in cosi document
Fixed a wording problem and moved the
app pod to default namespace where secret
was created and also removed the init container
from the sample as the busybox doesnt
have setup-aws-credentials CLI pre-installed.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-10-12 09:13:12 +02:00
Madhu Rajanna 9f2b7d572d csi: fix indentation for mountinfo
Fixed the indentation for the mountinfo
or else an emptyDir is getting created
for it.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-10-12 09:01:26 +02:00
dependabot[bot] ed8992f978 build(deps): bump golang.org/x/net from 0.15.0 to 0.17.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0.
- [Commits](https://github.com/golang/net/compare/v0.15.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-10-11 23:18:24 +00:00
Blaine Gardner 3c7499facf test: mark unit test secrets as not secret
There are 2 cases of randomly generated secrets copied into Rook's unit
test code that have been flagged by Gitleaks. Add a comment to both
cases to help the tool understand that these aren't real production
secrets -- just unit test stand-ins.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-10-11 16:42:29 -06:00
Satoru Takeuchi 6fee3c9ff4 osd: prevent to fallback to lvm mode in osd on lvm creation
Rook creates raw mode OSD as possible and falls back to lvm mode if necessary.
This logic doesn't work if only supports raw mode.

Closes: https://github.com/rook/rook/issues/11438

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2023-10-11 22:36:53 +00:00
Blaine Gardner a48d5f2a80 Merge pull request #13031 from sp98/osd-script-update
osd: use bash script if restart interval is > 0
2023-10-11 11:47:27 -06:00
Travis Nielsen 2f68c6b189 Merge pull request #13033 from travisn/assimilate-dir
mon: Write the assimilate-conf config to a valid operator working directory
2023-10-11 10:07:21 -06:00
sp98 ffd69291f1 osd: use bash script if restart interval is > 0
If `FlappingRestartIntervalHours` for OSD is > 0 in the cephCluster CR,
then start OSD inside a bash script.

Signed-off-by: sp98 <sapillai@redhat.com>
2023-10-11 11:38:26 +05:30
travisn 5359c4f4f5 mon: write assimilate config to operator dir
The /tmp dir is not always available in some environments.
The only directories the operator should rely on
are the directories that are in its pod spec.
For assimilate-conf now we use the /var/lib/rook
directory to generate files since we know it is
a valid emptydir mounted into the operator pod.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-10-10 16:10:30 -06:00
Travis Nielsen 703f594f4c Merge pull request #12860 from parth-gr/mds-liveness
mds: improve the mds liveness probe calls
2023-10-10 08:21:00 -06:00
parth-gr 3d4036547c ci: check mds liveness probe unit test from the CI run
Signed-off-by: parth-gr <paarora@redhat.com>
2023-10-10 18:56:36 +05:30
Travis Nielsen 5c312c58f5 Merge pull request #13011 from Madhu-1/fix-13009
csi: add mountinfo path for cephfs daemonset
2023-10-09 10:46:48 -06:00
Travis Nielsen e03f8eaf81 Merge pull request #13020 from rook/dependabot/go_modules/github-dependencies-fb30ef1fab
build(deps): bump the github-dependencies group with 1 update
2023-10-09 09:12:39 -06:00
Travis Nielsen c1c16ee7fd Merge pull request #13021 from rook/dependabot/go_modules/golang.org/x/sync-0.4.0
build(deps): bump golang.org/x/sync from 0.3.0 to 0.4.0
2023-10-09 09:12:02 -06:00