Commit Graph
13292 Commits
Author SHA1 Message Date
Blaine Gardner 74d3492ee5 build: fix double include of build/makelib/helm.mk
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-30 15:29:54 -06:00
Blaine Gardner 7aa4bbfff7 Merge pull request #8878 from BlaineEXE/initial-generate-rbac-from-helm
build: start tracking rbac generated from helm chart
2021-09-30 13:49:21 -06:00
Blaine Gardner e2ba16f710 build: start tracking rbac generated from helm chart
This is a starting step to be able to generate common.yaml from Helm
charts. For right now, we merely want to be able to determine when the
rendered output of the Helm chart changes.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-30 12:20:24 -06:00
Sébastien Han 04e1589a33 ci: run the orch ceph manager test daily
Let's run the test every day at midnight since the code is moving
fast and tends to fail. This gives us some time to fix the issues.
It can be triggered on PR too if the "run-mgr-suite" label is set.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-30 18:54:09 +02:00
Blaine Gardner da52226280 Merge pull request #8885 from BlaineEXE/use-intermediate-tmp-for-offline-image-install-list
build: use intermediate tmp for offline image gen
2021-09-30 08:18:58 -06:00
Sébastien Han 1f49b6f766 Merge pull request #8882 from aruniiird/change-CephMgrIsAbsent-alert
ceph: change CephAbsentMgr to use 'up' query
2021-09-30 09:05:49 +02:00
Satoru Takeuchi a0d0d7ef86 Merge pull request #8881 from BlaineEXE/period-log
rgw: add period does not exist debug message
2021-09-30 16:02:41 +09:00
Blaine Gardner 24bf99f31c build: use intermediate tmp for offline image gen
Reading from a file, processing the file in a pipe, and outputting the
piped content to the same file can have undefined results, often leading
to an empty file. Use an intermediate temp file for generating the
offline image list.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-29 17:31:02 -06:00
Blaine Gardner c6edc1b7d0 Merge pull request #8781 from BlaineEXE/limit-wildcard-in-rbac-verb-resource
rgw: reduce RBAC for lib-bucket-provisioner
2021-09-29 14:40:54 -06:00
aruniiird 854eb0113f ceph: change CephAbsentMgr to use 'up' query
Instead of using 'absent' query, we are trying to use 'up' which should
provide us with the needed 'namespace' field in the resultant metrics

Signed-off-by: aruniiird <amohan@redhat.com>
2021-09-30 01:12:46 +05:30
Blaine Gardner e10fb751e5 rgw: add period does not exist debug message
Log as a debug message when the RGW period will be updated because it
does not exist.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-29 13:14:52 -06:00
Blaine Gardner 2826bc99df Merge pull request #8828 from BlaineEXE/rgw-period-command-should-be-run-on-every-reconcile
rgw: update period if period does not exist
2021-09-29 13:08:27 -06:00
Sébastien Han 85612b1f3c Merge pull request #8868 from leseb/fix-crash-kms-deletion
ceph: do not fail on keys deletion
2021-09-29 16:44:26 +02:00
Sébastien Han 804500fc11 Merge pull request #8869 from leseb/image-pull-erorr
ci: retry on image pull error
2021-09-29 16:43:44 +02:00
Sébastien Han 33f0577dcb Merge pull request #8866 from leseb/fix-8865
bot: change mergify config for k8s versions
2021-09-29 16:34:44 +02:00
Sébastien Han 7a9a6a65fc Merge pull request #8863 from subhamkrai/update-image-list
build: update command to generate image list
2021-09-29 16:06:18 +02:00
Sébastien Han e3f7d2f046 ci: retry on image pull error
Try to avoid the following:

```
error pulling image configuration: received unexpected HTTP status: 500 Internal Server Error
```

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-29 16:03:38 +02:00
Sébastien Han 2e73baf4f5 ceph: do not fail on keys deletion
Prior, we were returning a nil map and thus the assignment for forced
deletion was not working since we were trying to assign on a nil map.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-29 15:59:18 +02:00
subhamkrai 2d7755ca15 build: update command to generate image list
While build.all we have race condition where images.txt
file was update with duplicate entries. So, removing `-a`
from 1st tee and also add `sort -h`and `uniq` command to
confirm no duplicate entry is in the file.

Signed-off-by: subhamkrai <srai@redhat.com>
2021-09-29 15:00:05 +05:30
Sébastien Han cc66fdb5d7 bot: fix mergify merge rules for kubernetes version
CI's running versions were incorrect.

Closes: https://github.com/rook/rook/issues/8865
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-29 10:17:29 +02:00
Sébastien Han 8902d7095e bot: remove old branch config from mergify
We don't backport to 1.4 or 1.5 anymore so let's clean up the file.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-29 10:08:11 +02:00
Sébastien Han 0ba6243baa Merge pull request #8860 from leseb/exec-mgr
multus: do not build all the args to remote exec cmd
2021-09-29 08:53:55 +02:00
Blaine Gardner 7b9293624a rgw: update period if period does not exist
Rook should update the RGW object store's period if the period doesn't
yet exist. This protects us from the case where the
'radosgw-admin period update --commit` command fails and the
CephObjectStore controller reconciles again.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-28 14:17:04 -06:00
Sébastien Han 17999bcb3d ceph: do not build all the args to remote exec cmd
When proxying commands to the cmd-proxy container we don't need to build
the command line with the same flags as the operator. The cmd-proxy
container does not use any ceph config file and just relies on the
CEPH_ARGS environment variable in the container. So passing the same
args as the operator causes to fail since we don't have a ceph config
file in `/var/lib/rook/openshift-storage/openshift-storage.config` thus
the remote exec fails with:

```
global_init: unable to open config file from search list ...
```

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-28 19:00:32 +02:00
Sébastien Han 62d66b0f45 Merge pull request #8807 from leseb/fix-bz-2007130
ceph: fix external script when passing monitoring list
2021-09-28 16:01:28 +02:00
Sébastien Han 428942ac59 Merge pull request #8854 from leseb/wait-longer
ci: wait longer for pod label to be deleted
2021-09-28 15:54:41 +02:00
Travis Nielsen 2bedb53fbe Merge pull request #8712 from leseb/fix-8663
rgw: use insecure TLS for bucket health check
2021-09-28 07:53:18 -06:00
Sébastien Han f47b870718 ceph: fix external script when passing monitoring list
If we call the script with --monitoring-endpoint
10.1.8.29,10.1.8.36,10.1.8.25, we need to parse each comma-separated
address and not the entire block.
Now each address is tested properly.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-28 15:30:38 +02:00
Sébastien Han b4a36e9967 ci: wait longer for pod label to be deleted
I've seen cases were the CI needs a few more seconds to delete and
object store. When logging in the runner, the object store is gone and
the timing matches too with the runner's logs (comparing with the
operator's logs).

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-28 15:24:39 +02:00
Sébastien Han cda5dad291 rgw: use insecure TLS for bucket health check
We have seen cases where the signed certificate used for the RGW does not
contain the internal DNS endpoint, resulting in the health check to fail
since the certificate is not valid for this domain.
People consuming the gateways by external clients and for specific
domains do not necessarily have the internal DNS configured in the
certificate.
So let's be a bit more flexible and simply ensure a connectivity check
and bypass the certificate validation.

Also, this is fixing the tls code in newS3Agent and adds unit tests.

Closes: #8663
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-28 14:48:07 +02:00
Sébastien Han dcb88a71d1 Merge pull request #8848 from leseb/fix-8843
ci: fix the test name for upgrade suite
2021-09-28 11:30:39 +02:00
Sébastien Han d2e221c206 Merge pull request #8850 from leseb/fix-mgr-host
ci: fix mgr test for host
2021-09-28 10:18:01 +02:00
Sébastien Han 139de0e746 Merge pull request #8813 from BlaineEXE/tidy-object-integration-tests
test: clean up object store tests
2021-09-28 09:28:27 +02:00
Sébastien Han 5d8a1deda1 ci: fix mgr test for host
The `mgr host ls` looks like:

`"addr": "10.1.0.27/fv-az244-362", "hostname": "fv-az244-362"`

Previously, we were picking `addr` which contains both IP and hostname
where the k8snode has the hostname only. So let's use the Hostname from
the mgr command output instead.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-28 09:19:01 +02:00
Sébastien Han cb3d342515 ci: fix the test name for upgrade suite
Since we were pointing at CephUpgradeSuite test only this was running
all the tests and thus some resources were created by other tests.
Let's just run the test we need.

Closes: https://github.com/rook/rook/issues/8843
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-28 09:12:37 +02:00
Satoru Takeuchi 3d4acd1bfa Merge pull request #8833 from ashangit/purge_missing_rights
ceph: add missing rights rook-ceph-purge-osd account
2021-09-28 16:11:34 +09:00
Satoru Takeuchi 15fd707be6 Merge pull request #8846 from cybozu-go/docs-fix-the-example-of-local-pvc-based-cluster
docs: fix the example of local PVC based cluster
2021-09-28 14:13:15 +09:00
Satoru Takeuchi 8c7f2ba4d5 docs: fix the example of local PVC based cluster
PV for mon must be a filesystem volume.

Closes: https://github.com/rook/rook/issues/8818

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2021-09-28 04:12:44 +00:00
Blaine Gardner f42e4eebfa test: clean up object store tests
In general, make the output from the object store test easier to follow
and debug.

- Make sure assertions are associated with the appropriate subtest.
- Remove `t.Helper()` from complex helpers.
- Add info to log messages.
- Move long parts of (sub-)test names to log messages.
- Move some reused functions back to ceph_base_object_test.go
- Refactor runObjectE2ETestLite() to be suitable for use as the second
  store created in the "run a second object store" test.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-27 12:29:17 -06:00
Blaine Gardner a9ad9135e8 Merge pull request #8806 from leseb/fw-signal-log-collector
ceph: add signal handling for log collector
2021-09-27 12:08:42 -06:00
Travis Nielsen 45fe8eadd5 Merge pull request #8838 from subhamkrai/comment-tmate-session
ci: run tmate session only on PR
2021-09-27 10:33:52 -06:00
Travis Nielsen 26d5e2f8ca Merge pull request #8841 from travisn/advanced-help-link
docs: Fix link to advanced documentation
2021-09-27 08:44:41 -06:00
subhamkrai fb13b5cad0 ci: run tmate session only on PR
run tmate only for `pull_request` event and
remove for other events. As during release
when tests fail it takes extra 30 min to fail the
test or someone manually has to end the test
which is painfully especially during release time.

Signed-off-by: subhamkrai <srai@redhat.com>
2021-09-27 19:52:37 +05:30
Travis Nielsen c5757402d1 docs: fix link to advanced documentation
The ceph common issue had a bad link to the advanced doc topic.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-09-27 08:14:14 -06:00
Sébastien Han 86803287c7 Merge pull request #8758 from leseb/more-test
ci: add daily jobs
2021-09-27 15:23:49 +02:00
Sébastien Han 4ba7e818c5 Merge pull request #8805 from leseb/fix-8794
ceph: stop using tini
2021-09-27 14:57:39 +02:00
n.fraison 5150018937 ceph: add missing rights rook-ceph-purge-osd account
The purge osd job need to read and update persistentvolumeclaims
While the job doesn't failed with osd and deployments well deleted
The associated pvc is not deleted by the job as it failed to read it

Signed-off-by: n.fraison <n.fraison@criteo.com>
2021-09-27 14:00:06 +02:00
Satoru Takeuchi fc59b76afc Merge pull request #8837 from leseb/fix-8825
ci: wait longer for csi to be available
2021-09-27 19:56:13 +09:00
Sébastien Han 85216a266c ci: wait longer for csi to be available
Sometimes the CI needs more time...

Closes: https://github.com/rook/rook/issues/8825
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-27 12:12:46 +02:00
Sébastien Han 33dbaba38b ci: add daily jobs
We have new jobs now:

* one that runs both smoke and object on the next Pacific version
* one that runs both smoke and object on Ceph master
* one that tests the upgrade from the current pacific stable to the
  pacific devel
* one that tests the upgrade from the current octopus stable to the
  octopus devel

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-27 11:59:04 +02:00