Commit Graph
13292 Commits
Author SHA1 Message Date
Sébastien Han ccdc5e979d Merge pull request #8793 from aruniiird/add-namespace-to-ceph-node-down-query
monitoring: add namespace to ceph node down query
2021-09-27 11:33:13 +02:00
Sébastien Han 121c2987e3 ceph: stop using tini
We don't need to use tini.
We don't have anything in the rook operator that would
either create zombie processes (no threads) or use
exec (to fork). The Go binary has a really good
signal handling mechanism.

Closes: https://github.com/rook/rook/issues/8794
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-27 10:54:16 +02:00
Sébastien Han a649f64100 ceph: add signal handling for log collector
The log collector was not responding to SIGINT or SIGTERM correctly
since the parent bash process did not have the job control functionality
enabled. Now any signal received on bash will exit the container
immediately.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-27 10:50:17 +02:00
Arun Kumar Mohan 11ff00e309 ceph: adding 'namespace' into the result of 'ceph_node_down' query
This will add 'namespace' field into the result of 'ceph_node_down'
query.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2021-09-27 08:37:17 +00:00
Sébastien Han 76b2ebbfd0 Merge pull request #8774 from aruniiird/prometheus-rules-format-change
ceph: prometheus rules format changes
2021-09-27 10:36:31 +02:00
Blaine Gardner 7b1b037f94 rgw: reduce RBAC for lib-bucket-provisioner
Reduce the RBAC scope for the lib-bucket-provisioner to the minimum
necessary for Rook to operate with lib-bucket-provisioner. Comment the
RBAC so that users can make informed decisions about whether or not they
can remove the permissions for their uses.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-24 16:13:49 -06:00
Blaine Gardner 01bc8ab9a6 Merge pull request #8820 from humblec/co-ty
ceph: update csi sidecar version references to the latest
2021-09-24 12:33:49 -06:00
Travis Nielsen d743a226a4 Merge pull request #8821 from parth-gr/master
docs: updated correct indentation for Storage spec in Cephcluster
2021-09-24 07:44:59 -06:00
Humble Chirammal 966a88ea81 ceph: update the csi sidecar versions in templates and documentation
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2021-09-24 18:25:12 +05:30
parth-gr 2c670a053c docs: updated correct indentation for Storage spec in Cephcluster
Cephcluster have wrong indentation for examples yaml and helm
Updated the specs indentation the way it is present in types.go

Closes: https://github.com/rook/rook/issues/8800
Signed-off-by: parth-gr <paarora@redhat.com>
2021-09-24 18:19:27 +05:30
Sébastien Han 12506c7918 Merge pull request #8779 from travisn/obsolete-test-scripts
test: Remove obsolete test scripts for minishift, kubeadm, and update test readme
2021-09-24 09:38:11 +02:00
Sébastien Han 81329091da Merge pull request #8799 from travisn/remove-flex-driver
build: Remove deprecated flex driver and update the min K8s version to v1.16
2021-09-24 09:37:03 +02:00
Travis Nielsen f5c1543ddf build: update min k8s version to 1.16
In Rook v1.8 the min version of K8s supported is updated to 1.16.
Users running on older versions of K8s are recommended to update
to 1.16 or newer before updating to Rook v1.8.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-09-23 16:17:56 -06:00
Travis Nielsen 0a0b9c98bd build: remove obsolete flex driver
The flex driver has been fully deprecated and thus removed from Rook.
Before upgrading to v1.8, users will need to convert existing flex volumes
from flex to csi volumes.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-09-23 16:17:20 -06:00
Travis Nielsen ce52a07477 test: simplify instructions for minikube
Simplify the test documentation on running the integration tests
to clarify that any K8s cluster can be used, and only support
minikube in the instructions.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-09-23 22:16:53 +00:00
Travis Nielsen 76748f0419 test: remove obsolete minishift and kubeadm scripts
The test scripts to start minishift and kubeadm are no
longer in use by Jenkins or anyone else.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-09-23 22:16:53 +00:00
Travis Nielsen f16f7916e0 Merge pull request #8816 from travisn/latest-ceph-base
ceph: Pick up latest ceph base image 16.2.6-20210918
2021-09-23 15:43:13 -06:00
Travis Nielsen fb74e7b2d5 ceph: pick up latest ceph base image 16.2.6-20210918
The previous base image in use by rook v16.2.6-20210916 disappeared
from quay.io.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-09-23 15:11:34 -06:00
Blaine Gardner 823d045f48 Merge pull request #8751 from BlaineEXE/add-error-type-assertion-to-exec-package
core: add missing error type check to exec
2021-09-23 14:25:36 -06:00
Arun Kumar Mohan 55faa31230 ceph: prometheus rules format changes
Due to the latest jsonnet and jsonnetfmt, v0.17.0, we have the
`description` and `message` lines format changed.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2021-09-24 01:13:59 +05:30
Blaine Gardner def4ca57fe Merge pull request #8796 from BlaineEXE/test-multiple-object-stores
test: run multiple object stores at once in CI
2021-09-23 13:31:47 -06:00
Travis Nielsen 99ad62f62c Merge pull request #8090 from valentin-krasontovitsch/patch-1
ceph: Fix typo in dashboard admin password
2021-09-23 12:57:30 -06:00
Valentin Krasontovitsch 0aab5cfc31 docs: fix typo in dashboard admin password
Corrected secret name for admin password in description.

Signed-off-by: Valentin Krasontovitsch <valkra@ihelse.net>
2021-09-23 12:01:24 -06:00
Travis Nielsen 09a5b08fde Merge pull request #8766 from thotz/regionfixobcprovisioning
ceph: pass region to newS3agent()
2021-09-23 11:24:55 -06:00
Juan Miguel Olmo Martínez 1649df0462 ceph: retry <ceph orch> commands when they fail
fixes: https://github.com/rook/rook/issues/8759

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2021-09-23 14:29:26 +02:00
Travis Nielsen 4583a80001 Merge pull request #8790 from travisn/test-local-build
test: Run all integration tests against the local build
2021-09-22 14:31:18 -06:00
Blaine Gardner bc494f5174 core: add missing error type check to exec
In ExtractExitCode, there is one error type that can be valid as a
pointer or not-as-a-pointer. Add a case to the type check for the
non-pointer condition.

Resolves #8280

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-22 14:16:52 -06:00
Travis Nielsen 9fa8c5df08 Merge pull request #8798 from travisn/master-doc-links
docs: Update master doc links to latest
2021-09-22 14:07:10 -06:00
Blaine Gardner b9ebf280fa test: run multiple object stores at once in CI
Multiple CephObjectStores should be able to run at the same time. In CI,
test this by:
1. Create the primary object store under test (store A) (this was
   already done)
2. Verify that store A starts and becomes ready (already done but is
   moved here)
3. Create a second object store (store B) (new)
4. Verify that store B starts and becomes ready (new)
5. Delete store B, and ensure it is deleted (new)
6., etc. Continue to verify primary store A operations as before (this
  was already done)

This is necessary to ensure that the Rook operator is using
`radosgw-admin` and the RGW Admin Ops API properly to support multiple
ObjectStores running at once.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-22 13:27:35 -06:00
Travis Nielsen 0591753673 docs: update master doc links to latest
With the renaming of master docs to latest, all the links also
need to be updated.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-09-22 12:41:32 -06:00
Travis Nielsen 0ec1303606 Merge pull request #8729 from Madhu-1/fix-8153
ceph: make provisioner replicas configurable
2021-09-22 11:00:00 -06:00
Travis Nielsen 9ff0753514 test: run all integration tests against the local build
The integration tests must always be run against the local
build of rook, and an image should never be pulled from dockerhub.
To prevent pulling a release or master tag, the local build
will use a tag specific to the build and not ever published
elsewhere.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit a8a40428b0)
2021-09-22 07:39:42 -06:00
Sébastien Han e8d540c11f Merge pull request #8785 from leseb/fix-multisite
ci: fix multisite test
2021-09-22 15:37:29 +02:00
Travis Nielsen cd6ee3bce8 Merge pull request #8739 from Madhu-1/reduce-csi-permission
ceph: modify CephFS provisioner permission
2021-09-22 07:31:04 -06:00
Sébastien Han 56b5068712 Merge pull request #8765 from BlaineEXE/fix-object-debug-message
rgw: fix misleading log line in rgw health checker
2021-09-22 11:06:05 +02:00
Sébastien Han 7c8dc4bc1a ci: fix multisite test
We just need to wait a little for the object to be replicated to the
other gateway. A simple retry solves this.

Closes: https://github.com/rook/rook/issues/8671
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-22 10:23:02 +02:00
Madhu Rajanna 95775fd445 ceph: modify CephFS provisioner permission
As like RBD, CephFS provisioner pod need not to
run as privileged. as its not doing any operation
like plugin pods which does mounting and unmounting
removing the permissions for the same.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2021-09-22 13:30:05 +05:30
Sébastien Han 50fb1b7086 Merge pull request #8756 from humblec/min-version
ceph: lift minimum supported version of ceph csi to v3.3.0
2021-09-22 09:50:40 +02:00
Blaine Gardner c8b26e458c rgw: fix misleading log line in rgw health checker
There was a log line that informed that the object store status would
not be updated because the status was deleting erroneously. Move the
line to the correct position.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-22 07:33:57 +00:00
Madhu Rajanna ed5f281a74 ceph: make provisioner replicas configurable
added new option to set the provisioner replicas.
with this new option the user/admin can choose
how many replicas he want for provisioner pod if
number of nodes is greater than 1.

fixes #8153

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2021-09-22 11:24:53 +05:30
Humble Chirammal 731b0f5274 ceph: lift minimum supported version of ceph csi to v3.3.0
With the release of Ceph CSI 3.4.0, Ceph CSI project came up
with a new support policy where we support only versions >= 3.3.0

The supported window of Ceph CSI versions is known as "N.(x-1)":
 (N (Latest major release) . (x (Latest minor release) - 1)).

For example, if Ceph CSI latest major version is 3.4.0 today,
support is provided for the versions above 3.3.0.
If users are running an unsupported Ceph CSI version, they will be
asked to upgrade when requesting support for the cluster.

This PR lift the minimum supported version of Ceph CSI to 3.3.0
in this repo.

Fix https://github.com/rook/rook/issues/8709

Ref #
https://github.com/ceph/ceph-csi/releases/tag/v3.4.0
https://github.com/ceph/ceph-csi/#known-to-work-co-platforms

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2021-09-22 10:16:43 +05:30
Travis Nielsen 6bcb569a88 Merge pull request #8771 from kubealex/patch-1
helm: Add possibility to default filesystem storageclass in rook-ceph-cluster chart
2021-09-21 13:05:22 -06:00
kubealex d5f42aa4a1 ceph: corrected placement of values
I fixed the placement of the modification, from object storage to filesystem

Signed-off-by: kubealex <al.rossi87@gmail.com>
2021-09-21 20:07:27 +02:00
Travis Nielsen 18707ffdf5 Merge pull request #8772 from leseb/admin-user-secondary-cluster
rgw: do not create the rgw ops user on the secondary cluster
2021-09-21 11:45:17 -06:00
Sébastien Han 8786b40d64 rgw: do not create the rgw ops user on the secondary cluster
If the cluster where the rgw is started is secondary and not primary,
trying to create the admin ops user will fail with:

```
Please run the command on master zone.
Performing this operation on non-master zone
leads to inconsistent metadata between zones
```

So we need to force the creation regardless, it is fine the creation will
return UserAlreadyExist and then we just read the current user.

Closes: https://github.com/rook/rook/issues/8671
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-21 16:58:03 +02:00
Sébastien Han 470fbfd341 Merge pull request #8743 from leseb/next-pacific
ceph: use next ceph v16.2.6 pacific version
2021-09-21 16:41:45 +02:00
Sébastien Han c1a88f34d4 mds: change init sequence
The MDS core team suggested with deploy the MDS daemon first and then do
the filesystem creation and configuration. Reversing the sequence lets
us avoid spurious FS_DOWN warnings when creating the filesystem.

Closes: #8745
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-21 15:43:34 +02:00
Alessandro Rossi 4b20c5ce6b Merge branch 'rook:master' into patch-1 2021-09-21 14:49:37 +02:00
kubealex eead60457b ceph: add default field to filesystem-sc helm chart
I Added the chance to default filesystem storageclass in helm chart

Signed-off-by: kubealex <al.rossi87@gmail.com>
2021-09-21 14:49:03 +02:00
Jiffin Tony Thottan 280c29f330 ceph: pass region to newS3agent()
If the region is specified in the storage class of OBC, use that in the
newS3agent() than using constant "us-east-1".

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2021-09-21 13:08:18 +05:30