Commit Graph
13292 Commits
Author SHA1 Message Date
Blaine Gardner eed91efdc2 Merge pull request #8667 from thotz/enhanceusernits
ceph: addressing nits from #8211
2021-09-09 12:10:51 -06:00
Blaine Gardner 91ec1ac4db docs: ceph: add peer spec migration to upgrade doc
Add a section to the upgrade doc instructing users to (and how to)
migrate `CephRBDMirror` `peers` spec to individual `CephBlockPools`.
Adjust the pending release notes to refer to the upgrade section now,
and clean up a few references in related docs to make sure users don't
miss important documentation.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-09 11:46:29 -06:00
Travis Nielsen d193a23f7e Merge pull request #8677 from leseb/fix-arrray
ci: fix pod list
2021-09-09 11:05:22 -06:00
Sébastien Han 3c1c3409b1 Merge pull request #8668 from Muyan0828/fix/osd-full-alert-query
ceph: fix CephOSDCriticallyFulla and CephOSDNearFull Alert Query
2021-09-09 19:01:06 +02:00
Travis Nielsen af63a36647 Merge pull request #8666 from hall/master
ceph: add networking.k8s.io/v1 Ingress chart compatability
2021-09-09 10:59:58 -06:00
Sébastien Han 0e961c4bdc ci: stop build 3 times
This time for real.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-09 17:51:03 +02:00
Sébastien Han 73c340ded7 ci: fix pod list
We should not use .items[0].metadata.name if the array length is 0. This
is the case when nothing has been initialized yet. Instead, we should
use .items[*].metadata.name, the wildcard ensures to always return 0
even if nothing is present yet.

Fixes: https://github.com/rook/rook/issues/8676
Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-09 17:24:56 +02:00
Sébastien Han 031be4be19 Merge pull request #8675 from subhamkrai/ok-continue
ceph: modify the log info when ok to continue fails
2021-09-09 17:22:13 +02:00
subhamkraiandZeaone 0657804491 ceph: modify the log info when ok to continue fails
correct typo in logging, it was showing `ok-to-stop`
instead of `ok-to-continue` when 'continueUpgradeAfterChecksEvenIfNotHealthy' is true

Co-Authored-by: Zeaone <zeaone@ZeaonedeMacBook-Pro.local>
Signed-off-by: subhamkrai <srai@redhat.com>
2021-09-09 19:42:06 +05:30
parth-grandFabio Nitto fdae56dd3b docs: correct indentation for topologyKey
fixed the incorrect indentation for topologyKey
in ceph-cluster-crd doc and storage-class-device-set doc

Co-authored-by: Fabio Nitto
Signed-off-by: parth-gr <paarora@redhat.com>
2021-09-09 19:33:50 +05:30
chengli f2c9793fca ceph: fix CephOSDCriticallyFulla and CephOSDNearFull Alert Query
Add hostname to CephOSDCriticallyFull and CephOSDNearFull rules's expr

Signed-off-by: chengli <chengli@alauda.io>
2021-09-09 21:58:14 +08:00
Travis Nielsen 3e14dbbb85 Merge pull request #8670 from leseb/print-output
ceph: print the output on errors
2021-09-09 07:32:21 -06:00
Bryton Hall 5e4ed30bc9 ceph: add networking.k8s.io/v1 Ingress chart compatability
Kubernetes cluster versions 1.22+ must use the v1 Ingress version.

Signed-off-by: Bryton Hall <email@bryton.io>
2021-09-09 09:11:49 -04:00
Sébastien Han b7f55362b2 ceph: print the output on errors
Sometimes the error does not tell much, so as `exit status 1` and
printing the output along returning the error is useful.

For instance, I saw a job failing with no osd and the prepare job had
those lines:

```
exec: Running command: lsblk /dev/sdb1 --bytes --nodeps --pairs ....
inventory: skipping device "sdb1". exit status 1
```

We need to understand more about the lsblk issue.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-09 12:42:01 +02:00
Jiffin Tony Thottan 50ecff8f13 ceph: addressing nits from #8211
Addressing remaining nits from the PR #8211

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2021-09-09 12:57:32 +05:30
Blaine Gardner 5b0785dde0 Merge pull request #8211 from thotz/enhancecephuser
ceph: add options for cephobjectstore user
2021-09-08 11:57:25 -06:00
Travis Nielsen af8b4c116b Merge pull request #8653 from JrCs/externalip-failover
ceph: use node externalIP if no internalIP defined
2021-09-08 09:07:25 -06:00
Sébastien Han f9e50d09b2 Merge pull request #8659 from leseb/fix-pool-deletion-multus
ceph: fix pool deletion when running on multus
2021-09-08 16:49:49 +02:00
JrCs c606f4c488 ceph: use node externalIP if no internalIP defined
In some cases node internalIP is not defined. Then use externalIP if it
exists.

Signed-off-by: JrCs <90z7oey02@sneakemail.com>
2021-09-08 16:26:05 +02:00
subhamkrai 7bc9a138f2 ci: image list for offline installation
create file tests/scripts/rook-ceph-image.txt which
will have list of images required for offline installation.

Closes: https://github.com/rook/rook/issues/6406
Signed-off-by: subhamkrai <srai@redhat.com>
2021-09-08 19:52:05 +05:30
Sébastien Han 4cb9b53487 ceph: fix pool deletion when running on multus
The ceph-block-pool controller was missing the network spec from the
cephcluster that contains all the details about networking.
So when the pool was deleting on multus the controller was not proxying
the rbd command to the mgr pod but executed the command in the operator
pod which does not have the network annotation and then connect to the
ceph cluster.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-08 16:10:31 +02:00
Sébastien Han 97155af393 Merge pull request #8655 from leseb/ci-failfast
ci: add failfast go flag to stop tests sooner (optional)
2021-09-08 15:36:28 +02:00
Sébastien Han 53ad7c73a1 ci: add failfast go flag to stop tests sooner (optionnal)
With the -failfast flag the tests will not continue when one of them
fails. This allows us to log in the runner and observe the exact state
of any failure.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-08 11:24:58 +02:00
Travis Nielsen 2983319b39 Merge pull request #8652 from anmolsachan/fix_cephMonQuorumAtRisk
ceph: fix CephMonQuorumAtRisk Alert Query
2021-09-07 11:39:21 -06:00
Jiffin Tony Thottan ca43800119 ceph: add options for cephobjectstore user
Adding options for quota, bucket limit, caps for the
`cephobjectstoreuser`.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2021-09-07 22:43:09 +05:30
Anmol Sachan a1efcd7617 ceph: fix CephMonQuorumAtRisk Alert Query
The updated query will work for single mon deployment and will work better for
deployments with five or more mons.

Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
2021-09-07 21:27:45 +05:30
Sébastien Han 507c51baaa Merge pull request #8624 from leseb/debug-object
ci: fix object store test
2021-09-07 17:57:40 +02:00
Sébastien Han 8f42bee563 ci: fix object store test
We just need to wait longer when the status is not ready. We needed
another sleep otherwise the status was never nil and the loop went too
fast. See:

```
2021-09-02 16:29:11.372249 I | integrationTest:
2021-09-02 16:29:11.374427 I | integrationTest:
2021-09-02 16:29:11.377764 I | integrationTest:
2021-09-02 16:29:11.379950 I | integrationTest:
2021-09-02 16:29:11.382084 I | integrationTest:
2021-09-02 16:29:11.385383 I | integrationTest:
2021-09-02 16:29:11.388499 I | integrationTest:
2021-09-02 16:29:11.391301 I | integrationTest:
2021-09-02 16:29:11.393545 I | integrationTest:
2021-09-02 16:29:11.396249 I | integrationTest:
```

Signed-off-by: Sébastien Han <seb@redhat.com>

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-07 17:15:20 +02:00
Satoru Takeuchi d0366dc18a Merge pull request #8650 from kubealex/fix-versions-ref
fixed typo on version reference in comment
2021-09-06 15:43:35 +09:00
injninja fd158de68d docs: fix typo on cluster crd in kubernetes example
I fixed a generic version typo (v14 instead of v16) to keep the CRD description up to date

Signed-off-by: kubealex <al.rossi87@gmail.com>
2021-09-05 17:58:00 +02:00
Travis Nielsen 5d136ac13d Merge pull request #8636 from travisn/allow-even-mons
ceph: Allow an even number of mons
2021-09-03 09:00:15 -06:00
Travis Nielsen 849f434a79 ceph: only allow up to 9 mons to be specified
Typical clusters only require 3 or maybe 5 mons. If someone really wants
to go crazy they can add more mons, but over 9 mons really should not be
used.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-09-03 07:43:41 -06:00
Travis Nielsen 1cb97574ea ceph: allow an even number of mons
While an even number of mons can cause lower availability of
mon quorum, it also can provide higher durability for the cluster.
Mon quorum can be restored from a single mon according to the
disaster recovery guide, so there may be scenarios where
an even number of mons may be preferable.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-09-03 07:43:32 -06:00
Travis Nielsen 1361823a29 Merge pull request #8593 from parth-gr/mgr-pdb
ceph: add pdb for mgr
2021-09-03 07:38:27 -06:00
parth-gr e50d83771e ceph: add pdb for mgr
Currently PDB for MGR is not been created,
Creating the PDB for MGR if its count is 2

Closes: https://github.com/rook/rook/issues/8275
Signed-off-by: parth-gr <paarora@redhat.com>
2021-09-03 14:30:58 +05:30
Travis Nielsen 8af24cf6d1 Merge pull request #8629 from llamerada-jp/ceph-fix-error-message
ceph: fix error message in UpdateNodeStatus
2021-09-02 11:17:10 -06:00
Travis Nielsen 790e01b007 Merge pull request #8638 from leseb/avoid-multiple-reconcile
ceph: avoid multiple reconciles of ceph cluster
2021-09-02 08:28:27 -06:00
Sébastien Han 072c8f43df ceph: do not reconcile if the op is not ready
When the op is initializing, the ceph config is not ready and thus we
should reconcile. This avoids a double reconcile.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-02 13:50:32 +02:00
Sébastien Han ab166742c5 ceph: avoid double reconcile with default value
When setting a default values with kubebuilder flags it seems that the
kube operator intercepts the API call, mutate the CR and inject it.
This results in two events, one for creation and one for edition and we
end up with 2 reconciles. Let's avoid this.

Signed-off-by: Sébastien Han <seb@redhat.com>
2021-09-02 13:49:52 +02:00
Hiroya Onoe 2ff5413b75 ceph: fix error message in UpdateNodeStatus
The error message in UpdateNodeStatus regards the second argument
as node name. However, it is a PVC name in OSD on PVC.

Signed-off-by: Hiroya Onoe <onoehiroya@gmail.com>
2021-09-02 02:43:16 +00:00
Blaine Gardner d577feac6d Merge pull request #8635 from BlaineEXE/fix-cross-build-run-script
build: fix cross build run script
2021-09-01 14:55:57 -06:00
Blaine Gardner 97075a2422 build: fix cross build run script
Fixes issues with the `build/run` tooling, notably for publishing images
where `build/run make <args>` would only result in `make` being called
without args.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-01 14:11:03 -06:00
Blaine Gardner 4c9decb9bb Merge pull request #8634 from BlaineEXE/debug-build-release-script
ci: add debugging to release build script
2021-09-01 14:00:27 -06:00
Blaine Gardner 7febd4e303 ci: add debugging to release build script
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-09-01 13:58:21 -06:00
Travis Nielsen 66c7c961cc Merge pull request #8617 from subhamkrai/push-build-failed
ci: build failed due unbound var
2021-09-01 10:24:56 -06:00
Travis Nielsen 1632af9b07 Merge pull request #8078 from parth-gr/osd-size
ceph: auto grow OSDs size on PVCs
2021-09-01 07:17:22 -06:00
Travis Nielsen afd809e894 Merge pull request #8615 from llamerada-jp/ceph-fix-set-owner-references
ceph: avoid duplicate ownerReferences
2021-09-01 07:16:08 -06:00
subhamkrai 3b99d24340 ci: build failed due unbound var
removing unused var which was making push build
action to fail due set -u which was added recently.

Closes: https://github.com/rook/rook/issues/8616
Signed-off-by: subhamkrai <srai@redhat.com>
2021-09-01 15:15:45 +05:30
parth-gr 827ee1d879 ceph: auto grow OSDs size on PVCs
When an OSD reaches OSD_NEARFULL state,
we have to manually increase the PVC volume claim
or manually increase the count of OSDs in the device set

Added a script auto-grow-storage.sh which will
i)automatically increase claim volume
ii)automatically add number of OSDs

Closes: https://github.com/rook/rook/issues/6101
Signed-off-by: parth-gr <paarora@redhat.com>
2021-09-01 12:57:42 +05:30
Blaine Gardner 0c5df27706 Merge pull request #8619 from BlaineEXE/remove-cassandra-nfs-backends
build: Remove NFS and Cassandra backends from the main repo since they have moved to a new repo
2021-08-31 15:25:20 -06:00