Commit Graph
13292 Commits
Author SHA1 Message Date
Travis Nielsen 56febf607b Merge pull request #16041 from obnoxxx/build-helm-index-merge-again
build: merge helm indexes instead of recreating for every release
2025-07-10 10:54:38 -06:00
Travis Nielsen 7de769c060 Merge pull request #16056 from travisn/mon-failover-host-net
mon: Failover with host network must use different node
2025-07-10 10:49:53 -06:00
Travis Nielsen 009e8eb254 Merge pull request #15666 from puskunalis/cleanup-fix-disk-shredding
osd: fix cleanup job disk shredding
2025-07-10 10:28:46 -06:00
Travis Nielsen aa61ddb57e mon: failover with host network must use different node
When a mon is failed over, the old mon is left in mon quorum
until the new quorum is confirmed in quorum. When host networking
is enabled, this may result in two mons being in quorum with the
same ip, if the new mon is scheduled on the same node as the
down mon. This results in daemon crashes in the cluster since
they are confused by multiple of the same ip in the mon map.

The solution is to avoid scaling down the bad mon when host networking
is enabled. This will ensure the new mon is not scheduled on the
same node as the previous mon. With host networking, either another
node is necessary or the original mon must come back online to
restore quorum.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-07-10 10:13:17 -06:00
Santosh Pillai a07f2478f3 core: init cephxStatus on cephCluster
Set cephXStatus on the CephCluster status to Uninitialized when the
cluster is first created.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2025-07-10 20:43:58 +05:30
subham rai 30a01c920e Merge pull request #16098 from rook/dependabot/github_actions/snyk/actions-28606799782bc8e809f4076e9f8293bc4212d05e
build(deps): bump snyk/actions from cdb760004ba9ea4d525f2e043745dfe85bb9077e to 28606799782bc8e809f4076e9f8293bc4212d05e
2025-07-08 20:52:29 +05:30
subham rai 2095518cf5 Merge pull request #16097 from rook/dependabot/github_actions/github/codeql-action-3.29.2
build(deps): bump github/codeql-action from 3.29.1 to 3.29.2
2025-07-08 20:52:24 +05:30
Travis Nielsen 865aaf13c7 Merge pull request #16105 from subhamkrai/discover-env-udev
operator: add missing udev env to discover pod
2025-07-08 08:27:01 -06:00
subhamkrai 2742a707cc operator: add missing udev env to discover pod
currently, we're setting the env `DISCOVER_DAEMON_UDEV_BLACKLIST`
in operator.yaml but we're not reading from the operator env and
setting the value to discover pod env.

Signed-off-by: subhamkrai <srai@redhat.com>
2025-07-08 17:13:01 +05:30
Travis Nielsen a00c6fba64 Merge pull request #15846 from patrostkowski/fix/mon-run-as-root-15564
mon: allow running mon pods as root
2025-07-07 16:08:48 -06:00
Travis Nielsen efd02dfc7a Merge pull request #16091 from sp98/rgw-keyrotation-failure
object: fail if keys didn't rotate.
2025-07-07 12:22:58 -06:00
Blaine Gardner c02632154c Merge pull request #16093 from OdedViner/fix_debug_ci_lable
ci: fix typo in debug-ci input for tmate action
2025-07-07 09:47:43 -06:00
dependabot[bot] 71e0ccaeb5 build(deps): bump snyk/actions
Bumps [snyk/actions](https://github.com/snyk/actions) from cdb760004ba9ea4d525f2e043745dfe85bb9077e to 28606799782bc8e809f4076e9f8293bc4212d05e.
- [Release notes](https://github.com/snyk/actions/releases)
- [Commits](https://github.com/snyk/actions/compare/cdb760004ba9ea4d525f2e043745dfe85bb9077e...28606799782bc8e809f4076e9f8293bc4212d05e)

---
updated-dependencies:
- dependency-name: snyk/actions
  dependency-version: 28606799782bc8e809f4076e9f8293bc4212d05e
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-07 14:58:58 +00:00
dependabot[bot] d1d35ee17e build(deps): bump github/codeql-action from 3.29.1 to 3.29.2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.1 to 3.29.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/39edc492dbe16b1465b0cafca41432d857bdb31a...181d5eefc20863364f96762470ba6f862bdef56b)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-07 14:43:44 +00:00
Oded Viner e58d0bd1c2 ci: fix typo in debug-ci input for tmate action
fixes a typo in the 'required' field of the debug-ci input in the
tmate_debug action. this prevented the input from being recognized
correctly by github actions.

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-07-07 17:07:15 +03:00
Santosh Pillai 9b742c781a object: fail if keys didn't rotate
Fail the reconcile if rgw key rotation fails. Currnetly we are just
logging it.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2025-07-04 12:21:45 +05:30
Elias Carter 5f2d6c01d7 osd: treat non existing OSD nodes as drained
If the node for an OSD does not exist within kubernetes, the PDB
reconciliation logic will fail to make progress. This can be problematic
as new OSDs added to the cluster may not be protected by OSD PDBs after
they are added since the PDB reconcilation logic is failing.

The solution is to treat non existing OSD nodes as drained which is
logically consistent with treating unschedulable OSD nodes as drained as
you cannot schedule a pod onto a node which does not exist.

Fixes: #16086

Signed-off-by: Elias Carter <elias@dropbox.com>
2025-07-02 18:41:24 +00:00
Blaine Gardner 5fec88e8c8 Merge pull request #16031 from OdedViner/doc_minikube
doc: switch linux minikube driver from kvm2 to qemu2
2025-07-02 09:44:08 -06:00
Deepika Upadhyay 43436a5b43 docs: add design doc for ceph nvmeof gateway
Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
2025-07-02 20:47:01 +05:30
Blaine Gardner b58ea6d98b Merge pull request #16080 from obnoxxx/dev-cluster-linux-qemu2
test: use qemu2 minikube driver  for Linux in the  create-dev-cluster script
2025-07-02 09:14:52 -06:00
Blaine Gardner 76c62ab2ed Merge pull request #16078 from raaizik/ra-16072
core: CephObjectRealm controller generated generated AccessKey invalid chars
2025-07-02 09:04:41 -06:00
Oded Viner 5183ecdff4 doc: switch linux minikube driver from kvm2 to qemu2
update the developer guide to use the qemu2 driver instead of kvm2
for minikube on linux.

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-07-02 14:48:04 +03:00
Michael Adam 849e9a48cb test: use the qemu2 minikube driver on Linyx for create-dev-cluster
The create-dev-cluster script used the kvm2 minikube driver on Linux.

On newer Linux flavors like Fedora 41+, the kvm2 driver can have problems
and the qemu2 driver is recommended.

This changes the script to use the qemu2 driver for  Linux

Signed-off-by: Michael Adam <obnox@samba.org>
2025-07-01 19:35:29 +02:00
raaizik 1b3f36ff5c core: fix CephObjectRealm controller generated generated AccessKey invalid chars
Suggested fix for issue https://github.com/rook/rook/issues/16072
Adds key type differentiation to exclude invalid characters from AccessKey

Signed-off-by: raaizik <132667934+raaizik@users.noreply.github.com>
2025-07-01 18:32:48 +03:00
subham rai c90ce00902 Merge pull request #16076 from rook/dependabot/github_actions/github/codeql-action-3.29.1
build(deps): bump github/codeql-action from 3.29.0 to 3.29.1
2025-07-01 11:11:45 +05:30
dependabot[bot] e0ba3767a4 build(deps): bump github/codeql-action from 3.29.0 to 3.29.1
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.0 to 3.29.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/ce28f5bb42b7a9f2c824e633a3f6ee835bab6858...39edc492dbe16b1465b0cafca41432d857bdb31a)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-30 15:35:01 +00:00
Travis Nielsen 38739a5bbc Merge pull request #16061 from Madhu-1/create-csi-user
csi: Provide a flag to skip csi user creation
2025-06-27 14:50:35 -06:00
Madhu Rajanna 5094b1f5e6 csi: provide a flag to manage csi users
Added a flag in cephcluster CR CSI section
whether the user wants the Rook to manage
the csi users and secrets or create them on own.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-06-27 20:03:04 +00:00
Blaine Gardner 936aa05584 Merge pull request #16059 from Madhu-1/skip-csi-user-creation
ceph: Provide an option to specify the secretName in the cephClient CR
2025-06-27 13:49:30 -06:00
Madhu Rajanna d37297475e core: update secret handling for cephclient
If RemoveSecret is set remove the secret.
if not set, do below
check if the current cephClient is owner if
secret is present, if not return as its owned
by other controller, if its not present create
or update the secret.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-06-27 21:25:48 +02:00
Madhu Rajanna d6d2e604fc core: provide option to specify secret name
When cephClient CR is created by User, the Rook
is creating an User and creating an secret with
its own predefined name + CR name, With this we
are allowing user to specify the secretName

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-06-27 16:44:23 +02:00
subham rai a4cd5a6850 Merge pull request #16045 from rook/dependabot/github_actions/dcarbone/install-jq-action-3.2.0
build(deps): bump dcarbone/install-jq-action from 3.1.1 to 3.2.0
2025-06-26 09:39:43 +05:30
Travis Nielsen af226f7bdc Merge pull request #16055 from obnoxxx/helm-support-six-latest-helm-versions
helm: support the six most recent helm versions
2025-06-25 13:02:03 -06:00
Michael AdamandTravis Nielsen 42d0531be2 helm: support the six most recent minor helm versions
Now rook supports the six most recent minor versions of helm along with
their patch updates. I. e. helm 3.13 and newer is supported.

Fixes: #15980

Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Michael Adam <obnox@samba.org>
2025-06-25 20:22:41 +02:00
Travis Nielsen d6ebc96be9 Merge pull request #16025 from Nordix/add-host-network-cephexporter/adil
exporter: Add Hostnetwork bool to ceph-exporter
2025-06-24 14:49:36 -06:00
Muhammad Adil Ghaffar 5ea7a177b7 exporter: add hostnetwork bool to cephexporter
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
2025-06-24 23:17:51 +03:00
Travis Nielsen f69f704d32 Merge pull request #16050 from Madhu-1/csi-3.14.1
csi: update csi version to 3.14.1
2025-06-24 10:39:42 -06:00
subham rai eaa71a6003 Merge pull request #16042 from subhamkrai/skip-updating-csi-config-cm
csi: test skip updating rook-ceph-csi-config cm
2025-06-24 15:58:38 +05:30
Madhu Rajanna aa8fd61986 csi: update csi version to 3.14.1
Updating the cephcsi version to v3.14.1
release.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-06-24 11:46:14 +02:00
subhamkrai b4e7fd3926 csi: test skip updating rook-ceph-csi-config cm
When the csi-operator is enabled no need to update
the cm rook-ceph-csi-config configmap.
Otherwise operator will complain about the error
```yaml
ceph-cluster-controller: failed to reconcile CephCluster "rook-ceph/rook-ceph". failed to reconcile cluster "rook-ceph": failed to configure local ceph cluster: failed to create cluster: failed to start ceph monitors: failed to initialize ceph cluster info: failed to save mons: failed to update csi cluster config: waiting for CSI config map to be created: configmaps "rook-ceph-csi-config" not found
```

Signed-off-by: subhamkrai <srai@redhat.com>
2025-06-24 15:09:16 +05:30
Vilius Puškunalis 27010f96f3 osd: fix cleanup job disk shredding
Fixes quick disk shredding by using dd to shred data at additional offsets where ceph metadata is duplicated. For full shred, the shred utility remains in use.

Signed-off-by: Vilius Puškunalis <47086537+puskunalis@users.noreply.github.com>
2025-06-23 21:46:41 +03:00
Travis Nielsen 8bd54baf2c Merge pull request #16038 from OdedViner/cephobjcuserer_delete
object: allow deletion of CephObjectStoreUser even if secret is missing
2025-06-23 10:51:27 -06:00
Michael AdamandTravis Nielsen 987e9c8bb5 build: merge helm indexes instead of recreating for every release (really)
A new helm repo index was created from scratch for every new release
    which meant that the release timestamps in the index were basically all
    identical.

    This change intends to fix that by merging the new index with the
    existing one

The first attempt to fix this (PR #16033) did not work properly.
This change is intended to fix the issue for good by closing the gap the
previuous PR has left.

    Fixes: #15604

Co-Authored-By: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Michael Adam <obnox@samba.org>
2025-06-23 16:57:33 +02:00
dependabot[bot] eadb8b8795 build(deps): bump dcarbone/install-jq-action from 3.1.1 to 3.2.0
---
updated-dependencies:
- dependency-name: dcarbone/install-jq-action
  dependency-version: 3.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-23 14:46:26 +00:00
Oded Viner 8249a28145 object: allow deletion of CephObjectStoreUser even if secret is missing
skip key generation during reconcile if CephObjectStoreUser is
being deleted to allow cleanup when referenced secret is missing

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-06-22 09:14:50 +03:00
Travis Nielsen 80563e28b6 Merge pull request #16033 from obnoxxx/build-helm-index-merge
build: merge helm indexes instead of recreating for every release
2025-06-19 14:31:22 -06:00
Michael Adam 2704f23ea7 build: merge helm indexes instead of recreating for every release
A new helm repo index was created from scratch for every new release
which meant that the release timestamps in the index were basically all
identical.

This change intends to fix that by merging the new index with the
existing one

Fixes: #15604

Signed-off-by: Michael Adam <obnox@samba.org>
2025-06-19 22:24:07 +02:00
Blaine Gardner c3ee142866 Merge pull request #16003 from BlaineEXE/osd-allow-manual-rotation
osd: load latest cephx key during osd pod init
2025-06-19 13:57:36 -06:00
subham rai fcbcf692f6 Merge pull request #16026 from molpako/refactor/remove-redundant-err-check
osd: remove redundant err check
2025-06-19 12:49:39 +05:30
Kyori Sakao 015e4f4ecf osd: remove redundant err check
remove redundant nested `if err != nil` checks

Signed-off-by: Kyori Sakao <system.222.down@gmail.com>
2025-06-19 10:08:33 +09:00