Commit Graph
13292 Commits
Author SHA1 Message Date
Travis Nielsen 19d1e5a8dd Merge pull request #16027 from ideepika/wip-fix-upgrade-doc
docs: clarify Ceph version support phrasing in upgrade docs
2025-06-18 11:55:59 -06:00
Deepika Upadhyay 984ae7a0f3 docs: clarify Ceph version support phrasing in release notes
Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
2025-06-18 23:12:12 +05:30
Blaine Gardner 2c7a5f156b osd: load latest cephx key during osd pod init
Create a new OSD pod init container that loads the latest CephX key for
the OSD. The init container must be run after OSD activation, due to
keyfile reset behavior of ceph-bluestore-tool, used during activation.

The primary purpose of this work is to allow OSDs to start and run
correctly after key rotation, whether done manually by users or
automatically by future Rook work.

This work makes redundant prior code changes done in #14826. The CI test
added in the prior work is kept to ensure no regression.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2025-06-18 10:49:19 -06:00
subham rai 1599042236 Merge pull request #16023 from BlaineEXE/build-x86
build: allow make build for different arch
2025-06-18 14:35:19 +05:30
Blaine Gardner 21d3dddda7 build: allow make build for different arch
Allow `make build` to perform cross-architecture builds by using
`make GOARCH=<arch> build`.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2025-06-17 14:05:12 -06:00
Travis Nielsen c8e40d4da2 Merge pull request #16009 from sp98/fix-rns-deletion
rbd: blocklist rns image watchers
2025-06-17 11:35:55 -06:00
Santosh Pillai 98475e847e pool: blocklist rns image watchers
When force-deletion annotation is added to CephRadosNamespace CR, then
blocklist any watchers on the Namespace images in order to remove the
image from the trash

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2025-06-17 21:21:33 +05:30
Travis Nielsen ff99d9366f Merge pull request #16016 from obnoxxx/helm-cluster-deployment-guide
helm: improve the cluster deployment guide
2025-06-17 09:00:46 -06:00
Michael AdamandTravis Nielsen 1908218f3d helm: improve the cluster deployment guide
This improves the guide for deploying ceph clusters with helm
from development builds.

The missing piece was deploying the operator chart before the cluster
chart. The operator chart is needed as it installs the CRDs

Signed-off-by: Michael Adam <obnox@samba.org>
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
2025-06-17 16:32:18 +02:00
Travis Nielsen 55c3e4d249 Merge pull request #15997 from subhamkrai/fix-code-syntax
osd: code cleanup in getSecret method
2025-06-17 07:39:31 -06:00
subhamkrai 0123ab0ab3 osd: code cleanup in getSecret method
This change refactors the getSecret method somewhat toward cleaner code.
The only additional change in behavior is the introduction of a switch instead
of multiple if's and error treatment of the case of an empty secret.

Signed-off-by: subhamkrai <srai@redhat.com>
2025-06-17 17:16:48 +05:30
subham rai 3bca305a64 Merge pull request #16013 from travisn/contains-images
namespace: Report empty condition for rados namespace
2025-06-17 10:01:41 +05:30
Patryk Rostkowski 7f3e6bd7fa mon: allow running mon pods as root
This change addresses a permission issue where mon pods crashloop
on some Kubernetes setups with SELinux enabled, even when
ROOK_HOSTPATH_REQUIRES_PRIVILEGED is set.

To resolve this, a new function makeMonSecurityContext() was introduced
to explicitly set runAsUser: 0 at the pod level for mon pods
when the environment variable ROOK_CEPH_MON_RUN_AS_ROOT is set to true.

Additionally, the function previously named PodSecurityContext() was renamed
to DefaultContainerSecurityContext() to avoid confusion between
container-level and pod-level security context configuration. All container
SecurityContext usages across Ceph daemons were updated to reflect this change.

This ensures the root user configuration is applied
automatically and consistently in environments where it is required
for mon pod startup, while preserving clear separation of container
and pod-level security logic.

Signed-off-by: Patryk Rostkowski <patrostkowski@gmail.com>
2025-06-16 18:29:31 +02:00
Travis Nielsen d7d399819d Merge pull request #16000 from OdedViner/delete-csi-cm
csi: delete rook-ceph-csi-config if csi operator is enabled
2025-06-16 10:27:53 -06:00
Travis Nielsen fd157db724 Merge pull request #16014 from microyahoo/fix_link
docs: fix invalid document links
2025-06-16 10:16:24 -06:00
subham rai 3b5f7c4ca5 Merge pull request #16015 from rook/dependabot/github_actions/github/codeql-action-3.29.0
build(deps): bump github/codeql-action from 3.28.19 to 3.29.0
2025-06-16 21:30:09 +05:30
dependabot[bot] 43e43d2d01 build(deps): bump github/codeql-action from 3.28.19 to 3.29.0
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.19 to 3.29.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/fca7ace96b7d713c7035871441bd52efbe39e27e...ce28f5bb42b7a9f2c824e633a3f6ee835bab6858)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-16 13:21:27 +00:00
Liang Zheng eca3c1a1c0 docs: fix invalid document links
Signed-off-by: Liang Zheng <zhengliang0901@gmail.com>
2025-06-16 11:56:09 +08:00
Oded Viner 0a9100be83 csi: delete rook-ceph-csi-config if csi operator is enabled
removes the rook-ceph-csi-config configmap when
switching to external csi operator

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-06-15 12:48:24 +03:00
Travis Nielsen 1acf77ad26 Merge pull request #16010 from obnoxxx/ci-lint-cluster-chart
ci: enable linting of the rook-ceph-cluster chart
2025-06-13 12:19:50 -06:00
Travis Nielsen b47f297608 namespace: report empty condition for rados namespace
The rados namespace status was not reporting if the namespace
was empty. Now the condition will be properly updated if
it is empty.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-06-13 10:06:37 -06:00
Michael Adam 0cd75c6206 ci: enable linting of the rook-ceph-cluster chart
Previously, only the rook-ceph operator chart was linted in the CI.

With this change, the rook-ceph-cluster chart is linted additionally.

for developer convenience, The linting is realized via a new make target
'helm.lint'that can easily be invoked locally if the chart-testing tool
'ct' is available.

Fixes: #15966

Signed-off-by: Michael Adam <obnox@samba.org>
2025-06-13 17:28:59 +02:00
Travis Nielsen f1b5d7cea3 Merge pull request #16005 from cybozu-go/osd-update-allowed-configurations-table
osd: update the table of allowed configutations
2025-06-13 09:18:55 -06:00
Travis Nielsen 9ff693e225 Merge pull request #16011 from Madhu-1/remove-dead-code
ceph: remove dead code
2025-06-13 09:13:05 -06:00
Madhu Rajanna 4da69e6801 core: remove dead code
There are image create,delete,map
and unmap functions added very long back
when Rook was supporting flex driver. As
we dont have support for it and Rook doesnt
create or map rbd images. Moving the dead
code from the repo.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2025-06-13 15:10:57 +02:00
Travis Nielsen e53aaf79eb Merge pull request #16002 from obnoxxx/ci-stop-using-helm-sh-up
ci: don't use helm.sh up and remove helm.sh
2025-06-12 14:22:15 -06:00
Satoru Takeuchi 0b77d4671a osd: update the table of allowed configutations
OSD on crypt device in host-based cluster is not allowed.

ref.
https://github.com/rook/rook/issues/15861

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2025-06-12 20:10:55 +00:00
Michael AdamandTravis Nielsen 2ea9630aa2 docs: improve the Contributing guide regarding helm installation
This change clarifies the description of the test environment in the
contributing guide with respect to the installation of helm.

Signed-off-by: Michael Adam <obnox@samba.org>
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
2025-06-12 20:10:27 +02:00
Michael Adam a699bcec06 ci: remove unused script helm.sh
The script tests/scripts/helm.sh was previously used by some ci
workflows to install helm.

Now that this is not used anymore, this change removes the script.

Signed-off-by: Michael Adam <obnox@samba.org>
2025-06-12 19:47:24 +02:00
Michael AdamandTravis Nielsen fc10f61444 ci: stop using helm.sh up
use setup-helm instead.

Signed-off-by: Michael Adam <obnox@samba.org>
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
2025-06-12 19:47:24 +02:00
Santosh Pillai 03fa5a6b9d Merge pull request #15972 from sp98/clean-encrypted-osd-disks-from-other-clusters
osd: wipe encryted osd disk from other cluster
2025-06-12 09:13:06 +05:30
Travis Nielsen 433a16c090 Merge pull request #15951 from OdedViner/target_size_ratio_negative
pool: support targetSizeRatio=0 and default compressionMode=""
2025-06-11 07:35:24 -06:00
subham rai 5a99d116c3 Merge pull request #15996 from OdedViner/fix-radosnamespace-log
core: fix radosnamespace log message
2025-06-11 17:36:55 +05:30
Oded Viner 41d6baf0e1 core: fix radosnamespace log message
change logger.info to logger.infof to correctly print
radosnamespace name and namespace

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-06-11 14:29:28 +03:00
Santosh Pillai 71bcdb533e osd: wipe encryted osd disk from other cluster
During the OSD preparation step, if the encrypted OSD disk belongs to a
different cluster, then clean the disk if `wipeDeviceFromOtherClusters`
is set to true.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
2025-06-11 15:22:28 +05:30
Oded Viner dd65dc15d8 pool: support targetSizeRatio=0 and default compressionMode=""
allow targetSizeRatio == 0
enforce targetSizeRatio >= 0 via +kubebuilder:validation
set targetSizeRatio and compressionMode="" if unset
remove IsTargetRatioEnabled() and IsCompressionEnabled()

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-06-11 12:36:19 +03:00
Blaine Gardner 029c345372 Merge pull request #15813 from BlaineEXE/auth-rotate
object: automate RGW cephx key rotation
2025-06-10 12:51:50 -06:00
Travis Nielsen a8ef4f8775 Merge pull request #15978 from travisn/roadmap-1.18
docs: Update roadmap for v1.18
2025-06-10 11:25:57 -06:00
Travis Nielsen 15ed0479a7 Merge pull request #15989 from parth-gr/fix-mirroring
rbdmirror: fix the nil point error check during status updates
2025-06-10 10:16:44 -06:00
Blaine Gardner 5f50e85a25 object: implement cephx key rotation for rgw keys
This is the first implementation of CephX key rotation in Rook.
Adds key rotation API from design PR 15915.

Also add helper methods for rotating keys, determining when keys
need to be rotated, and for generating CephX key statuses. These will be
reusable for other Rook reconciles beyond object/RGW.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2025-06-10 09:06:58 -06:00
parth-gr 0b4f89873c rbdmirror: fix the nil point error check during status updates
the status  was still reading from the nil state,
updated the code to dont read from  nil object

Signed-off-by: parth-gr <partharora1010@gmail.com>
2025-06-10 20:24:53 +05:30
Travis Nielsen 3ae7892991 Merge pull request #15957 from obnoxxx/helm-improve-helm-sh
Helm: improve implementation and documentation of  helm.sh
2025-06-10 07:54:15 -06:00
Travis Nielsen 8d392ff386 Merge pull request #15979 from hedgieinsocks/fix_promrule_old_helm
helm(rook-ceph-cluster): use nested if clauses in prometheusrule template
2025-06-09 16:13:00 -06:00
Artyom Babiy 1f183bd675 helm(rook-ceph-cluster): use nested if clauses in prometheusrule template
This change returns the use of nested if clauses
instead of `and` function shortcut to avoid errors
in older helm versions.

Signed-off-by: Artyom Babiy <artyom.babiy@gmail.com>
2025-06-09 23:22:10 +03:00
Travis Nielsen 7eae1b97bb docs: update roadmap for v1.18
Update the high level roadmap doc for the v1.18 release
targeted for August.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-06-09 14:10:50 -06:00
Travis Nielsen 884e6c905f Merge pull request #15928 from hedgieinsocks/allow_prom_rule_edit
helm(rook-ceph-cluster): allow prometheusrule edits
2025-06-09 11:57:17 -06:00
Travis Nielsen 428d15b35b Merge pull request #15974 from elias-dbx/rgw_docs_bullet_fix
doc: fixup bullet points on rgw docs
2025-06-09 11:01:51 -06:00
Elias Carter 5a292f1b52 doc: fixup bullet points on rgw docs
In #15961 I updated the rgw docs, but I was looking at the published
docs and the bulleting is broken now for Gateway Settings. When I was
working on the PR I was just using the markdown preview in my editor and
wan't using the `docs-preview` target. It turns out that the markdown
editor and mkdocs render things differently.

This PR fixes the bullet formatting and I verified the fix by running
`make docs-preview` on my box and double checking the local website.

Signed-off-by: Elias Carter <elias@dropbox.com>
2025-06-09 16:18:41 +00:00
subham rai 91300d718d Merge pull request #15970 from rook/dependabot/github_actions/github/codeql-action-3.28.19
build(deps): bump github/codeql-action from 3.28.18 to 3.28.19
2025-06-09 20:53:38 +05:30
subham rai ac20ac5627 Merge pull request #15971 from rook/dependabot/go_modules/golang.org/x/sync-0.15.0
build(deps): bump golang.org/x/sync from 0.14.0 to 0.15.0
2025-06-09 20:53:00 +05:30