feedc0de/my-rook-config
1
0 Fork 0
forked from rook/rook
Code Pull Requests Activity
11,197 Commits 38 Branches 289 Tags
d8428eeba94de17ee992c12dbc7cea7dd5f33dfe
Commit Graph
3 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Eng Zer Jun 77bff6a07c core: remove redundant len check 
From the Go specification [1]:

  "1. For a nil slice, the number of iterations is 0."
  "3. If the map is nil, the number of iterations is 0."

`len` returns 0 if the slice or map is nil [2]. Therefore, checking
`len(v) > 0` before a loop is unnecessary.

[1]: https://go.dev/ref/spec#For_range
[2]: https://pkg.go.dev/builtin#len

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2023-10-05 20:16:46 +08:00
Eng Zer Jun 8a25b1d903 test: use T.Setenv to set env vars in tests 
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2022-07-15 23:07:19 +08:00
Eng Zer Jun ed63571530 test: use T.TempDir to create temporary test directory 
The directory created by `T.TempDir()` and is automatically removed when
the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2022-01-24 23:52:54 +08:00