Commit Graph
11197 Commits
Author SHA1 Message Date
Travis Nielsen d8428eeba9 tests: retry helm upgrade during upgrade tests
The helm upgrade tests have been failing frequently, but not
always, on the oldest version of K8s that is tested in the CI
for the past few months. Add a retry to attempt to get
the CI passing more consistently.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 043b446675)
2024-07-24 19:31:28 +00:00
Travis Nielsen 2c71c4e919 Merge pull request #14490 from rook/mergify/bp/release-1.14/pr-14482
mgr: lookup cluster crd on active mgr watch (backport #14482)
2024-07-24 11:58:03 -06:00
Artem Torubarov 65ee4f9035 mgr: lookup cluster crd on active mgr watch
Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
(cherry picked from commit 3f2d0eb1f8)
2024-07-24 16:56:57 +00:00
mergify[bot] e9f70ec024 Merge pull request #14463 from rook/mergify/bp/release-1.14/pr-14420
csi: make kube apiserver qps configurable (backport #14420)
2024-07-16 18:55:40 +00:00
yite.gu 4b69af18a9 csi: make kube apiserver qps configurable
This commit adds the flexibility to configure kube apiserver qps
as per the user requirement and also keeps the existing values as
the default one.

Signed-off-by: yite.gu <yitegu0@gmail.com>
(cherry picked from commit 80541a23c9)
2024-07-16 12:28:17 -06:00
Blaine Gardner d221d9dcd7 Merge pull request #14452 from rook/mergify/bp/release-1.14/pr-14451
multus: reset validation tool debounce time to 30 (backport #14451)
2024-07-12 12:41:25 -06:00
Blaine Gardner 91685f0a04 multus: reset validation tool debounce time to 30
Reset the Multus validation tool debounce time to its intended 30 second
value. It was changed to 5 for testing, and the change was accidentally
committed.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 5884f1c900)
2024-07-11 18:07:57 +00:00
Blaine Gardner c652020fba Merge pull request #14450 from rook/mergify/bp/release-1.14/pr-14230
multus: add host checking to validation tool (backport #14230)
2024-07-11 12:06:01 -06:00
Blaine Gardner 745ad91974 multus: add host checking to validation tool
In order to help users check that they have implemented the newly-added
Multus host configuration prerequisites, add a check to the validation
tool to verify connectivity.

Because users who are already running clusters with Multus enabled, add
a flag that allows users to only check for host configuration
prerequisites. This mode will not start the large number of clients that
would normally be started because those clients could disrupt a running
Rook cluster negatively.

Host checking pods require host network access. Many Kubernetes
distributions have pod security features enabled. In order to allow
non-Vanilla distros to run this tool, allow specifying a service account
that pods will run as, which can be configured by the admin to allow
test pods.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 33f5407dd4)

# Conflicts:
#	Documentation/CRDs/Cluster/network-providers.md
#	deploy/examples/multus-validation.yaml
2024-07-11 11:25:15 -06:00
mergify[bot] 5db240dcad Merge pull request #14448 from rook/mergify/bp/release-1.14/pr-14447
pool: Skip updating crush rules for stretch clusters (backport #14447)
2024-07-10 19:00:02 +00:00
Travis Nielsen af8b1769df pool: skip updating crush rules for stretch clusters
Pools in stretch clusters must all specify the same
CRUSH rule. No pools can use a different rule. When there
is a change in the device class, we do not even expect to update
the crush rules in a stretch cluster. Different device classes
are not supported in stretch clusters, and it's expected to be
a homogenous environment. Therefore, skip all crush rule updates
in stretch clusters.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit b92bbba671)
2024-07-10 12:31:43 -06:00
Travis Nielsen 35b3b9e4ca Merge pull request #14417 from travisn/release-1.14.8
build: Update the release version to v1.14.8
v1.14.8
2024-07-03 13:20:18 -06:00
Travis Nielsen 61b19a2e2f build: update the release version to v1.14.8
For the patch release update the manifests and docs
to v1.14.8

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-07-03 12:12:13 -06:00
Travis Nielsen ef1859aad4 Merge pull request #14409 from rook/mergify/bp/release-1.14/pr-14408
csi: update csi-addons repo link (backport #14408)
2024-07-02 11:15:24 -06:00
Madhu Rajanna d1889fb5c1 csi: update csi-addons repo link
updating csi-addons repo link
to pull the yamls for installation

closes: #14394

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 266fd49c02)
2024-07-02 16:35:08 +00:00
subham rai af459c9813 Merge pull request #14392 from rook/mergify/bp/release-1.14/pr-14391
build: update go-retryablehttp from 0.7.6 to 0.7.7 (backport #14391)
2024-06-28 11:29:11 +05:30
subhamkrai e910215c4e build: update go-retryablehttp from 0.7.6 to 0.7.7
this commit updates go-retryablehttp from 0.7.6 to 0.7.7
and without this govulcheck ci is failing.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 9fbf3d3)

Signed-off-by: subhamkrai <srai@redhat.com>
2024-06-28 10:45:45 +05:30
subham rai e92e7427ef Merge pull request #14371 from rook/mergify/bp/release-1.14/pr-14367
osd: Use old passphrase to kill the LUKS slot (backport #14367)
2024-06-28 10:27:16 +05:30
Blaine Gardner c8c51a25c6 Merge pull request #14378 from rook/mergify/bp/release-1.14/pr-14374
osd: fix activate failure when block device moves (backport #14374)
2024-06-26 14:28:37 -06:00
Blaine Gardner 8a1a94708a Merge pull request #14389 from rook/mergify/bp/release-1.14/pr-14342
docs(fix): missing ** in filesystem-storage.md (backport #14342)
2024-06-26 14:08:26 -06:00
dbrennand 86a96f01c0 docs(fix): missing ** for bold text
In docs page Storage-Configuration/Shared-Filesystem-CephFS/filesystem-storage.md

Signed-off-by: dbrennand <52419383+dbrennand@users.noreply.github.com>
(cherry picked from commit e9ff24fec3)
2024-06-26 20:05:28 +00:00
Blaine Gardner 669e301147 Merge pull request #14383 from rook/mergify/bp/release-1.14/pr-14294
csi: skip creating networkFence when csi disabled (backport #14294)
2024-06-25 11:36:41 -06:00
subhamkrai 5ff5356a3f csi: skip creating networkFence when csi disabled
skip creating networkFence when 'ROOK_CSI_DISABLE_DRIVER' is set to
'false'.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 4be450ae4b)
2024-06-25 15:38:34 +00:00
Blaine Gardner 2f5ea65d1d osd: fix activate failure when block device moves
Block devices can move between reboots. In corner cases, an OSDs block
device might move to a lower-indexed device while the previous device
does not exist. For example, an OSD on /dev/sde might move to /dev/sdd
on reboot if the original /dev/sdd died. There would be no /dev/sde
after that.

Users report that NVMe drives commonly change names, even when there are
no disk failures.

For these cases, ensure the activate script properly handles cases where
the previous disk is not present on the node and where the OSD is still
available on a different disk.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit f2304bf8b8)
2024-06-25 14:08:24 +00:00
Niraj Yadav afad6aca63 osd: use old passphrase to kill the luks slot
While adding a new encryption key to slot 1
if there exists a key in slot 1 which is not
equal to the one we want to update it with,
we kill the slot and then add the new key to it.

While killing the slot, the existing code uses
the new key, which is not valid in such cases.

This patch modifies the code to use the key in
slot 0 (the one that we know works) to kill the slot.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit b8b7af3495)
2024-06-24 07:24:36 +00:00
Blaine Gardner e9b2c3ec7b Merge pull request #14360 from BlaineEXE/release-1.14.7
build: set release version to v1.14.7
v1.14.7
2024-06-21 11:55:03 -06:00
mergify[bot] 8a9455329b Merge pull request #14369 from rook/mergify/bp/release-1.14/pr-14362
core: revert increase storage deviceset name limit to 50 (backport #14362)
2024-06-21 16:21:49 +00:00
subhamkrai b37af76d85 osd: revert limit storageClassDeviceSets to 63 chars
This reverts commit 6f5cc9b01d.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit e8aeb0d263)
2024-06-21 15:54:49 +00:00
subhamkrai f6eff6dc71 core: revert increase storage deviceset name limit to 50
This reverts commit 1dcc99ec1d.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit c7d07562c4)
2024-06-21 15:54:48 +00:00
Blaine Gardner 297e582f2d build: set release version to v1.14.7
For the patch release update the examples and documentation
to v1.14.7

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-06-20 15:41:50 -06:00
subham rai ae08a2c5c1 Merge pull request #14359 from rook/mergify/bp/release-1.14/pr-14358
core: increase storage deviceset name limit to 50 (backport #14358)
2024-06-20 13:16:37 +05:30
subhamkrai 7caf672b74 core: increase storage deviceset name limit to 50
initially, we have the limit of 40 char set on
storageclassdeviceset.Name but seems like that is not enough and
upgrade clusters can face issue with this. So, increasing the limit to
50.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 1dcc99ec1d)
2024-06-20 06:57:04 +00:00
mergify[bot] 76d2902e75 Merge pull request #14348 from rook/mergify/bp/release-1.14/pr-14346
monitoring: fix CephPoolGrowthWarning expression (backport #14346)
2024-06-18 16:57:02 +00:00
Matej Feder 8521286ce3 monitoring: fix CephPoolGrowthWarning expression
Prometheus found duplicate series for the match group `pool_id`
and `instance` when evaluating the CephPoolGrowthWarning alert
expression. This alert has an evaluation interval of 2 days and
did not consider the changing POD names during the Rook migration process.

This commit adds the `pod` label to the set of considered labels.

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
(cherry picked from commit 6ba084f35a)
2024-06-17 18:24:50 +00:00
mergify[bot] d9ca8eeb06 Merge pull request #14340 from rook/mergify/bp/release-1.14/pr-14339
monitoring: Set honor labels on the service monitor (backport #14339)
2024-06-17 16:05:30 +00:00
Travis Nielsen fd28c8d805 monitoring: set honor labels on the service monitor
The endpoint property honorLabels: true should be set so that
different rgw instances can show separate prometheus
values instead of being aggregated.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit eed1033485)
2024-06-14 23:52:26 +00:00
Blaine Gardner e1a6f11f0e Merge pull request #14336 from BlaineEXE/release-1.14.6
build: set release version to v1.14.6
v1.14.6
2024-06-13 16:12:07 -06:00
Blaine Gardner 6a217cb40b build: set release version to v1.14.6
For the patch release update the examples and documentation
to v1.14.6

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-06-13 13:52:41 -06:00
Travis Nielsen a20981901b Merge pull request #14335 from rook/mergify/bp/release-1.14/pr-14331
core: Update go modules for snyk security check (backport #14331)
2024-06-13 11:55:22 -06:00
Travis Nielsen 04a7b46333 core: update go modules for snyk security check
The snyk security check started failing with a warning
about the package being outdated:
github.com/libopenstorage/secrets/azure which depends on
github.com/Azure/azure-sdk-for-go/sdk/azidentity.
These and related packages are now updated.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit c5fd5cd0b5)
2024-06-13 10:46:46 -06:00
Travis Nielsen 7b39bb5fe0 Merge pull request #14327 from rook/mergify/bp/release-1.14/pr-14323
helm: allow custom labels and annotations for storage classes (backport #14323)
2024-06-13 10:38:49 -06:00
Travis Nielsen 73e8765609 Merge pull request #14329 from rook/mergify/bp/release-1.14/pr-14325
pool: get the exact deviceClass name instead of crushroot+deviceClass (backport #14325)
2024-06-13 10:38:31 -06:00
Travis Nielsen 622e2000d5 Merge pull request #14333 from rook/mergify/bp/release-1.14/pr-13876
doc: add recommendation for nfs in external cluster (backport #13876)
2024-06-13 10:25:47 -06:00
parth-gr e881f7fa48 doc: add design to support nfs in external cluster
with recent discussion we come to conclusion
nfs can be suported easily in the external cluster
so adding the design that we discussed

closes: https://github.com/rook/rook/issues/13277

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 9be33bca53)
2024-06-13 15:47:46 +00:00
Deepika Upadhyay 222776b2f1 pool: get the exact deviceClass name instead of crushroot+deviceClass
this lead to creation of 2 crush rules because of difference in
deviceClass names:
eg:
creating a new crush rule for changed deviceClass
("default~hdd"-->"hdd") on crush rule "test-crush-bug-az-ab-4"

Signed-off-by: Deepika Upadhyay <deepikaupadhyay01@gmail.com>
(cherry picked from commit 41116be919)
2024-06-12 22:14:34 +00:00
Peter Dahlberg ed89e36c9f helm: allow custom labels and annotations for storage classes
Storage classes were missing the possilbilty to attach custom labels and
annotations. This change brings it on par with VolumeSnapshotClass
objects.

Signed-off-by: Peter Dahlberg <catdog2@tuxzone.org>
(cherry picked from commit de82481d80)
2024-06-12 13:34:29 +00:00
Travis Nielsen dbe24136ca Merge pull request #14321 from rook/mergify/bp/release-1.14/pr-14312
monitoring: update to the latest ceph prometheus rules (backport #14312)
2024-06-10 16:20:16 -06:00
Matej Feder 4253a04ea1 monitoring: update to the latest ceph prometheus rules
Pick up the latest ceph prometheus rules from the ceph repo
found at https://github.com/ceph/ceph/blob/master/monitoring/ceph-mixin/prometheus_alerts.yml.

The updates include new rules for monitoring of ceph as well as
adjustments related to the Rook ceph deployment.
List of main adjustments:
- Alerts related to cephadm are excluded
- The PrometheusJobMissing alert is adjusted for the rook-ceph-mgr job, and the PrometheusJobExporterMissing alert is added

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
(cherry picked from commit c0a0a3c7b2)
2024-06-10 21:18:12 +00:00
mergify[bot] 3f06a77d46 Merge pull request #14315 from rook/mergify/bp/release-1.14/pr-14313
monitoring: fix exporter service monitor selector (backport #14313)
2024-06-07 16:48:14 +00:00
Matej Feder 73d933ec45 monitoring: fix exporter service monitor selector
Exporter service created by rook operator contains the following labels:
`app=rook-ceph-exporter,rook_cluster=<cluster-name>`

Label `ceph_daemon_id=exporter` is not there and therefore the service
monitor selector can not discover the exporter service.

This fix removes the `ceph_daemon_id=exporter` label from the exporter
service monitor selector.

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
(cherry picked from commit 7053e761da)
2024-06-07 16:22:58 +00:00