Commit Graph
11197 Commits
Author SHA1 Message Date
Travis Nielsen 72193e915a Merge pull request #14306 from rook/mergify/bp/release-1.14/pr-14302
multus: add and test ipv6 support for validation tool (backport #14302)
2024-06-06 10:38:34 -06:00
Travis Nielsen 4602820580 Merge pull request #14310 from rook/mergify/bp/release-1.14/pr-13500
mon: Allow overriding the mon endpoint with annotation (backport #13500)
2024-06-06 10:38:01 -06:00
Travis Nielsen dec8fed5dc mon: allow overriding the mon endpoint with annotation
For an advanced network configuration, the mon endpoints
expected for the ceph public network may be different from
the public IP address that is set on the K8s node. When
host networking is enabled in rook, the IP address of the
node was only allowed previously. Now, the IP address
used for a mon when scheduled on a node can be determined
by setting an annotation on each node where mons can run:
    network.rook.io/mon-ip: <ip-address>
This annotation must be set before the mons are created.
Mon endpoints cannot be changed after they are already
running.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit e90ed3b912)
2024-06-06 15:31:01 +00:00
Blaine Gardner 424b1a6da3 multus: add and test ipv6 support for validation tool
Add IPv6 support for multus validation tool. Also test that IPv6 support
works by specifying one of the NetAttachDefs with an IPv6 address range.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 08a27940ed)
2024-06-04 19:20:31 +00:00
Blaine Gardner 4069450a57 Merge pull request #14301 from rook/mergify/bp/release-1.14/pr-14299
build: remove iproute build dependency on centos repo (backport #14299)
2024-06-03 15:47:30 -06:00
Blaine Gardner fab71d1f37 build: remove iproute build dependency on centos repo
Multus requires that the 'ip' tool be installed in the Rook image.
Today, it is present in the upstream Ceph base image that is used, but
that is expected to change in the future. The Ceph project intends to
switch to CentOS 9 minimal images, and the 'ip' tool will likely be
removed from the base image at that point.

However, Rook CI has occasionally had issues with the current 'dnf
install' command when CentOS repos go down, or when there is otherwise
some problem. Because the package is already installed today, there is
no need to hamstring Rook builds when CentOS is having problems. But we
do want to make sure that Rook builds don't silently succeed in the
eventual future when 'ip' tool is removed from the Ceph image.

For now, replace the 'dnf install' with a check to verify that 'ip' tool
is installed, and add a shorter form of this note as a comment above it
to help Rook maintainers know how to resolve future 'ip' tool removal.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit c4e99c1462)
2024-06-03 21:17:00 +00:00
mergify[bot] 92494cbb48 Merge pull request #14288 from rook/mergify/bp/release-1.14/pr-14287
build: add result of codegen (backport #14287)
2024-05-31 18:26:07 +00:00
Michael Adam 86bb07831e build: add result of codegen
`make codegen`resulted in a diff, so that needed to be committed.

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 823df7be98)
2024-05-31 17:58:32 +00:00
Travis Nielsen 13997eb003 Merge pull request #14285 from travisn/release-1.14.5
build: Set the release version to v1.14.5
v1.14.5
2024-05-30 14:12:22 -06:00
Travis Nielsen 155eec15ad build: set release version to v1.14.5
For the patch release update the examples and documentation
to v1.14.5

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-05-30 13:33:03 -06:00
Travis Nielsen 1f88479add Merge pull request #14284 from rook/mergify/bp/release-1.14/pr-14281
osd: Configure cluster full settings when OSDs fill up (backport #14281)
2024-05-30 13:30:44 -06:00
Travis Nielsen ad70539d28 osd: configure cluster full settings when osds fill up
When the clusters reach full, nearfull, or backfill full thresholds
ceph will raise health warnings and stop allowing IO or backfill
depending on the threshold. These settings require special ceph
commands instead of being generic ceph config. Allow these settings
to be set from the CephCluster CR in the spec.storage
section.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit e479b051bc)
2024-05-30 18:52:35 +00:00
Travis Nielsen 0b4b3501b8 Merge pull request #14239 from rook/mergify/bp/release-1.14/pr-14234
core: remove owner refs in resource cleanup jobs (backport #14234)
2024-05-30 12:27:44 -06:00
Travis Nielsen 6642e74754 Merge pull request #14280 from rook/mergify/bp/release-1.14/pr-14232
mgr: setting balancer mode from cluster spec. (backport #14232)
2024-05-30 12:25:52 -06:00
Travis Nielsen a7c81662da Merge pull request #14274 from rook/mergify/bp/release-1.14/pr-14257
osd: reduce safe-to-destroy retry timeout to 15s (backport #14257)
2024-05-30 12:25:34 -06:00
sp98 ad9f34bdd5 mgr: setting balancer mode from cluster spec
This PR adds a `settings` option in the `Module` struct
which can help users to futher customize the `balancer`
module with a differet mode.

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit 1ad37ecce9)
2024-05-29 16:45:02 +00:00
Travis Nielsen f4c22fc399 Merge pull request #14277 from rook/mergify/bp/release-1.14/pr-14271
docs: Add a note for NixOS and containerd (backport #14271)
2024-05-28 13:20:04 -06:00
Onur C. Cakmak 3a97692d08 docs: add a note for NixOS and containerd
Add a note to remove LimitNOFILE setting in containerd service configuration.

This setting causes multiple issues such as slow `ceph status` commands (and failing healthchecks),
various timeouts, and mons failing/timing out.

Upstream containerd already removed the setting. NixOS hasn't incorporated the change.

This note can be removed once https://github.com/NixOS/nixpkgs/pull/313507 makes it to a stable release.

Signed-off-by: Onur Cakmak <occ@occ.me>
(cherry picked from commit d1e139cdb3)
2024-05-28 19:15:52 +00:00
Brian Dowling 44c4eb378c osd: reduce safe-to-destroy retry timeout to 15s
This reduces the safe-to-remove retry interval from 1m to 15s.

Closes #14247

Signed-off-by: Brian Dowling <bjd-dev@simplicity.net>
(cherry picked from commit ef0ed93134)
2024-05-28 16:21:52 +00:00
subham rai 8cdfdc2f51 Merge pull request #14268 from rook/mergify/bp/release-1.14/pr-14266
ci: fix codespell ci by skipping some words (backport #14266)
2024-05-27 15:53:06 +05:30
subhamkrai df1ae9a223 ci: fix codespell ci by skipping some words
fixing 'secert' to `secret` and adding workds like
`NotIn, addin` to skip work list.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 85c25bbc6e)
2024-05-27 06:42:40 +00:00
Blaine Gardner e38c36f838 Merge pull request #14261 from rook/mergify/bp/release-1.14/pr-14248
mon: fix bind addr when IPv6 and msgr2 are enabled (backport #14248)
2024-05-23 11:16:38 -06:00
Blaine Gardner ccafc2b715 mon: fix bind addr when IPv6 and msgr2 are enabled
When IPv6-only network mode is enabled and when mons are configured to
listen only on msgrV2 port, Rook has to add the port to the mon
--public-bind-addr in order to force mons to stop listening on the
msgrV1 port. This can cause problems for IPv6 clusters where adding
':<port>' to the end of an IP addr looks like a valid IPv6 address.

In IPv6 mode, Rook needs to set this to '[<ip>]:<port>' with the
brackets to be a non-ambiguous IPv6 address.

In IPv4 mode, Rook needs to keep its existing behavior. IPv4 mode should
also continue to be the defualt assumption if the network config isn't
specified.

If 'dualStack: true' is specified, Rook is informed that the environment
is dual stack, but Rook doesn't know which IP family to expect from the
pod IP. In this scenario, it is safest for Rook not to apply the port,
since assuming either IPv4 or IPv6 format could be incorrect. In this
scenario, mons may still listen on msgrV1 ports, but this is preferable
to an environment where mons perpetually crash.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 573a47e736)
2024-05-23 13:32:05 +00:00
Travis Nielsen 397a3e60e3 Merge pull request #14252 from rook/mergify/bp/release-1.14/pr-14250
docs: fix broken link to network config (backport #14250)
2024-05-22 08:01:26 -06:00
NymanRobin 276c2cd087 docs: fix broken link to network config
Signed-off-by: NymanRobin <robin.nyman@est.tech>
(cherry picked from commit 30e6a7349b)
2024-05-22 13:56:11 +00:00
Travis Nielsen 4b97f988c4 Merge pull request #14242 from rook/mergify/bp/release-1.14/pr-14173
docs: document how to have StorageClass consume Rados Namespace (backport #14173)
2024-05-20 07:23:15 -06:00
Michael Adam 98732a50f8 docs: document how to have StorageClass consume Rados Namespace
closes: https://github.com/rook/rook/issues/13214

Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 8e7ac95f97)
2024-05-20 13:14:13 +00:00
sp98 c556842e19 core: remove owner refs in resource cleanup jobs
Removed owner reference from Radosnamespace and
subVolumeGroup cleanup resources.

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit c98fc86918)
2024-05-18 16:03:12 +00:00
mergify[bot] 32fb433235 Merge pull request #14237 from rook/mergify/bp/release-1.14/pr-14236
core: fix missing env in svg cleanup job (backport #14236)
2024-05-17 15:12:30 +00:00
sp98 4fd104974f core: fix missing env in svg cleanup job
SVG cleanup job uses the cephSubvolumeGroup env name
from spec.Name. But sometimes it can be empty. In that
case rook should use the CR name.

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit 33ce8f0c8e)
2024-05-17 14:44:29 +00:00
Travis Nielsen 7064a38701 Merge pull request #14228 from travisn/release-1.14.4
build: Update the release version to v1.14.4
v1.14.4
2024-05-16 15:20:05 -06:00
Travis Nielsen 3e83bd278e build: update the release version to v1.14.4
For the patch release update the docs and manifests
to v1.14.4

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-05-16 13:42:54 -06:00
Travis Nielsen ddc788398d Merge pull request #14205 from rook/mergify/bp/release-1.14/pr-14198
ci: bump github actions dependency setup-go (backport #14198)
2024-05-16 13:17:09 -06:00
Travis Nielsen 4b5c73ccd2 Merge pull request #14226 from rook/mergify/bp/release-1.14/pr-14190
doc: Update documentation for volume clone (backport #14190)
2024-05-16 13:16:38 -06:00
yati1998 5fb14b549e docs: update documentation for volume clone
after cross-storageclass clone/restore, now we can
clone across different storageclass.
this commit updates the documentation indicating
the same.

Signed-off-by: yati1998 <ypadia@redhat.com>
(cherry picked from commit 945da179e2)
2024-05-16 15:01:25 +00:00
Travis Nielsen 28c0a78527 Merge pull request #14225 from rook/mergify/bp/release-1.14/pr-14221
ci: remove extra comma from platforms (backport #14221)
2024-05-16 08:50:40 -06:00
subhamkrai 91cbf932c0 ci: remove extra comma from platforms
The last pr missed removing the extra comma after the platform
so, instead of ` linux/amd64,linux/arm64,` it should be
` linux/amd64,linux/arm64`.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit ea159ad9b7)
2024-05-16 14:34:52 +00:00
Travis Nielsen 5723faf382 Merge pull request #14224 from rook/mergify/bp/release-1.14/pr-14214
ci: push image ci failing in ubuntu 22.04 (backport #14214)
2024-05-16 08:32:31 -06:00
subhamkrai 8339c58dd2 ci: push image ci failing in ubuntu 22.04
since we moved to ubuntu 22.04, ci push image build is failing
due wrong parameter `--platforms linux/amd64 linux/arm64,` it should
be instead `--platforms linux/amd64, linux/arm64`.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit f89540c4ef)
2024-05-16 14:30:47 +00:00
mergify[bot] 632dbefcfb Merge pull request #14218 from rook/mergify/bp/release-1.14/pr-14210
core: remove pacific specific code (backport #14210)
2024-05-16 00:37:29 +00:00
Satoru Takeuchi d50517a316 core: remove pacific specific code
Since pacific is no longer supported, we can remove pacific specific
code.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
(cherry picked from commit f776c0b35e)
2024-05-15 23:45:02 +00:00
Travis Nielsen bc1d7f4520 Merge pull request #14207 from rook/mergify/bp/release-1.14/pr-14204
ci: fix pylint errors (backport #14204)
2024-05-14 14:27:30 -06:00
NymanRobin e7e3a9cc5c ci: fix pylint errors
Afte pylint was updated to version 3.2.0
a set of new errors appeared. This makes
ci passing by either fixing the problem
or ignoring it in the check

Signed-off-by: NymanRobin <robin.nyman@est.tech>
(cherry picked from commit dcec080468)
2024-05-14 20:24:30 +00:00
NymanRobin ef79f5cc24 ci: bump github actions dependency setup-go
The version v2 was deprecated and was causing warnings.

Signed-off-by: NymanRobin <robin.nyman@est.tech>
(cherry picked from commit 8af9917b9e)
2024-05-14 19:38:17 +00:00
mergify[bot] 4d075a6cad Merge pull request #14195 from rook/mergify/bp/release-1.14/pr-14187
osd: Add cephcluster status for deprecated osds to replace (backport #14187)
2024-05-13 14:59:19 +00:00
Travis Nielsen 5a34cd9f9e osd: add cephcluster status for legacy osds to replace
LVM-based OSDs on PVCs are legacy and are not well tested.
Therefore, we add status to the cephcluster CR that at least
gives a clue that the OSDs should be replaced.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 3628e83892)
2024-05-13 14:31:14 +00:00
Travis Nielsen 8a826c95e1 Merge pull request #14179 from rook/mergify/bp/release-1.14/pr-14178
ci: add missing markdownlint CI step (backport #14178)
2024-05-09 07:12:15 -06:00
Blaine Gardner d18dcc5528 ci: add missing markdownlint CI step
The CI step that runs markdown lint accidentally got removed as part of
PR updates. Add the CI step back in.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 115e0aa430)
2024-05-08 17:20:25 +00:00
Blaine Gardner 782a93d44b Merge pull request #14176 from rook/mergify/bp/release-1.14/pr-14175
ci: update go version for govulncheck (backport #14175)
2024-05-08 10:52:19 -06:00
Blaine Gardner e6c4b7e6c3 ci: update go version for govulncheck
Update the version of Go used for govulncheck to get the latest CVE fix
present in Go v1.22.3.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit f21f3f549c)
2024-05-08 16:25:21 +00:00