Commit Graph
10180 Commits
Author SHA1 Message Date
Travis Nielsen e2debde445 Merge pull request #12747 from rowanruseler/rr/charts-documentation-refs
helm: replaced broken documentation references
2023-08-18 08:12:52 -06:00
Rowan Ruseler 8f8f46dbd6 helm: replaced broken documentation references
Noticed that since the release of 1.9, the values.yaml file has some
old documentation references. Replaced them with the new locations.

Adjusted the link as requested by travisn
Placed extra line eof back as requested by path-gr

Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>
2023-08-18 10:21:37 +02:00
Travis Nielsen 430e8552a4 Merge pull request #12744 from Javlopez/feature/11574-move-how-to-run-tests-instructions-to-developer
docs: move how to run tests instructions to contributing
2023-08-17 12:51:49 -06:00
Travis Nielsen e84ba84af6 Merge pull request #12751 from travisn/crd-gen-update
build: Update crds gen for new descriptions
2023-08-17 12:45:04 -06:00
Travis Nielsen 0e3117bd6e Merge pull request #12507 from sp98/osd-migration
Replace OSD to use new backend store
2023-08-17 12:40:49 -06:00
travisn 438b61721f build: update crds gen for new descriptions
The CRDs were not generated for the latest since #12384
was merged without rebasing, and other updates with a newer
dependency required the newer descriptions.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-08-17 12:03:33 -06:00
Travis Nielsen afaadd78c4 Merge pull request #12384 from ideepika/feature/ksd-174
mon: add mon storage class support
2023-08-17 11:52:20 -06:00
Javier b16f062af0 docs: move how to run tests instructions to contributing
rename and move tests/README.md to
Documentation/Contributing/rook-test-framework.md in order to make it
part of the contributing section

Signed-off-by: Javier <sjavierlopez@gmail.com>
2023-08-17 10:13:39 -06:00
sp98 886bb357ef osd: replace osd to use new backend store
If osd store is updated in the ceph cluster, then
delete OSDs one by one, cleanup disks and provision a new OSD on
the same disk

Signed-off-by: sp98 <sapillai@redhat.com>
2023-08-17 21:40:55 +05:30
Travis Nielsen 4655300a0a Merge pull request #12743 from travisn/earlier-toolbox
tests: Start toolbox earlier in tests
2023-08-17 08:37:35 -06:00
travisn 0bd7d4ac84 tests: use same ceph version for toolbox in multicluster
The multicluster test was using a different ceph image for the
toolbox than from the original cluster. For efficiency of
pulling images in the test, the toolbox of the external cluster
will now use the same ceph image as the internal cluster.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-08-16 15:50:57 -06:00
travisn 90d06a862b tests: start toolbox earlier in tests
The toolbox sometimes times out when the tests are waiting
for it to start. Now we create the toolbox spec sooner in
the tests so we won't need to wait so long for it to start
or increase the wait timeout in the tests.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-08-16 15:30:12 -06:00
Travis Nielsen f3764cc7ad Merge pull request #12731 from cjyar/alert-for
monitoring: add "for" to CephOSDDownHigh alert
2023-08-16 14:11:54 -06:00
Travis Nielsen 29f984da3a Merge pull request #12691 from subhamkrai/operator-placement
operator: move most of discover pod setting to cm
2023-08-16 13:54:23 -06:00
Travis Nielsen 9efe0b7db0 Merge pull request #12672 from subhamkrai/fix-update-vault
build: update vault and other indirect imports
2023-08-16 11:11:06 -06:00
Travis Nielsen bffd2e0af5 Merge pull request #12679 from subhamkrai/fix-nodeLoss-logging
operator: log op. config cm setting when changed
2023-08-16 11:09:27 -06:00
Travis Nielsen 0c3c8d1fdf Merge pull request #12675 from parth-gr/openshift-helm
helm: install rook in openshift cluster
2023-08-16 11:06:15 -06:00
subhamkrai fb39580067 operator: move most of discover pod setting to cm
It's better to move most of discover daemon setting
from env to configmap rook-ceph-operator-config.
Although, we are moving to configmap, we keep reading settings
from env but the priority will be configmap settings.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-16 22:17:47 +05:30
Travis Nielsen 7bab21f9cb Merge pull request #12736 from subhamkrai/fix-raw-disk-ci
ci: create toolbox-operator early in ci
2023-08-16 10:42:10 -06:00
subhamkrai a25071ac29 ci: fix golangCI lint remove k8s.io/utils/pointer
golangci linter was throughing error `k8s.io/utils/pointer`
package is deprecated. So, I have removed that.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-16 21:48:42 +05:30
subhamkrai bffa766b4f ci: create toolbox-operator early in ci
moving the toolbox-operator creation early in
ci, so that by the time we wait for others pods
to come up, toolbox-operator will be ready or
will wait for 180s.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-16 20:44:46 +05:30
parth-gr 62e3ffb2ba helm: install rook in openshift cluster
The sccs were missing in the helm installation,
added it

Closes: https://github.com/rook/rook/issues/12280

Signed-off-by: parth-gr <paarora@redhat.com>
2023-08-16 14:43:36 +05:30
subhamkrai 733be02577 operator: log op. config cm setting when changed
earlier, we're always logging when `GetValue` method is
called to get operator config  values which somettime
spamming the logs for example `ROOK_WATCH_FOR_NODE_FAILURE`
keep logging every time 5 min.

Now, we'll store the settings in the map and log only when
map key value is changed.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-16 13:56:38 +05:30
Chris Jones 9f1e5ec4ee monitoring: add "for" to CephOSDDownHigh alert
As part of a normal restart, an OSD can go down just as prometheus tries
to scrape it, causing this alert to fire. Alerts shouldn't fire as part
of normal operations. This change requires the OSD to be down for 5
consecutive minutes before the alert will fire.

Signed-off-by: Chris Jones <chris@cjones.org>
2023-08-15 19:37:46 -06:00
Travis Nielsen 561511e8d4 Merge pull request #12726 from obnoxxx/contrib-wording
docs: minor rewording in  Contributing guide.
2023-08-15 11:20:26 -06:00
Travis Nielsen be4e60bfe1 Merge pull request #12725 from Madhu-1/update-12673
file: ignore exit code 22 when addding datapool
2023-08-15 11:16:14 -06:00
Michael Adam 3022c0f8f2 docs: minor rewording in Contributing guide
This is just an innocuous little rewording of one part of the
contributing guide that occurred to me while reading the doc.

Signed-off-by: Michael Adam <obnox@samba.org>
2023-08-15 18:57:40 +02:00
Madhu Rajanna bd9b42d221 file: ignore exit code 22 when adding datapool
Ignore the exit code 22 when adding the
datapool to a filesystem.

updates: #12673

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-08-15 16:01:48 +02:00
Blaine Gardner d4b806d20c Merge pull request #12698 from nixpanic/nfs/dbus-uid
nfs: run dbus-daemon sidecar as dbus user instead of root
2023-08-11 13:42:21 -06:00
Blaine Gardner 853bab398a Merge pull request #12495 from Nikhil-Ladha/issue12172/multus-validation-job
multus: Add sample job manifest for multus config validation
2023-08-11 13:28:07 -06:00
Nikhil-Ladha 9fea9cd865 multus: add sample job manifest for multus config validation
added a sample job manifest named `multus-validation` that
validates the multus configuration in the cluster.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
2023-08-11 10:55:29 +05:30
Niels de Vos 320b112cc6 nfs: run dbus-daemon sidecar as dbus user instead of root
When the dbus-daemon in the sidecar is started as "root" user, it fails
with the following log entry:

Failed to start message bus: Failed to drop capabilities: Operation not permitted

By starting the sidecar as "dbus" user (uid=81), the executable does not
try to drop capabilities, and starts successfully.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
2023-08-10 18:17:19 +02:00
Travis Nielsen 71f078c0fc Merge pull request #12694 from parth-gr/ci-objectsuite-time
ci: update the objectsuite test timeout to 40m
2023-08-09 11:45:05 -06:00
parth-gr 8617e2e924 ci: update the objectsuite test timeout to 40m
While running object test we need some more time
to run the cosi test completely so increasing the timeout

Also update timeout of ntegration-tests-on-release.yaml

Signed-off-by: parth-gr <paarora@redhat.com>
2023-08-09 22:47:06 +05:30
Deepika Upadhyay 427c53786b docs: amend for clarity on failureDomainLabel and VolumeClaimTemplate
Signed-off-by: Deepika Upadhyay <deepika@koor.tech>
2023-08-09 21:21:40 +05:30
Travis Nielsen e90cedce85 Merge pull request #12600 from parth-gr/ci-objectsuite
ci: fix testobjectsuite ci
2023-08-09 09:05:06 -06:00
Travis Nielsen 4bcda1a47e Merge pull request #12381 from sp98/osd-migration-design
doc: osd migration design
2023-08-09 08:35:28 -06:00
Travis Nielsen 3d2bbd9785 Merge pull request #12677 from parth-gr/canary-ci-improvement
ci: improve the canary toolbox operator pod check
2023-08-09 08:19:40 -06:00
sp98 3f79fe8548 docs: osd migration design
A design doc to migrate osd incase of change in the OSD backend

Signed-off-by: sp98 <sapillai@redhat.com>
2023-08-09 07:35:38 +05:30
parth-gr 715bd31a0a ci: fix testobjectsuite ci
Current reason for failure
clients: "cephbuckettopic" "my-topic" exist, but ARN was not set

Added some more re-try as it might take some more time to
update the ARN in status

OBC bound status was failing and going into
race condition adding a seprate timeout
makes recover it from that state

Signed-off-by: parth-gr <paarora@redhat.com>
2023-08-08 23:46:02 +05:30
Travis Nielsen 9c83260eec Merge pull request #12678 from karthik-us/maxUnavailable
csi: add maxUnavailable for cephfs csi daemonset
2023-08-08 11:12:01 -06:00
Travis Nielsen 3f01e8f7ec Merge pull request #12681 from Madhu-1/fix-12645
csi: add mode csi pods to the list to force delete pod
2023-08-08 11:10:43 -06:00
parth-gr 64d3df4fcd ci: improve the canary toolbox operator pod check
the wait command is provided by kubernetes so
instead of using manually shell hack using the wait
command

Signed-off-by: parth-gr <paarora@redhat.com>
2023-08-08 22:06:21 +05:30
Madhu Rajanna 29faca9032 csi: add nfs pods to the list to delete pod
Add nfs pods label to the list so that Rook
can get all the pods on the failed node and
force delete the pods stuck in terminating state.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-08-08 09:24:24 +02:00
Madhu Rajanna 22bfc9de3d csi: add holder pods to the list to delete pod
Add holder pods label to the list so that Rook
can get all the pods on the failed node and
force delete the pods stuck in terminating state.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-08-08 09:24:19 +02:00
subhamkrai ab3763767f build: update vault and other indirect imports
update vault and other indirect imports. Also,
updating k8s package to `v0.28.0-rc.0` since with
v0.27.4 it was through build error.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-08 08:24:19 +05:30
karthik-us 2675c976d5 csi: add maxUnavailable for cephfs csi daemonset
Adding maxUnavailable parameter to the cephfs csi daemonset. The
default value of maxUnavailable = 1 can make the upgrade process
slower in environments with large number of nodes.

Fixes: #12636
Signed-off-by: karthik-us <ksubrahm@redhat.com>
2023-08-07 19:48:21 +05:30
Travis Nielsen 7aaf46e112 Merge pull request #12666 from polyedre/fix-logger-formatting-methods
operator: fix formatting of some logger methods
2023-08-04 08:56:09 -06:00
Travis Nielsen 8e1090b3be Merge pull request #12624 from parth-gr/s5-cmd
object: fix s5cmd for s3 endpoint verification
2023-08-04 08:19:28 -06:00
Lucas Henry c948183c0e operator: fix formatting of some logger methods
Some logging instructions use formatting syntax `%q`, but the logging method is
`Info` or `Debug` instead of `Debugf` and `Infof`. As a result, the arguments of
the method were concatenated instead of formatted properly.

Signed-off-by: Lucas Henry <polyedre@disroot.org>
2023-08-04 15:45:54 +02:00