Commit Graph
10313 Commits
Author SHA1 Message Date
Travis Nielsen ea23fddd00 Merge pull request #13051 from rook/mergify/bp/release-1.12/pr-13045
doc: fix document about viewing dashboard outside of cluster (backport #13045)
2023-10-17 13:39:25 -06:00
Bin Wang 86a0e65352 doc: fix document about viewing dashboard outside of cluster
https://github.com/rook/rook/pull/11845 added dynamic label `mgr_role`.
The example yaml files are updated but this doc is missed.

I think it would be better to refer to `deploy/examples` but I find all
other places are not doing that. So keep it inlined to be consistent.

Signed-off-by: Bin Wang <bin.wang@mail.binwang.me>
(cherry picked from commit 25d89d2b68)
2023-10-16 17:11:50 +00:00
mergify[bot] e48f4f088f Merge pull request #13044 from rook/mergify/bp/release-1.12/pr-12165
osd: prevent to fallback to lvm mode in osd on lvm creation (backport #12165)
2023-10-12 20:12:11 +00:00
Satoru Takeuchi 343b25824e osd: prevent to fallback to lvm mode in osd on lvm creation
Rook creates raw mode OSD as possible and falls back to lvm mode if necessary.
This logic doesn't work if only supports raw mode.

Closes: https://github.com/rook/rook/issues/11438

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
(cherry picked from commit 6fee3c9ff4)
2023-10-12 17:09:51 +00:00
Travis Nielsen af4af13af4 Merge pull request #13035 from BlaineEXE/bp-13032-release-112
build: update go module deps
2023-10-12 09:35:05 -06:00
Travis Nielsen a4f5f96eb6 Merge pull request #13043 from rook/mergify/bp/release-1.12/pr-13039
csi: fix indentation for mountinfo (backport #13039)
2023-10-12 08:54:52 -06:00
Travis Nielsen 7016c6f17b Merge pull request #13042 from rook/mergify/bp/release-1.12/pr-13031
osd: use bash script if restart interval is > 0 (backport #13031)
2023-10-12 08:54:37 -06:00
Madhu Rajanna 4fde0ad9af csi: fix indentation for mountinfo
Fixed the indentation for the mountinfo
or else an emptyDir is getting created
for it.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 9f2b7d572d)
2023-10-12 13:20:06 +00:00
sp98 2a9f6bfcc6 osd: use bash script if restart interval is > 0
If `FlappingRestartIntervalHours` for OSD is > 0 in the cephCluster CR,
then start OSD inside a bash script.

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit ffd69291f1)
2023-10-12 13:13:04 +00:00
Travis Nielsen bec049273d Merge pull request #13038 from sp98/revert-13005
osd: revert: make osd pod to sleep when osds are flapping"
2023-10-12 07:11:09 -06:00
sp98 e1811a89a7 osd: revert: make osd pod to sleep when osds are flapping"
This reverts commit 0e53c9ec61.

Signed-off-by: sp98 <sapillai@redhat.com>
2023-10-12 12:28:40 +05:30
Blaine Gardner 14bdd5a094 build: update go module deps
Update go module deps. The most interesting dep update is to
libopenstorage/secrets which no longer uses Vault code licensed under
BUSL-1.1.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-10-11 15:47:58 -06:00
Travis Nielsen b4cc3e26de Merge pull request #13034 from rook/mergify/bp/release-1.12/pr-13033
mon: Write the assimilate-conf config to a valid operator working directory (backport #13033)
2023-10-11 11:52:17 -06:00
travisn be34f6acff mon: write assimilate config to operator dir
The /tmp dir is not always available in some environments.
The only directories the operator should rely on
are the directories that are in its pod spec.
For assimilate-conf now we use the /var/lib/rook
directory to generate files since we know it is
a valid emptydir mounted into the operator pod.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 5359c4f4f5)
2023-10-11 16:10:28 +00:00
Travis Nielsen e6fbb1fed5 Merge pull request #13030 from rook/mergify/bp/release-1.12/pr-12860
mds: improve the mds liveness probe calls (backport #12860)
2023-10-10 11:00:35 -06:00
parth-gr c929eeda91 ci: check mds liveness probe unit test from the CI run
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 3d4036547c)
2023-10-10 14:22:22 +00:00
parth-gr fa51e4086d mds: improve the mds liveness probe calls
Instead of checking the socket files for mds daemon,
check the mds daemon in fs maps

Closes: https://github.com/rook/rook/issues/12789

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 2dd9b00ca3)
2023-10-10 14:22:22 +00:00
Travis Nielsen ccee172a88 Merge pull request #13023 from rook/mergify/bp/release-1.12/pr-13011
csi: add mountinfo path for cephfs daemonset (backport #13011)
2023-10-10 08:21:55 -06:00
Madhu Rajanna 2a12cc1b91 csi: add mountinfo path for cephfs daemonset
If mountinfo path is available cephcsi will
try to recover the fuse client. adding the
support for the same in Rook.

fixes: #13009

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 54ce2a96da)
2023-10-09 16:47:57 +00:00
Travis Nielsen c3699da55f Merge pull request #13014 from travisn/release-1.12.5
build: Update the release version to v1.12.5
v1.12.5
2023-10-06 14:58:27 -06:00
travisn 42f6984339 build: update the release version to v1.12.5
For the patch release update the examples and docs
to v1.12.5.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-10-06 12:37:15 -06:00
Travis Nielsen 559b1decab Merge pull request #13013 from rook/mergify/bp/release-1.12/pr-13008
docs: fixing typos (backport #13008)
2023-10-06 12:35:14 -06:00
Redouane Kachach 09f6d66b08 docs: fixing typos
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit e32ece275c)
2023-10-06 18:29:22 +00:00
Travis Nielsen eadef7291d Merge pull request #13006 from rook/mergify/bp/release-1.12/pr-12998
exporter: Change verbose info to debug logs (backport #12998)
2023-10-06 12:29:06 -06:00
travisn 46270d404d exporter: change verbose info to debug logs
Several messages were showing up in the operator log
more often than necessary, so let's change them to
debug level.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 29fb879675)
2023-10-05 17:29:41 +00:00
Travis Nielsen 67b512430c Merge pull request #13004 from rook/mergify/bp/release-1.12/pr-13001
external: fix client.healthchecker user keyring return (backport #13001)
2023-10-05 11:11:30 -06:00
Travis Nielsen e040b293c4 Merge pull request #13005 from sp98/revert-12715
osd: Revert: make osd pod to sleep when osds are flapping
2023-10-05 11:09:54 -06:00
Travis Nielsen 98a14164d7 Merge pull request #13003 from rook/mergify/bp/release-1.12/pr-12984
docs: improving minikube setup documentation (backport #12984)
2023-10-05 11:08:45 -06:00
sp98 0e53c9ec61 osd: revert: make osd pod to sleep when osds are flapping
This reverts commit 4eb9f62205.

Signed-off-by: sp98 <sapillai@redhat.com>
2023-10-05 21:26:35 +05:30
parth-gr f3e2548a0e ci: add a test to check the script result in idempotent output
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 98125c78b9)
2023-10-05 15:30:16 +00:00
parth-gr 4f4bcd327d external: fix client healhchecker user keyring return
if the client.health checker already exited it was
returning extra information, It was making the structure and
return JSON non idempotent output, So fixed
that problem by returning a single value

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit bf5252e139)
2023-10-05 15:30:15 +00:00
Blaine Gardner 1fee25c0f9 Merge pull request #13000 from rook/mergify/bp/release-1.12/pr-12968
multus: allow node profiles in validation test (backport #12968)
2023-10-05 09:15:42 -06:00
Blaine Gardner 66905e0d16 Merge pull request #12999 from rook/mergify/bp/release-1.12/pr-12997
ci: make use of caching in actions/setup-go (backport #12997)
2023-10-05 09:15:14 -06:00
Redouane Kachach 231b6d0d97 docs: improving minikube setup documentation
Adding some detailed instructions on how to use the local
built Rook image on minikube cluster

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 5f4fae4f3b)
2023-10-05 13:20:55 +00:00
Blaine Gardner 52f5119cef multus: allow node profiles in validation test
Add the ability to specify node profiles in the multus validation test.

This addresses a few points of early feedback on the validation tool.
Statements below critique the tool's behavior before this patch.
1. The tool assumes all daemons are on public and cluster network, which
   means users who have a significantly smaller cluster net (a
   design choice) cannot run a single test to determine if Rook is
   likely to install correctly.
2. The tool does not have placement options to select only a subset of
   Kubernetes nodes to run validation on.
3. Users of multus seem to have a dedicated pool of storage nodes more
   often than the average Rook install. This makes sense for security-
   and perforance-minded users. The tool cannot run a single test to
   verify storage-only and general-workload nodes at one time.

These points are addressed by allowing users to specify configurations
for different "NodeTypes."

Each NodeType config has options for selecting the number of OSDs as
well as the number of other (non-OSD) Ceph daemons. This limits the
unnecessary exhaustion of cluster network addresses from critique 1.

Each NodeType config has its own placement (critique 2).

Users can define as many NodeTypes as needed to test the network for
their planned CephCluster. Specifically, this allows the tool to test
storage-only nodes and generalized-workload nodes at the same time. An
arbitrary number of NodeTypes are allowed to support even more highly
specialized cluster setups, such as multiple tiers of storage nodes
where some storage-only nodes may run more OSDs than others.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 0c721e05d5)
2023-10-04 15:46:21 -06:00
Blaine Gardner 47ffb20702 ci: make use of caching in actions/setup-go
The GH action to set up Golang (actions/setup-go) has cache
functionality. For cache hits, this saves ~2 minutes for each run. In
order for the cache to hit, caching must not be disabled, and the code
must be checked out before setting up Golang.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit bf9e5dc1f5)

# Conflicts:
#	.github/workflows/golangci-lint.yaml
2023-10-04 15:29:23 -06:00
Travis Nielsen 320795292d Merge pull request #12995 from rook/mergify/bp/release-1.12/pr-12633
object: create cosi user for each object store (backport #12633)
2023-10-04 13:48:57 -06:00
Travis Nielsen 976875cb96 Merge pull request #12939 from rook/mergify/bp/release-1.12/pr-12909
core: import packages only once (backport #12909)
2023-10-04 10:50:50 -06:00
Travis Nielsen 6bd401c80f Merge pull request #12975 from rook/mergify/bp/release-1.12/pr-12971
ci: remove workaround for clean disk action (backport #12971)
2023-10-04 10:50:11 -06:00
Travis Nielsen 40f0654454 Merge pull request #12980 from rook/mergify/bp/release-1.12/pr-12970
core: use crash profile in crash daemon keyring (backport #12970)
2023-10-04 10:49:22 -06:00
Travis Nielsen 9af8c8a3b0 Merge pull request #12994 from rook/mergify/bp/release-1.12/pr-12986
ci: fixing linter error (using variable 'urllib' before assignment) (backport #12986)
2023-10-04 10:49:03 -06:00
Travis Nielsen 968366f6b2 Merge pull request #12990 from rook/mergify/bp/release-1.12/pr-12988
docs: fixing some spelling issues (backport #12988)
2023-10-04 10:48:35 -06:00
Jiffin Tony Thottan c92bf401ab object: create cosi user for each object store
Create each cosi user for each object store and secret which holds
credentials.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit a941b3c33f)
2023-10-04 16:10:52 +00:00
Redouane Kachach 12f6b68377 ci: fixing linter error
Fixing linter error (using variable 'urllib' before assignment)
Adding logic to properly import urlencode depending on python version

closes: https://github.com/rook/rook/issues/12985

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit aa59e3bb86)
2023-10-04 15:36:54 +00:00
Redouane Kachach 5f8c552b91 docs: fixing some spelling issues
closes: https://github.com/rook/rook/issues/12987

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit b3dd74ea20)
2023-10-03 14:06:59 +00:00
mergify[bot] 97a2fedb32 Merge pull request #12982 from rook/mergify/bp/release-1.12/pr-12981
file: Disable active standby when set to false (backport #12981)
2023-10-02 17:01:13 +00:00
travisn 619bdc3722 file: disable active standby when set to false
The activeStandby property of the filesystem CR was not
taking effect when changed from true to false. The standby
was only being enabled when true, but never applied when
changed to false.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit f7094d1d13)
2023-10-02 16:12:03 +00:00
travisn 17dbbafadc core: use crash profile in crash daemon keyring
The ceph documentation indicates to use the crash profile
instead of specifying rw for the mgr access.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit fab23d3407)
2023-10-02 13:27:34 +00:00
subhamkrai 7b0a46c07d ci: remove workaround for clean disk action
The issues are fixed from the clean disk action
repo and we shouldn't require any workaround. Also,
I'm not using git revert to revert the commit is earlier
clean disk action was mentioned in every CI which was
duplicate and now we have placed the action to composite yaml

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit e14f8c7710)
2023-09-29 15:58:14 +00:00
Travis Nielsen b6a8c5da7d Merge pull request #12966 from rook/mergify/bp/release-1.12/pr-12959
ci: fix github action free disk space  (backport #12959)
2023-09-28 09:43:56 -06:00