feedc0de/my-rook-config
1
0
Fork 0
forked from rook/rook
Code Pull Requests Activity
13,588 Commits 38 Branches 289 Tags
eaddeb514b8cb7c8201eca42eb2d597393959e90
Commit Graph
13588 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Travis Nielsen eaddeb514b Merge pull request #17442 from travisn/tentacle-default-docs 
core: Update all docs and examples default to v20.2.1
 2026-04-28 16:24:32 -06:00
Travis Nielsen 62a9debceb core: update all docs and examples to v20.2.1 
With the default version now being v20.2.1, also update
all of the examples, documentation, and default CI to run
with that version

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2026-04-28 14:09:17 -06:00
Santosh Pillai 05f1b00b81 Merge pull request #17395 from sp98/rgw-account-quota 
doc: rgw account quotas
 2026-04-28 22:02:44 +05:30
Joshua Hoblitt 03789475f9 Merge pull request #17414 from OdedViner/policy_aws_sdk_v2 
object: migrate bucket policy methods to aws sdk v2
 2026-04-28 07:45:36 -04:00
Travis Nielsen dfed786816 Merge pull request #17440 from obnoxxx/build-fix-helm-lint-self-contained 
build: make make helm.lint truly self-contained
 2026-04-27 11:45:51 -06:00
subham rai 17f326f3be Merge pull request #17434 from rook/dependabot/go_modules/github-dependencies-456e44f28d 
build(deps): bump the github-dependencies group with 2 updates
 2026-04-27 23:01:35 +05:30
Michael Adam 953fae17c9 build: make make helm.lint truly self-contained 
PR #17306 intended to make the helm.lint target self-contained
so that it would not require tools to be installed in the system.
But it missed the fact that ct requires helm to be available
in the path. So make helm.lint would still fail when helm was not
installed.

This change fixes this by creating a symlink to the cached versioned
helm tool and rewriting PATH for the ct invocation.

This renders the helm.lint target truly self-contained.

Signed-off-by: Michael Adam <obnox@samba.org>
 2026-04-27 18:42:40 +02:00
Travis Nielsen d256138023 Merge pull request #17432 from OdedViner/nvmeof_scc_upstream 
security: grant scc to rook-ceph-nvmeof service account
 2026-04-27 09:49:47 -06:00
Santosh Pillai 8cf245059c Merge pull request #17342 from OdedViner/aws_v2_upgrade_obj 
object: migrate s3agent object methods to aws sdk v2
 2026-04-27 21:18:32 +05:30
dependabot[bot] 7af79920dd build(deps): bump the github-dependencies group with 2 updates 
Bumps the github-dependencies group with 2 updates: [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/smithy-go](https://github.com/aws/smithy-go).


Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.99.1 to 1.100.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/service/s3/v1.99.1...service/s3/v1.100.0)

Updates `github.com/aws/smithy-go` from 1.25.0 to 1.25.1
- [Release notes](https://github.com/aws/smithy-go/releases)
- [Changelog](https://github.com/aws/smithy-go/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws/smithy-go/compare/v1.25.0...v1.25.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3
  dependency-version: 1.100.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/aws/smithy-go
  dependency-version: 1.25.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-04-27 15:25:33 +00:00
Oded Viner 7f3e2ace27 security: grant scc to rook-ceph-nvmeof service account 
the rook-ceph-nvmeof service account is not listed in the
securitycontextconstraints users, causing cephnvmeofgateway
pods to fail on openshift. add the service account to the
scc in the helm charts, go scc builder, and test namespace
substitution.

Signed-off-by: Oded Viner <oviner@redhat.com>
 2026-04-27 16:28:15 +03:00
Travis Nielsen e6560ad18c Merge pull request #17282 from officialasishkumar/pool-crush-rule-cleanup 
pool: clean up unused crush rules
 2026-04-24 16:31:59 -06:00
Travis Nielsen afc7f5913d Merge pull request #17312 from obnoxxx/build-yamllint-self-contained 
build: make the yamllint target  self-contained
 2026-04-24 13:28:16 -06:00
Michael Adam 12cf909acd docs: clean linting part of contributing guide of yamllint 
The development flow guide mentioned several tools that needed to be
installed in the PATH to run make lint.

This change removes yamllint from that list now that makeyamllint has
been made self-contained.

With pylint the only remaining requirement, this also rewords the
corresponding section for clarity.

Signed-off-by: Michael Adam <obnox@samba.org>
 2026-04-24 21:04:49 +02:00
Michael AdamandBlaine Gardner f5d7004d22 build: make the yamllint target self-contained 
The yamllint make target required yamllint to be installed
in the PATH.

This change renders it self-contained
by using a container image instead.

Signed-off-by: Michael Adam <obnox@samba.org>
Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
 2026-04-24 21:04:49 +02:00
Asish Kumar 24a35e4e74 pool: clean up unused crush rules 
Clean up stale CRUSH rules after the Ceph mgr starts so rules left behind by pool failure-domain or device-class changes do not accumulate indefinitely.

The cleanup is guarded by a package-level RWMutex. Pool create and update paths hold the read lock while creating and assigning CRUSH rules, while cluster-wide cleanup holds the write lock before listing pools and deleting unused rules. This keeps pool reconciles parallel with each other while preventing cleanup from deleting a rule that another reconcile has just created but not yet attached to a pool.

Keep direct pool-delete cleanup for the pool's current CRUSH rule, make the cluster-wide cleanup best-effort across all unused rules, and add an operator-level ROOK_DELETE_UNUSED_CRUSH_RULES setting for clusters that need to leave unused custom rules in place.

Document the operator and Helm settings, regenerate the Helm chart docs, and add a pending release note for the default cleanup behavior.

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
 2026-04-24 23:57:40 +05:30
Travis Nielsen b23981a035 Merge pull request #17365 from BlaineEXE/ai-contrib-guidelines 
doc: add AI guidelines
 2026-04-24 11:52:54 -06:00
Blaine Gardner ebf4656481 doc: add AI guidelines 
Add AI guidelines based on discussions from the most recent community
meeting.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
 2026-04-24 11:49:22 -06:00
Travis Nielsen d06edb76d0 Merge pull request #17426 from obnoxxx/build-fix-checkmake-generate-docs-crds-phony 
build: declare generate-docs-crds PHONY to fix local checkmake
 2026-04-24 11:49:21 -06:00
Michael Adam c6ab030cd4 build: declare generate-docs-crds PHONY to fix local checkmake 
Locally, checkmake complained that the target generate-docs-crds
should be declared PHONY.

And it should in fact be PHONY as it is a target without recipe
depending on another PHONY target.

This change fixes the local xheckmake run by declaring
generate-docs-crds PHONY as desired.

Signed-off-by: Michael Adam <obnox@samba.org>
 2026-04-24 18:30:20 +02:00
Travis Nielsen 4ffe8ac9ec Merge pull request #17422 from obnoxxx/docs-clean-linting-contrib-guide 
docs: clean linting part of the contributing guide
 2026-04-24 09:07:19 -06:00
Travis Nielsen 0e6e89dc27 Merge pull request #17381 from gaganhr94/fix/token-permissions 
fix: adding required permissions to top level and jobs in the workflow
 2026-04-24 08:02:09 -06:00
Santosh Pillai 8d34eea8a9 Merge pull request #17420 from sp98/remove-new-line 
core:remove newlines from liveness probe scripts
 2026-04-24 19:14:08 +05:30
Michael Adam b0a9a1f149 docs: clean linting part of the contributing guide 
The section about nake lint in the contributing guide
mentions several tools that need to be installed locally to run
the linters.

with PR #17311 which has made the shellcheck target self-contained,
the requirement is now gone for shellcheck.

This change simlifies the guide by removing the mention of shellcheck
as required to be installed.

Signed-off-by: Michael Adam <obnox@samba.org>
 2026-04-24 14:55:54 +02:00
Santosh 925acb3e92 core: remove newlines from liveness probe scripts 
Strip unnecessary leading and trailing newlines from osdLivenessProbeScript and livenessProbeScript raw string literals in spec.go

Signed-off-by: Santosh <sapillai@redhat.com>
 2026-04-24 14:24:51 +05:30
Santosh Pillai b87c434ff9 Merge pull request #17411 from taraasrita10/fix-osdkms-log-error 
osd: fix KMS log error format specifier
 2026-04-24 14:09:17 +05:30
Travis Nielsen 0fc8852cc1 Merge pull request #17417 from BlaineEXE/upgrade-guides-for-1.20 
docs: update upgrade docs for v1.20
 2026-04-23 15:53:22 -06:00
Blaine Gardner cb60ec5ae2 docs: update upgrade docs for v1.20 
Update upgrade docs to reflect v1.20 changes.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
 2026-04-23 14:35:32 -06:00
Travis Nielsen 0160ba5bd0 Merge pull request #17288 from lumir-sliva/relax-stretch-crush-weight-check 
mon: relax balanced CRUSH weight check for stretch mode
 2026-04-23 12:05:12 -06:00
Oded Viner 88e0047d9b object: migrate bucket policy methods to aws sdk v2 
migrate PutBucketPolicy and GetBucketPolicy to use aws sdk v2
client.

Signed-off-by: Oded Viner <oviner@redhat.com>
 2026-04-23 18:54:48 +03:00
Travis Nielsen 40f24638bc Merge pull request #17311 from obnoxxx/build-shellcheck-self-contained 
build:  make the shellcheck target  self-contained
 2026-04-23 08:45:36 -06:00
Oded Viner 2cb714dabd object: migrate s3agent object methods to aws sdk v2 
migrate PutObjectInBucket, GetObjectInBucket, and
DeleteObjectInBucket to use aws sdk v2 client.
replace v1 awserr error handling in DeleteObjectInBucket
with v2 typed errors (errors.As).
remove unused v1 awserr import.

Signed-off-by: Oded Viner <oviner@redhat.com>
 2026-04-23 17:40:15 +03:00
Prabhala Tara Aasrita 85ee8631cf osd: fix KMS log error format specifier 
During OSD provisioning, the KMS error log incorrectly uses logger.Error() instead of logger.Errorf(), causing the format specifier %q to appear in the logs. Changed logger.Error to logger.Errorf to fix the same.

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
 2026-04-23 16:19:33 +05:30
Michael AdamandCopilot ffc87c674e build: make the shellcheck target self-contained 
running make shellcheck required shellcheck to be
installed locally in the $PATH.

This change renders make shellcheck self-contained
by installing shellcheck in the local tools cache directory
likeit is already done  with other tools.

Signed-off-by: Michael Adam <obnox@samba.org>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2026-04-23 11:15:08 +02:00
Santosh 83c8ddb3c8 doc: rgw account quotas 
design doc for management of rgw account level quotas.

Signed-off-by: Santosh <sapillai@redhat.com>
 2026-04-23 10:16:27 +05:30
Lumir Sliva 27f95f2feb mon: relax balanced CRUSH weight check for stretch mode 
Ceph relaxed the stretch mode CRUSH weight check in ceph/ceph#66580 to
allow weights within 10 percent of each other. This change is available
in Ceph Umbrella and was backported to tentacle v20.2.2 via ceph/ceph
number 67790. The squid backport is still pending.

Signed-off-by: Lumir Sliva <61183145+lumir-sliva@users.noreply.github.com>
 2026-04-22 19:14:48 +02:00
Parth Arora c250b47c4f Merge pull request #17382 from taraasrita10/setenv_rook_unreachablenode 
mon: fix floating mon validation in TNF deployments
 2026-04-22 21:06:39 +05:30
subham rai 6b33abfbfb Merge pull request #17403 from taraasrita10/update-k8s-version 
ci: remove K8s 1.30 and use latest patch versions
 2026-04-22 16:09:56 +05:30
Prabhala Tara Aasrita b7ea6f488f ci: remove K8s 1.30 and use latest patch versions 
Remove Kubernetes 1.30 from k8s workflows and update supported
versions to their latest patches (1.31.14, 1.32.13, 1.33.11, 1.35.4)

Closes #17399

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
 2026-04-22 14:01:06 +05:30
Prabhala Tara Aasrita 8e205b194c mon: fix floating mon validation in TNF deployments 
The floating mon in a TNF cluster is designed to share a node with a pinned mon. Fixed the pre-cluster start evaluation logic to allow the same when allowMultiplePerNode is set to false.

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
 2026-04-21 18:45:17 +05:30
Santosh Pillai 59ce48ae88 Merge pull request #17228 from ormandj/fix/osd-device-class-reprovision 
osd: fix CRUSH device class not applied during OSD re-discovery
 2026-04-21 17:50:39 +05:30
Travis Nielsen 1320861c3d Merge pull request #17373 from degorenko/fix-mds-standby-wanted 
mds: fix incorrect behaviour for CephFS when no active standby
 2026-04-20 14:15:41 -06:00
Travis Nielsen e80e050c23 Merge pull request #17376 from elias-dbx/fix_pg_health_regex_docs 
doc: fix out of date references to default PgHealthyRegex
 2026-04-20 11:51:53 -06:00
subham rai d39e888a64 Merge pull request #17386 from rook/dependabot/go_modules/k8s-dependencies-6ce661aae3 
build(deps): bump the k8s-dependencies group with 6 updates
 2026-04-20 22:33:28 +05:30
Elias Carter 5a065948e2 doc: fix out of date references to default PgHealthyRegex 
Signed-off-by: Elias Carter <elias@dropbox.com>
 2026-04-20 09:39:25 -07:00
dependabot[bot] 7c68517cc7 build(deps): bump the k8s-dependencies group with 6 updates 
Bumps the k8s-dependencies group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.35.3` | `0.35.4` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.35.3` | `0.35.4` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.35.3` | `0.35.4` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.35.3` | `0.35.4` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.35.3` | `0.35.4` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.35.3` | `0.35.4` |

Updates `k8s.io/api` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/api/compare/v0.35.3...v0.35.4)

Updates `k8s.io/apiextensions-apiserver` from 0.35.3 to 0.35.4
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.35.3...v0.35.4)

Updates `k8s.io/apimachinery` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.35.3...v0.35.4)

Updates `k8s.io/cli-runtime` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.35.3...v0.35.4)

Updates `k8s.io/client-go` from 0.35.3 to 0.35.4
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.35.3...v0.35.4)

Updates `k8s.io/cloud-provider` from 0.35.3 to 0.35.4
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.35.3...v0.35.4)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-version: 0.35.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-version: 0.35.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.35.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-version: 0.35.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-version: 0.35.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-version: 0.35.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: subhamkrai <srai@redhat.com>
 2026-04-20 21:01:58 +05:30
subham rai e624507c88 Merge pull request #17387 from rook/dependabot/go_modules/github-dependencies-810a2b04c8 
build(deps): bump the github-dependencies group with 7 updates
 2026-04-20 20:56:50 +05:30
subham rai bc49de5402 Merge pull request #17385 from rook/dependabot/github_actions/github/codeql-action-4.35.2 
build(deps): bump github/codeql-action from 4.35.1 to 4.35.2
 2026-04-20 20:56:25 +05:30
dependabot[bot] e5a64d11c2 build(deps): bump the github-dependencies group with 7 updates 
Bumps the github-dependencies group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.41.5` | `1.41.6` |
| [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.32.14` | `1.32.16` |
| [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) | `1.19.14` | `1.19.15` |
| [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) | `1.99.0` | `1.99.1` |
| [github.com/aws/aws-sdk-go-v2/service/sns](https://github.com/aws/aws-sdk-go-v2) | `1.39.15` | `1.39.16` |
| [github.com/aws/smithy-go](https://github.com/aws/smithy-go) | `1.24.3` | `1.25.0` |
| [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph) | `0.38.0` | `0.39.0` |


Updates `github.com/aws/aws-sdk-go-v2` from 1.41.5 to 1.41.6
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.41.5...v1.41.6)

Updates `github.com/aws/aws-sdk-go-v2/config` from 1.32.14 to 1.32.16
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/config/v1.32.14...config/v1.32.16)

Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.19.14 to 1.19.15
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/credentials/v1.19.14...credentials/v1.19.15)

Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.99.0 to 1.99.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/service/s3/v1.99.0...service/s3/v1.99.1)

Updates `github.com/aws/aws-sdk-go-v2/service/sns` from 1.39.15 to 1.39.16
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/service/sns/v1.39.15...service/sns/v1.39.16)

Updates `github.com/aws/smithy-go` from 1.24.3 to 1.25.0
- [Release notes](https://github.com/aws/smithy-go/releases)
- [Changelog](https://github.com/aws/smithy-go/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws/smithy-go/compare/v1.24.3...v1.25.0)

Updates `github.com/ceph/go-ceph` from 0.38.0 to 0.39.0
- [Release notes](https://github.com/ceph/go-ceph/releases)
- [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md)
- [Commits](https://github.com/ceph/go-ceph/compare/v0.38.0...v0.39.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-version: 1.41.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.32.16
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/credentials
  dependency-version: 1.19.15
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3
  dependency-version: 1.99.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sns
  dependency-version: 1.39.16
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/smithy-go
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/ceph/go-ceph
  dependency-version: 0.39.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-04-20 14:44:35 +00:00
dependabot[bot] 2c6f1239f6 build(deps): bump github/codeql-action from 4.35.1 to 4.35.2 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.1 to 4.35.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/c10b8064de6f491fea524254123dbe5e09572f13...95e58e9a2cdfd71adc6e0353d5c52f41a045d225)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.35.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-04-20 14:39:10 +00:00