Commit Graph
13624 Commits
Author SHA1 Message Date
subhamkrai ec3953ea34 csi: update csi-operator to v1.0.0
This commit update the csi-operator to latest v1.0.0.
we need to manually patch the csi drivers with the new serviceAccount
name that are being creating based on the latest ceph-csi-operator
release v1.0.0 where serviceAccount are being separate from csi-operator
chart.

co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 06452991bf)
2026-05-21 15:22:41 -06:00
Travis Nielsen 8abf77d763 Merge pull request #17566 from rook/mergify/bp/release-1.20/pr-17527
object: migrate sns topic provisioner to aws sdk v2 (backport #17527)
2026-05-20 10:36:35 -06:00
mergify[bot] ed28bd4b6e Merge pull request #17567 from rook/mergify/bp/release-1.20/pr-17530
core: rm unused consts (backport #17530)
2026-05-20 16:27:03 +00:00
Joshua Hoblitt 1efea0123c core: rm unused consts
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 9eec9c730e)
2026-05-20 15:03:03 +00:00
Oded Viner 9d91a725a0 object: migrate sns topic provisioner to aws sdk v2
migrate the sns-based topic provisioner from aws-sdk-go (v1)
to aws-sdk-go-v2. replace v1 session, credentials, and
request handlers with v2 aws.Config, static credentials
provider, and endpoint resolver. convert the custom ceph rgw
v2 signer hack from a v1 handler swap to a smithy finalize
middleware. update sns api calls to use context-first
signatures, map[string]string attributes, and typed
snstypes.NotFoundException error handling via errors.As.
update unit tests accordingly.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 81a2cd8833)
2026-05-20 13:55:22 +00:00
Travis Nielsen ae4c2f1adb Merge pull request #17564 from rook/mergify/bp/release-1.20/pr-17562
docs: fix kubectl exec commands in the DR troubleshooting guide (backport #17562)
2026-05-19 13:10:28 -06:00
Michael Adam de95059d99 docs: fix kubectl exec commands in the DR troubleshooting guide
kubectl exec requires a double dash ('--') between the pod name and the command to be
executed.

The disaster recovery troubleshooting guide missed those characters
in two places.

This change fixes the guide by adding the missing double dashes

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit ef7e80bedc)
2026-05-19 19:07:06 +00:00
subham rai 0ddf1fdc62 Merge pull request #17554 from rook/mergify/bp/release-1.20/pr-17549
ci: Update github actions to Go 1.26 (backport #17549)
2026-05-18 10:35:31 +05:30
Travis Nielsen d6580d5a94 ci: update github actions to go 1.26
Use the latest version of Go in the github actions.
Support for both Go 1.25 and 1.26 is still available,
this only affects the version used by the CI.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 033f6f732e)
2026-05-18 04:32:00 +00:00
Travis Nielsen f7b0aee51a Merge pull request #17550 from rook/mergify/bp/release-1.20/pr-17547
build: fix gosec and go vet lint errors for Go 1.26  (backport #17547)
2026-05-15 14:17:30 -06:00
mergify[bot] 53fdac2857 Merge pull request #17552 from rook/mergify/bp/release-1.20/pr-17545
osd: fix flaky TestAddRemoveNode failure (backport #17545)
2026-05-15 20:09:09 +00:00
Santosh 840e15a22b osd: fix flaky TestAddRemoveNode failure
User RaceFreeFakeWatcher isntead of FakeWatcher in TestAddRemoveNode
function. The test runs c.Start() in a goroutine whch stops the watcher
when done. If mockNodeOrchestrationCompeltion sends a watch ever after,
that, FakeWatcher panics with "send on a closed channel".
RaceFreeFakeWatcher safely ignores the sends on a stopped channel.

Signed-off-by: Santosh <sapillai@redhat.com>
(cherry picked from commit 6781d2e58d)
2026-05-15 19:40:08 +00:00
Sunnatillo a9c1805ae3 build: fix gosec and go vet lint errors for Go 1.26
Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
(cherry picked from commit 0bd299aa60)
2026-05-15 19:26:04 +00:00
mergify[bot] 20b0feaf43 Merge pull request #17548 from rook/mergify/bp/release-1.20/pr-17535
ceph: skip base rule creation if pools exit (backport #17535)
2026-05-15 14:44:33 +00:00
Santosh 5916722cff pool: skip base rule creation of pools exit
createREplicatedPoolForApp creates a base Crush rule (named after the
pool) on every reconcile, even if the pool already exists and uses a
suffixed rule ( eg pool_host_ssd). This causes orphaned rules to
reappear after every operator restart, immediately after
CleanupUnusedCrushRules deletes them.

This PR ensures that the base rule is created only if the pool does not
exist yet.

Signed-off-by: Santosh <sapillai@redhat.com>
(cherry picked from commit df0f4e6c99)
2026-05-15 14:14:36 +00:00
mergify[bot] f3a39ae947 Merge pull request #17543 from rook/mergify/bp/release-1.20/pr-17407
osd: honor per-device deviceClass in raw-mode prepare and reconcile (backport #17407)
2026-05-14 22:19:27 +00:00
Artem Torubarov 3872e1d0b7 osd: honor per-device deviceClass in raw-mode prepare and reconcile
Fixes #16834 and #17384. Per-OSD CR deviceClass was ignored in
osd prepare job when reporting the osd config back to the operator,
and in the operator's reconcile override.
Fixed by resolving the per-device class from the CR devices list
in GetCephVolumeRawOSDs and in makeDeployment.

Signed-off-by: Artem Torubarov <artem.torubarov@sap.com>
(cherry picked from commit b41d63788d)
2026-05-14 18:05:09 +00:00
mergify[bot] 2961fedc92 Merge pull request #17540 from rook/mergify/bp/release-1.20/pr-17421
mon: add resource request for mon drbd containers (backport #17421)
2026-05-14 17:46:33 +00:00
mergify[bot] caa4d4c073 Merge pull request #17539 from rook/mergify/bp/release-1.20/pr-17538
security: remove net_raw from operator-openshift.yaml scc (backport #17538)
2026-05-14 17:40:37 +00:00
subhamkrai cd6a330d54 mon: add resource request for mon drbd containers
adding missing resource request for mon drbd containers
log-collector and shut-down-app and update the unit test
to validate.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit d88e287726)
2026-05-14 17:16:04 +00:00
Oded Viner 81e10ad5bf security: remove net_raw from operator-openshift.yaml scc
net_raw is listed in the rook-ceph scc allowedcapabilities
but no daemon uses it — all pods explicitly drop net_raw.
remove it to align with the go scc helper and helm charts.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 572527d476)
2026-05-14 17:09:43 +00:00
mergify[bot] 26e483a0f3 Merge pull request #17537 from rook/mergify/bp/release-1.20/pr-17447
pool: add stripe_unit with erasure-code-profile set (backport #17447)
2026-05-14 17:06:51 +00:00
subhamkrai 536909a58b pool: add stripe_unit with erasure-code-profile set
this commit adds flag stripe_unit for the command
ceph osd erasure-code-profile set [flags]. This key
increase perfomance for ec pool. The default value
is 4kib/4096 bytes.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 9fb0582dd6)
2026-05-14 16:38:55 +00:00
mergify[bot] 5aeb9c4e25 Merge pull request #17534 from rook/mergify/bp/release-1.20/pr-17448
mon: add watcher for DRBD ConfigMap in TNF deployments (backport #17448)
2026-05-14 16:28:00 +00:00
Prabhala Tara Aasrita 2821bd1bb4 mon: add watcher for DRBD ConfigMap in TNF deployments
Added a watcher in the cluster controller to detect changes to the DRBD ConfigMap used by floating monitors in TNF deployments. When the ConfigMap is updated, the watcher triggers a CephCluster reconciliation to ensure configuration changes are applied.

Fixes #17338

Signed-off-by: Prabhala Tara Aasrita <taraasrita@ibm.com>
(cherry picked from commit af03615e97)
2026-05-14 15:52:47 +00:00
mergify[bot] 1b41970bed Merge pull request #17528 from rook/mergify/bp/release-1.20/pr-17468
object: migrate notification package to aws sdk v2 (backport #17468)
2026-05-13 18:10:00 +00:00
Oded Viner 09812ac966 object: migrate notification package to aws sdk v2
migrate the notification provisioner and s3ext packages from
aws sdk v1 to v2. the custom DeleteBucketNotification call is
rewritten to manually build and sign the HTTP request using the
v2 v4 signer, since this ceph-specific API has no sdk equivalent.

also fix t.Skipped() -> t.Skip() in notification integration test.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit f5df592106)
2026-05-13 17:37:22 +00:00
mergify[bot] 3504b2b827 Merge pull request #17514 from rook/mergify/bp/release-1.20/pr-17502
core: skip crush rule cleanup if no pools exist yet (backport #17502)
2026-05-12 23:39:45 +00:00
Travis Nielsen 5a80ae4217 Merge pull request #17521 from rook/mergify/bp/release-1.20/pr-17286
doc: add CSI operator resource cleanup steps to teardown guide (backport #17286)
2026-05-12 13:36:59 -10:00
Travis Nielsen 83c060e590 Merge pull request #17522 from rook/mergify/bp/release-1.20/pr-17364
build(deps): bump github.com/moby/spdystream from 0.5.0 to 0.5.1 (backport #17364)
2026-05-12 13:36:45 -10:00
Travis Nielsen 31bbc393eb Merge pull request #17467 from rook/mergify/bp/release-1.20/pr-17453
osd: detect encryption label from dmcrypt path (backport #17453)
2026-05-12 13:36:16 -10:00
mergify[bot] 7d0785d635 Merge pull request #17463 from rook/mergify/bp/release-1.20/pr-17176
csi: move csi management to admin (backport #17176)
2026-05-12 23:17:38 +00:00
Travis Nielsen 2cd4215f8f Merge pull request #17517 from rook/mergify/bp/release-1.20/pr-17472
mgr: retry self-signed cert creation on wrapped context deadline errors (backport #17472)
2026-05-12 13:12:23 -10:00
Travis Nielsen 44c860824d Merge pull request #17519 from rook/mergify/bp/release-1.20/pr-17494
docs: fix duplicated words in docs and comments (backport #17494)
2026-05-12 13:12:00 -10:00
dependabot[bot] 7f2d883a55 build(deps): bump github.com/moby/spdystream from 0.5.0 to 0.5.1
Bumps [github.com/moby/spdystream](https://github.com/moby/spdystream) from 0.5.0 to 0.5.1.
- [Release notes](https://github.com/moby/spdystream/releases)
- [Commits](https://github.com/moby/spdystream/compare/v0.5.0...v0.5.1)

---
updated-dependencies:
- dependency-name: github.com/moby/spdystream
  dependency-version: 0.5.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 88a3e79cbb)
2026-05-12 22:54:03 +00:00
subhamkrai a9d29bdec6 csi: move csi management to admin
Going forward, admin will manage the csi operator
CR's and rook will only manage Ceph Connection cr
and client Profile cr.

The old csi driver is completely removed from Rook
and can no longer be used starting in Rook v1.20.

The upgrade guide will contain the needed transition steps
for managing the csi operator settings.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 4eefad42e8)
2026-05-12 12:49:21 -10:00
subhamkrai 9f978ec685 ci: fix some minor canary test issues
The canary test was waiting for replicapool
instead of replicapool2, and a more reliable
wait for the toolbox pod start is added.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit b50f1a3d60)
2026-05-12 12:49:21 -10:00
Travis Nielsen 97926f1dc9 Merge pull request #17470 from rook/mergify/bp/release-1.20/pr-17464
core: add default ResourceRequirements for cmd-reporter (backport #17464)
2026-05-12 12:47:37 -10:00
Lumir Sliva 32615f0f3a doc: add CSI operator resource cleanup steps to teardown guide
Add a section to the teardown documentation with cleanup commands
for CSI operator resources: OperatorConfig, Driver, ClientProfile,
ClientProfileMapping, and CephConnection custom resources, plus the
csi-operator.yaml deployment manifest.

Signed-off-by: Lumir Sliva <61183145+lumir-sliva@users.noreply.github.com>
(cherry picked from commit 943ea89cd5)
2026-05-12 22:45:40 +00:00
immanuwell 551d62a2a2 docs: fix duplicated words in docs and comments
Clean up duplicated words and a typo in object storage docs, comments, and user-facing messages.

Signed-off-by: immanuwell <pchpr.00@list.ru>
(cherry picked from commit c3a9f5fdd9)
2026-05-12 22:41:48 +00:00
texasich 091ed17fd8 mgr: retry self-signed cert creation on wrapped deadline errors
Signed-off-by: texasich <texasich@users.noreply.github.com>
(cherry picked from commit beb6c0f373)
2026-05-12 22:38:05 +00:00
Santosh f09555f1a8 core: skip crush rule cleanup if no pools exist yet
During the initial cluster setup, CleanUnusedCrushRules() runs after MGR
startup but before any pools are created (if user does not create the
.mgr pool along with the cephCluster manifest). It deletes the default
replicated_pool since no pool references it.

This leaves the cluster in a state if Zero crush rules. When the MGR
tries to start the device_health_metris during this window, thne it
fails to find the crush rule and crashes.

Skip the cleanup when no pools exists yet, since there is nothing
meaninful to cleanup.

Signed-off-by: Santosh <sapillai@redhat.com>
(cherry picked from commit 1c1d6cf261)
2026-05-12 14:24:23 +00:00
mergify[bot] e51203798d Merge pull request #17513 from rook/mergify/bp/release-1.20/pr-17474
core: Declare concurrent cluster reconciles stable (backport #17474)
2026-05-12 10:38:37 +00:00
subham rai 9b5b80b172 Merge pull request #17511 from rook/mergify/bp/release-1.20/pr-17503
nvmeof: add sys_admin to scc allowedcapabilities for gateway pods (backport #17503)
2026-05-12 15:39:54 +05:30
mergify[bot] ad5a48b123 Merge pull request #17457 from rook/mergify/bp/release-1.20/pr-17455
ci: Upgrade tests from v1.19 to master (backport #17455)
2026-05-11 23:30:30 +00:00
Travis Nielsen aff4a6b9f8 ci: upgrade tests from v1.19 to master
The upgrade integration tests for the v1.20 release need to
validate the upgrade starting from v1.19 to the latest.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 1f205c4be4)
2026-05-11 13:02:16 -10:00
Travis Nielsen 4182fe67a1 core: declare stable concurrent cluster reconciles
The ROOK_RECONCILE_CONCURRENT_CLUSTERS feature was implemented
in v1.19. This feature has been stable, with no related issues
reported. The feature is tested in the CI with no known
stability issues. Let's declare this feature as stable.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 45ec32e513)
2026-05-11 22:50:18 +00:00
Travis Nielsen ce8ef223c9 Merge pull request #17501 from rook/mergify/bp/release-1.20/pr-17498
build: bump golang.org/x/net to fix govulncheck ci failure (backport #17498)
2026-05-11 12:04:19 -10:00
Oded Viner 67520301ac nvmeof: add sys_admin to scc allowedcapabilities for gateway pods
the nvmeof gateway requires privileged containers with
sys_admin capability. the rook-ceph scc only allowed mknod,
causing pod creation to fail on openshift with:
"unable to validate against any security context constraint"

add sys_admin to allowedcapabilities in the helm chart sccs
and the go scc helper. this does not affect other daemons
(osd, rgw, mgr, mon) since they do not request sys_admin.

the operator-openshift.yaml example already includes
sys_admin, so this aligns the helm charts to match.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit f8c1c99cb4)
2026-05-11 22:04:16 +00:00
Oded Viner 7b4313ffbb build: bump golang.org/x/net to fix govulncheck ci failure
bump golang.org/x/net from v0.52.0 to latest patched version
to resolve known http2 vulnerability flagged by govulncheck.

the vulnerable call path is:
  object.debugHTTPClient.Do
  -> httputil.DumpRequestOut
  -> http2.Transport.RoundTrip

this is a pre-existing issue blocking ci on all pull requests.

Signed-off-by: Oded Viner <oviner@redhat.com>
(cherry picked from commit 20fa0128f5)
2026-05-11 09:25:07 +00:00