Commit Graph
10395 Commits
Author SHA1 Message Date
Redouane Kachach f2d4e6792f mgr: adding CEPH_ARGS to the mgr pod so radosgw-admin can use it
ceph dashboard uses radosgw-admin for certain tasks that
aren't accessible via the rgw REST API. Due to the absence of
a valid ceph.conf file at /etc/ceph/ceph.conf within the mgr pod,
radosgw-admin fails to operate, resulting in 500 errors across
various 'Object Gateway' views on the dashboard. This change
adds CEPH_ARGS environment variable to the mgr pod enabling
its propagation and utilization by the dashboard/radosgw-admin
for executing rgw commands.

closes: https://github.com/rook/rook/issues/13255

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit afc485fa03)
2023-11-27 17:02:27 +00:00
mergify[bot] 19f186db83 Merge pull request #13275 from rook/mergify/bp/release-1.12/pr-13265
exporter: change deployment strategy to Recreate (backport #13265)
2023-11-27 15:48:51 +00:00
Divyansh Kamboj e312fae3cf exporter: change deployment strategy to Recreate
Restarting the exporter using RollingRelease causes a race condition,
that results in exporter crashing and the ceph health to show a warning.

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
(cherry picked from commit f9d6cd7f3a)
2023-11-27 14:46:18 +00:00
mergify[bot] 2125cdf74e Merge pull request #13260 from rook/mergify/bp/release-1.12/pr-13259
helm: use csiaddonsport parameter (backport #13259)
2023-11-24 05:43:55 +00:00
Satoru Takeuchi c84caf28b2 helm: use csiaddonsport correctly
We have csi.csiAddonsPort paramete but it's not used everywhere.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
(cherry picked from commit 1d8cdeca03)
2023-11-24 05:11:45 +00:00
mergify[bot] c64272e8a3 Merge pull request #13254 from rook/mergify/bp/release-1.12/pr-13248
mgr: get servicemonitor exporter's interval from MonitoringSpec (backport #13248)
2023-11-21 23:39:29 +00:00
Redouane Kachach 47a6c9ff7f mgr: get servicemonitor exporter's interval from MonitoringSpec
this change updates the serviceMonitor interval of the the rook-ceph-exporter
with the value from the MonitoringSpec.

closes: https://github.com/rook/rook/issues/13159

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 6b71325dbe)
2023-11-21 23:03:16 +00:00
mergify[bot] 19a176236b Merge pull request #13242 from rook/mergify/bp/release-1.12/pr-13237
rgw: correctly handle mgr-proxied rgw cli commands in multus scenarios (backport #13237)
2023-11-21 00:50:17 +00:00
zer0def ad9e191fb9 rgw: correctly handle mgr-proxied rgw cli commands in multus scenarios
Due to multi-site Ceph object resources (realms, zonegroups, zones)
reconciliation CLI commands being proxied through CephCluster's Mgr pods
in Multus-based scenarios, return codes were being additionally wrapped
by K8S' command streams and weren't adequately handled in-code, causing
reconciliation of CephObject(Realm|ZoneGroup|Zone) resources to fail, as
an exit code of 0, instead of the expected syscall.ENOENT (2) was returned.

Fixes #12833

Signed-off-by: zer0def <zv0uzqbqnncivw0afjsx79jmd19shpps3r5f2vjc6yv@definedaszero.xyz>
(cherry picked from commit 9b69b5cb46)
2023-11-21 00:19:04 +00:00
Travis Nielsen c6f573ba8d Merge pull request #13232 from rook/mergify/bp/release-1.12/pr-13228
doc: correct csi ceph.conf path (backport #13228)
2023-11-17 09:59:15 -07:00
Madhu Rajanna 0218359fde doc: correct csi ceph.conf path
correct the csi ceph.conf path
in the documentation.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit d1613af35d)
2023-11-17 16:49:42 +00:00
mergify[bot] a240a47946 Merge pull request #13224 from rook/mergify/bp/release-1.12/pr-12850
core: report node metrics using ceph telemetry (backport #12850)
2023-11-16 22:27:03 +00:00
parth-gr d8d787bfa0 core: report node metrics using ceph telemetry
Add this reporting with the cephcluster reconcile,
Similar way we reported other telemetry's

Closes: https://github.com/rook/rook/issues/12344

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit f007f2aca1)
2023-11-16 21:56:08 +00:00
Travis Nielsen aa3eab85ca Merge pull request #13223 from travisn/release-1.12.8
build: Update the release version to v1.12.8
v1.12.8
2023-11-16 13:14:43 -07:00
travisn a3c6ffab37 build: update the release version to v1.12.8
For the patch release update the examples and manifests
to v1.12.8

Signed-off-by: travisn <tnielsen@redhat.com>
2023-11-16 12:13:51 -07:00
mergify[bot] 2e7f74fecf Merge pull request #13208 from rook/mergify/bp/release-1.12/pr-13206
multus: fix placement error for net addr detect job (backport #13206)
2023-11-15 00:41:38 +00:00
Blaine Gardner d829f8c0b1 multus: fix placement error for net addr detect job
Fix an issue in the network address detection job where placement was
only retreived from osd and not merged with all.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 0a538bfc37)
2023-11-14 23:59:04 +00:00
mergify[bot] 997289bec0 Merge pull request #13198 from rook/mergify/bp/release-1.12/pr-12845
nfs: add livness-probe to nfs-ganesha container (backport #12845)
2023-11-13 20:30:38 +00:00
Shachar Sharon 47839e46dc nfs: allow livness-probe for nfs-ganesha container
Use K8s LivenessProbe mechanism to check OK-status of nfs-ganesha
container. A user may define his own lineness-probe, or a default one
which expects NFS TCP-port 2049 to be active; that is, willing to accept
new connections: for Ceph>=18.2.1 issue 'rpcinfo' call on local pod;
otherwise use standard K8s TCP-socket liveness probe mechanism.
Define permissive values to liveness-probe to ensure that the NFS
service is defined in failed-state only when it has non-recoverable
error.

The current default definition of LivenessProbe is expected to guard the
nfs pod from at least the following two cases:

  - Deadlocks: where an nfs-ganesha server is running, but unable serve
    new connections due to internal bad-state.

  - Resource exhaustion on the host node (e.g. OOM) which prevents the
    server from accepting new connections and reply to NULL RPC request.

In both cases we expect K8s to reschedule the nfs pod, most likely on
different host node.

Refs rook issue #12719

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
(cherry picked from commit e05184d0a7)
2023-11-13 19:45:28 +00:00
Shachar Sharon f2420162bc nfs: add optional LivenessProbe to GaneshaServerSpec
Allow end-user to have full control on NFS-Ganesha liveness probe:

  - Disabled
  - Enabled, using user-provided definition
  - Enabled, using Rook's default liveness probe for Ganesha.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
(cherry picked from commit 7c3e91390e)
2023-11-13 19:45:28 +00:00
mergify[bot] 8a77c1949f Merge pull request #13197 from rook/mergify/bp/release-1.12/pr-13069
pool: allow updating deviceClass on existing pool (backport #13069)
2023-11-13 18:43:04 +00:00
subhamkrai a417ce880c pool: allow updating deviceClass on existing pool
This commits add check to update the deviceClass on
existing pool.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 133154d192)
2023-11-13 17:58:55 +00:00
Travis Nielsen 03a55c33f9 Merge pull request #13183 from rook/mergify/bp/release-1.12/pr-13169
Revert "osd: support encrypted OSD on partiton" (backport #13169)
2023-11-10 13:28:54 -07:00
Blaine Gardner e043f27584 Merge pull request #13188 from rook/mergify/bp/release-1.12/pr-13129
multus: use rook image for ip range detection (backport #13129)
2023-11-10 11:44:33 -06:00
Travis Nielsen 8141632996 Merge pull request #13186 from rook/mergify/bp/release-1.12/pr-13179
mgr: set interval of serviceMonitor to the value from MonitoringSpec (backport #13179)
2023-11-10 10:36:39 -07:00
Satoru Takeuchi 00c206c754 Revert "osd: support encrypted OSD on partiton"
This reverts commit 093125904b.

Once we introduced encrypted OSD on partition in #12924.
However, even though `encryptedDevice` field is `true`,
an non-encrypted OSD is created. To prevent the creation
of misconfigured OSD, it's better to revert #12924 for now.

Initially, I intended to correct this problem. However, I found
it will take long time because we need to change the KMS-related
code, init containers of both OSD pod and OSD prepare pod.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
(cherry picked from commit 8e80b21035)
2023-11-10 17:36:04 +00:00
Travis Nielsen e8d521ab69 Merge pull request #13181 from rook/mergify/bp/release-1.12/pr-13157
build(deps): bump helm/chart-testing-action from 2.6.0 to 2.6.1 (backport #13157)
2023-11-10 10:35:13 -07:00
Travis Nielsen e27352aab0 Merge pull request #13189 from rook/mergify/bp/release-1.12/pr-13170
ci: fix objectsuite flakiness (backport #13170)
2023-11-10 10:34:13 -07:00
Redouane Kachach 4c4baccb37 mgr: set interval of serviceMonitor to the value from MonitoringSpec
This change updates the serviceMonitor interval field with the
value from the MonitoringSpec.

closes: https://github.com/rook/rook/issues/13159

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 06bc976959)
2023-11-10 16:27:35 +00:00
parth-gr 0e6604d24c ci: fix objectsuite flakiness
objectstore deletion was failing with not found error,
Could Not get resource in k8s -- Failed to run:
kubectl [get -n object-ns CephObjectStore
other-tls-test-store -o json]
So added a check if it not found then donot check its
further condition

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 40295a989c)
2023-11-10 16:21:28 +00:00
Blaine Gardner d5908d0e3c multus: use rook image for ip range detection
Use the Rook image (defined by the operator pod) to detect the Multus
network address ranges. It is reasonable for users to want to have a
minimal Ceph image that does not have the `ip` utility installed, which
is used for detecting the address ranges of multus interfaces. Instead,
use the Rook image, which Rook can ensure has the `ip` tool if Ceph ever
removes it from their image.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit db1ca8c93e)
2023-11-10 16:20:48 +00:00
Blaine Gardner 1e131f29f5 Merge pull request #13164 from rook/mergify/bp/release-1.12/pr-13156
ci: filter disks by 14 and 64 G in the CI (backport #13156)
2023-11-10 10:20:07 -06:00
dependabot[bot] 4f5e9c1fbb build(deps): bump helm/chart-testing-action from 2.6.0 to 2.6.1
Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/helm/chart-testing-action/releases)
- [Commits](https://github.com/helm/chart-testing-action/compare/v2.6.0...v2.6.1)

---
updated-dependencies:
- dependency-name: helm/chart-testing-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit df5527ce25)
2023-11-08 17:14:32 +00:00
sp98 2088e5f929 ci: filter both 14 and 64 disks in CI
github ci runner is allocating both 14 and 64 Gb disks to the setup.
Rook CI currently hard codes the lsblk with a 14G filter.
This PR updates the filter to use either 14G or 64G disks.

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit 345f92961b)
2023-11-06 17:21:57 +00:00
Travis Nielsen 3bc4cafc71 Merge pull request #13153 from rook/mergify/bp/release-1.12/pr-13150
ci: fix mike deploy flags (backport #13150)
2023-11-03 10:51:21 -06:00
Alexander Trost c29e5b5854 ci: fix mike deploy flags
This fixes the docs deploy issues caused by the mike 2.0.0 release that
removed/renamed some flags, see
https://github.com/jimporter/mike/releases/tag/v2.0.0

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
(cherry picked from commit 4a48c14861)
2023-11-03 16:13:26 +00:00
Travis Nielsen 04fbbb1c09 Merge pull request #13147 from rook/mergify/bp/release-1.12/pr-13140
docs: fix user capability name in object store user (backport #13140)
2023-11-03 10:13:11 -06:00
Alexander Gil 56294263f9 docs: fix user capability name in object store user
Signed-off-by: Alexander Gil <pando855@gmail.com>
(cherry picked from commit d6edc3bba4)
2023-11-03 13:14:47 +00:00
Blaine Gardner 021bcae09e Merge pull request #13134 from rook/mergify/bp/release-1.12/pr-13123
multus: improve the multus validation test's flakiness metric (backport #13123)
2023-11-01 10:14:09 -06:00
Sheetal Pamecha 3fbeb11858 multus: improve the multus validation test's flakiness metric
Allow the flakiness threshold window to be tuned from the cli

Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
(cherry picked from commit 06c176524a)
2023-11-01 15:45:56 +00:00
Travis Nielsen 74e751f201 Merge pull request #13132 from rook/mergify/bp/release-1.12/pr-13125
docs: add namespace on delete webhook command (backport #13125)
2023-10-31 13:27:02 -06:00
Mateus Valgueiro e1c9018617 docs: add namespace on delete webhook command
The only command on the page that did not have a namespace directly set was this one.

Signed-off-by: Mateus Valgueiro <mateusvalgueiro@gmail.com>
(cherry picked from commit 85401f87ea)
2023-10-31 19:18:45 +00:00
Travis Nielsen 0043639bc7 Merge pull request #13131 from rook/mergify/bp/release-1.12/pr-13128
ci: Update helm linter to v2.6.0 (backport #13128)
2023-10-31 13:16:04 -06:00
travisn 77a0976290 ci: update helm linter to v2.6.0
The helm linter was failing with v2.4.0. Now
update the version of the action to the latest
and greatest.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit dfa522d906)
2023-10-31 18:11:21 +00:00
Travis Nielsen 5a1522a6b9 Merge pull request #13124 from rook/mergify/bp/release-1.12/pr-12952
mon: failover mons from hostpath to persistent volumes (backport #12952)
2023-10-30 14:29:02 -06:00
sp98 0a3dc3cda0 mon: failover mon from hostpath to pv
failover mons from  hostpath to pv and vice versa

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit 09356636fa)
2023-10-30 17:32:02 +00:00
Travis Nielsen 5db18f03d5 Merge pull request #13116 from rook/mergify/bp/release-1.12/pr-13114
pool: rbd cmd shouldn't use admin in external mode (backport #13114)
2023-10-30 07:56:42 -06:00
subhamkrai 214b109f23 pool: rbd cmd shouldn't use admin in external mode
when creating networkFence, rbd command was loading
admin config and hence running rbd command use client.admin
in case of external cluster also. With this commit instead
of client.admin user it will use what is being passed to
config.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit ef4dd76df1)
2023-10-27 16:23:54 +00:00
Travis Nielsen b615308b97 Merge pull request #13112 from travisn/release-1.12.7
build: Update release version to v1.12.7
v1.12.7
2023-10-27 10:03:00 -06:00
travisn 20f4b62475 build: update release version to v1.12.7
For the patch release update the examples and docs
to v1.12.7

Signed-off-by: travisn <tnielsen@redhat.com>
2023-10-26 14:13:15 -06:00