Commit Graph
11473 Commits
Author SHA1 Message Date
Santosh Pillai f43e088fda core: fix deletion of the osd-replace-config cm
MustDelete DeleteOption was set to `true` when deleting
osd-repalce-config configMap.  This cm won't existing after
all the OSDs get migrated. So deletion of the non-existent
cm will result in error. This PR removes `mustDelete: true` from
the DeletionOption when deleting osd-replace-config configmap

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
(cherry picked from commit 8dd237b460)
2024-10-16 13:50:55 +00:00
subham rai 1686b1a3df Merge pull request #14857 from rook/mergify/bp/release-1.15/pr-14854
core: Skip counting exporter pods as a ceph pod (backport #14854)
2024-10-16 11:57:59 +05:30
Travis Nielsen a4aea241b5 core: skip counting exporter pods as a ceph pod
The exporter pods were being counted as a ceph pod,
so once an exporter pod was added to a node, it would never
be removed since the controller thinks the exporter pod
itself is a ceph pod for which the exporter must be present.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit a71078b733)
2024-10-15 16:10:38 +00:00
mergify[bot] 3fd226bc43 Merge pull request #14856 from rook/mergify/bp/release-1.15/pr-14845
docs: Add documentation for RBD VolumeGroupSnapshot (backport #14845)
2024-10-15 14:20:19 +00:00
Niraj Yadav 0e720ff47a docs: add documentation for rbd volumegroupsnapshot
This PR adds the sample YAMLs and documentation
for the RBD VolumeGroupSnapshot.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit 524b6071d2)
2024-10-15 13:50:54 +00:00
mergify[bot] 01d82e85af Merge pull request #14851 from rook/mergify/bp/release-1.15/pr-14842
test: improve reliability of canary rgw-multisite-testing (backport #14842)
2024-10-14 18:40:41 +00:00
Joshua Hoblitt 32a6976046 test: improve reliability of canary rgw-multisite-testing
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 92d9f994c2)
2024-10-14 17:07:47 +00:00
Joshua Hoblitt f3468c7860 test: inline .github/workflows/rgw-multisite-test
Merge/inline.github/workflows/rgw-multisite-test/action.yml into
.github/workflows/canary-integration-test.yml as the step from the
"composite" action are not displayed in the console.  The absence of the
step names may make it difficult to determine where a failure is
occurring.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit b4ac943b62)
2024-10-14 17:07:45 +00:00
Travis Nielsen 5a335d5506 Merge pull request #14840 from rook/mergify/bp/release-1.15/pr-14831
csi: disable fencing in Rook (backport #14831)
2024-10-11 10:57:53 -06:00
Madhu Rajanna 34f81ec820 csi: disable fencing in Rook
Disabling the RBD and CephFS fencing
in Rook for now as its having bugs where
Rook is blocklisting wrong IP address
due to timing issues.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 1d1ed5e962)
2024-10-11 16:27:09 +00:00
mergify[bot] ad43974c3a Merge pull request #14828 from rook/mergify/bp/release-1.15/pr-14820
multus: do not force delete in validation cleanup (backport #14820)
2024-10-09 19:17:40 +00:00
Blaine Gardner fcc1bc20d7 multus: do not force delete in validation cleanup
Do not force delete resources in validation cleanup. Force deletion can
result in CNI IP address management (IPAM) addresses not being released
cleanly, exhausting them. This can then lead to Rook cluster deploy
failure if the CNI IPAM isn't able to garbage collect the IPs quickly.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 936fe60a76)
2024-10-09 18:05:51 +00:00
mergify[bot] 972731c12d Merge pull request #14814 from rook/mergify/bp/release-1.15/pr-14805
mon: Do not remove extra mon in middle of failover (backport #14805)
2024-10-07 14:35:30 +00:00
Travis Nielsen b8ea67f56e mon: do not remove extra mon in middle of failover
If the mon failover is in progress, ensure the removal
of an extra mon deployment is skipped since that code
path only has one mon in the list for the mon that was
just newly started. The extra mon was erroneously removing
a random mon in that case, followed immediately by the mon
failover completing and removing the expected failed mon,
and potentially causing mon quroum loss.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit e2cadab6fe)
2024-10-07 13:27:56 +00:00
mergify[bot] a043ee98fb Merge pull request #14807 from rook/mergify/bp/release-1.15/pr-14798
mds: fix liveness probe timeout (backport #14798)
2024-10-07 06:55:41 +00:00
Blaine Gardner 07884a3028 mds: fix liveness probe timeout
When the MDS liveness probe times out, it should not fail the probe. If
the cluster has a network partition or other issue that causes the Ceph
mon cluster to become unstable, `ceph ...` commands can hang and cause
a timeout. In this case, the MDS should not be restarted so as to not
cause cascading cluster disruption.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit ad1bae9e1b)
2024-10-07 06:18:54 +00:00
Travis Nielsen cefb365f32 Merge pull request #14803 from travisn/release-1.15.3
build: Set the release version to v1.15.3
v1.15.3
2024-10-03 15:08:30 -06:00
Travis Nielsen 050a5dbfda build: set the release version to v1.15.3
For the patch release update the docs and manifests
to v1.15.3

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-03 14:34:04 -06:00
mergify[bot] 3014b23a28 Merge pull request #14802 from rook/mergify/bp/release-1.15/pr-14801
rgw: fix CephObjectZone failing with pre-existing pools (backport #14801)
2024-10-03 20:17:36 +00:00
Joshua Hoblitt 8ed15f773c rgw: change CephObjectZone.spec.{dataPool,metadataPool} to optional
These fields must be optional in order to allow usage of pre-existing
pools managed by CephBlockPool CR(s).

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 76fa776795)
2024-10-03 19:50:06 +00:00
Travis Nielsen 26f1ba5053 Merge pull request #14799 from rook/mergify/bp/release-1.15/pr-14772
rgw: fix CephObjectStore failing with pre-existing pools (backport #14772)
2024-10-03 13:48:27 -06:00
Joshua Hoblitt 121f8383fe test: convert all github-action-helper functs to $REPO_DIR
This allows all functions to be called in any order without concern for
the CWD.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 581fd5c197)
2024-10-03 17:51:32 +00:00
Joshua Hoblitt 4822dfc73c test: mv canary test specific resources out of deploy_cluster()
Factor out most of the CRs used by various canary tests to a new
deploy_cluster_full_of_cruft_please_stop_using_this() function.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 31d55b90fe)
2024-10-03 17:51:32 +00:00
Joshua Hoblitt 33b345f0a5 test: add object-with-cephblockpool canary test
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit ed8156017e)
2024-10-03 17:51:31 +00:00
Joshua Hoblitt 89a3eb5542 rgw: fix cephObjectStore failing with pre-existing pools
When attempting to use pre-existing (or cephBlockPool managed) pools and
the cephObjectStore.spec.{metadataPool,dataPool} fields are not
specified, rgw creation will fail with this error:

    2024-09-25 21:00:17.744358 E | ceph-object-controller: failed to reconcile CephObjectStore "rook-ceph/test1". failed to create object store deployments: failed to create object pools: failed to create metadata pools: failed to create pool "test1.rgw.control": pool "test1.rgw.control" type is not defined as replicated or erasure coded

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 9b952e0a55)
2024-10-03 17:51:30 +00:00
Joshua Hoblitt dc4460cdec test: add github-action-helper toolbox functions
Added these functions for running commands in the toolbox pod:

- toolbox()
- ceph()
- rbd()
- radosgw-admin()

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit cb1dd152ad)
2024-10-03 17:51:30 +00:00
mergify[bot] 704136c1d5 Merge pull request #14796 from rook/mergify/bp/release-1.15/pr-14791
helm: Add enforce host network setting (backport #14791)
2024-10-03 00:57:12 +00:00
Travis Nielsen 38d3d28dd9 helm: add enforce host network setting
The ROOK_ENFORCE_HOST_NETWORK option was implemented recently
and now we add the helm setting to expose this new setting
in the rook chart.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 810de394e7)
2024-10-02 22:04:58 +00:00
mergify[bot] 7058e048a1 Merge pull request #14794 from rook/mergify/bp/release-1.15/pr-14775
core: add ROOK_REVISION_HISTORY_LIMIT operator setting (backport #14775)
2024-10-02 20:40:25 +00:00
Michael Adam 1cb843acab helm: add revisionHistoryLimit setting
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 20f0031280)
2024-10-02 20:11:54 +00:00
Michael Adam d60966a626 core: add ROOK_REVISION_HISTORY_LIMIT operator setting
This adds an operator config setting ROOK_REVISION_HISTORY_LIMIT
defaulting to kubernetes'value for RevisionHistoryLimit.

If configured, the provided value will be used as RevisionHistoryLimit

for all Deployments rook creates.

Fixes: #12722

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit ab8fd90aa6)
2024-10-02 20:11:54 +00:00
mergify[bot] d815286186 Merge pull request #14788 from rook/mergify/bp/release-1.15/pr-14755
core: preserve pool application name change (backport #14755)
2024-10-01 17:28:33 +00:00
Travis Nielsen 8b02ae4f57 Merge pull request #14787 from rook/mergify/bp/release-1.15/pr-14782
csi: add sc privileged to logrotate sidecar container (backport #14782)
2024-10-01 11:11:06 -06:00
Santosh Pillai 771c165e69 core: preserve pool application name change
default application name is updated inside the `CreatePool` method. Send
pool spec as address in order to preserve this change.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
(cherry picked from commit 1a95d6f533)
2024-10-01 17:01:44 +00:00
parth-gr a65087b00b csi: add sc privileged to logrotate sidecar container
deployments on openshift where we need csi container pods
to be run on privileged, the logrotate sidecar container was missing the
privileged permission letting, side car to not run properly

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 21ca333ed7)
2024-10-01 15:56:18 +00:00
Travis Nielsen c69857f9be Merge pull request #14785 from rook/mergify/bp/release-1.15/pr-14752
docs: Declare cephconfig settings stable (backport #14752)
2024-10-01 08:29:53 -06:00
Travis Nielsen a33f180b56 docs: declare cephconfig settings stable
The cephConfig settings in the CephCluster CR have been
stable and there are no planned changes, so remove the
experimental documentation indicator. Also, clarify
the usage and the precedence of the ceph config
options.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 1c9727c271)
2024-09-30 20:26:58 +00:00
Travis Nielsen 6d6bff47a6 Merge pull request #14768 from rook/mergify/bp/release-1.15/pr-14748
build: support golang 1.23 (backport #14748)
2024-09-25 11:25:32 -06:00
Michael Adam e751697177 build: support golang 1.23
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 9ecd6a2500)
2024-09-25 16:16:53 +00:00
mergify[bot] 56c685cee5 Merge pull request #14762 from rook/mergify/bp/release-1.15/pr-14761
build: keep specific z version in go mod 1.22.5 (backport #14761)
2024-09-24 18:02:55 +00:00
subhamkrai 812c44e7f9 build: keep specific z version in go mod 1.22.5
let's keep specific z version in go.mod 1.22.5.

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit b818dd1c7d)
2024-09-24 11:07:27 -06:00
mergify[bot] 0ea35c9ee0 Merge pull request #14759 from rook/mergify/bp/release-1.15/pr-14746
csi: fix the ROOK_CSI_DISABLE_DRIVER flag in the csi reconcile  (backport #14746)
2024-09-24 13:03:32 +00:00
parth-gr 448f89c48c csi: fix the disable driver flag in the csi driver reconcile
ROOK_CSI_DISABLE_DRIVER was not working accurate
from https://github.com/rook/rook/pull/14489
The csi driver was installed even if its not
expected

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 166e4f35b2)
2024-09-23 16:20:57 +00:00
Travis Nielsen 51116fae20 Merge pull request #14749 from rook/mergify/bp/release-1.15/pr-14718
docs: update external docs with a better structure (backport #14718)
2024-09-20 09:40:38 -06:00
parth-gr 7f3cd3d884 docs: update external docs with a better structure
step1 to improve the external docs
and make it more clear to end user

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 467578d368)
2024-09-20 14:30:45 +00:00
mergify[bot] 570efbb09a Merge pull request #14745 from rook/mergify/bp/release-1.15/pr-14722
external: mds caps to healthchecker/cephfs users (backport #14722)
2024-09-20 06:42:06 +00:00
subhamkrai 690a4a629a external: mds caps to healthchecker/cephfs users
for cephfs fencing in external mode, we run command `ceph tell mds ***`
which requires user user to include cap mds allow * in permission. So,
we need to add this in healthchercker and cephfs provisioner user

Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit 32c5d99ef5)
2024-09-20 06:12:53 +00:00
Travis Nielsen ffe87031b6 Merge pull request #14744 from travisn/release-1.15.2
build: Update release version to v1.15.2
v1.15.2
2024-09-19 14:21:10 -06:00
Travis Nielsen d8f8ec9d43 build: update the release version to v1.15.2
For the patch release update the docs and examples
to v1.15.2

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-09-19 13:06:50 -06:00
Travis Nielsen 3eb17e28f2 Merge pull request #14712 from rook/mergify/bp/release-1.15/pr-14702
doc: add the pv encryption key rotation job (backport #14702)
2024-09-19 13:01:18 -06:00