Commit Graph
9626 Commits
Author SHA1 Message Date
Rakshith R f7c8cf3c93 ci: add test for key rotation
This commit adds test for key rotation.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit b9fc9a643e)
2023-03-08 16:37:34 +00:00
Rakshith R 2e6ae0a958 docs: add documentation for encryption key rotation
Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit 340dbe05b4)
2023-03-08 16:37:34 +00:00
Rakshith R 30692ca9c8 osd: add capability to reconcile key rotation cron jobs
This commits adds code to reconcile key rotation cron jobs.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit f39a32fcdb)
2023-03-08 16:37:33 +00:00
Rakshith R 65007124ab osd: add util function to create key rotation cron job
This commit adds util function to create key rotation cron job
such as getKeyRotationContainer, getKeyRotationCronPodTemplateSpec
and makeKeyRotationCronJob.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit ef38aea2a4)
2023-03-08 16:37:33 +00:00
Rakshith R 542906be28 osd: add rotate-key functionality to rook's key-management cmd
This commit adds functionality to be able to rotate
key encryption key of encrypted PVC backed OSDs.
Necessary changes such as adding update functionality
to kms and rbac changes are made as well.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit 71e011f731)
2023-03-08 16:37:32 +00:00
Rakshith R 801c81555b osd: add support for updating secret for default KMS
This commit adds support for updating secret for default KMS.
This is required for encryption key rotation.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit b41fdfbb62)
2023-03-08 16:37:32 +00:00
Rakshith R 2381bff45a osd: add util functions to support encryption key rotation
This commit adds util functions to support encryption key rotation
such as RemoveEncryptionKeySlot, AddEncryptionKey and
ensureEncryptionKey.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit 973723cbdd)
2023-03-08 16:37:32 +00:00
Rakshith R 198de5a76d core: add KeyRotationSpec to cephcluster CR
This commit adds KeyRotationSpec to cephcluster CR
to support encryption key rotation feature.
If enabled Rook will create a cronjob for each
encrypted PVC based OSD with given schedule set
to rotate their respective key encryption key.

Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit 46dd2eb5ff)
2023-03-08 16:37:31 +00:00
Travis Nielsen b2704316bd Merge pull request #11850 from travisn/release-1.11.1
build: Update release version to v1.11.1
v1.11.1
2023-03-07 15:44:36 -07:00
travisn 35b31f92aa build: update release version to v1.11.1
For the patch release the examples and docs are updated
to v1.11.1

Signed-off-by: travisn <tnielsen@redhat.com>
2023-03-07 15:07:28 -07:00
Travis Nielsen f6b3d53f5a Merge pull request #11849 from rook/mergify/bp/release-1.11/pr-11848
core: Add env var to exporter for ceph config (backport #11848)
2023-03-07 15:02:56 -07:00
Travis Nielsen 0640427e14 Merge pull request #11843 from rook/mergify/bp/release-1.11/pr-11842
monitoring: Remove alerts that don't apply to rook (backport #11842)
2023-03-07 14:37:18 -07:00
Travis Nielsen b264d9d34a Merge pull request #11847 from rook/mergify/bp/release-1.11/pr-11829
mgr: revert readiness probe and go back to the original sidecar HA implementation (backport #11829)
2023-03-07 14:36:27 -07:00
avanthakkar 6accfb6380 core: add env var to exporter for ceph config
The exporter requires the mon config and keyring.
Use the CEPH_ARGS env var to specify the config
instead of expecting a ceph.conf to be generated
by another component on the host path.

Co-Authored-By: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit b6013d9b11)
2023-03-07 21:22:17 +00:00
Redouane Kachach eaf09ad77a Revert "mgr: use k8s readiness probe to implement mgr HA"
This reverts commit dc76f81fea.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 0ae7867dd1)
2023-03-07 18:28:25 +00:00
Redouane Kachach 9a3e5c4e94 Revert "mgr: remove mgr sidecar"
This reverts commit ff75ec96b7.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 456a0c328c)
2023-03-07 18:28:25 +00:00
Redouane Kachach 4d56aca868 Revert "mgr: addressing review comments"
This reverts commit 9f37439a07.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit adc79d4ee4)
2023-03-07 18:28:24 +00:00
Redouane Kachach 580a9ec5c3 Revert "ci: fix MultiClusterDeploySuite CI"
This reverts commit b464428978.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 0c652d28e2)
2023-03-07 18:28:24 +00:00
Redouane Kachach f6fa004343 Revert "mgr: wait for the mgr pod to be running"
This reverts commit 4d1017f805.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit c31832095d)
2023-03-07 18:28:24 +00:00
travisn f3de021b55 monitoring: remove alerts that don't apply to rook
When the alerts were updated from the ceph repo, the cephadm
alerts were removed, now we also remove two other alerts that
don't apply to rook clusters. The pool growth warning alert
and prometheus job missing alerts need to be removed
as also seen in https://github.com/rook/rook/pull/10109.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit fd25eeecf1)
2023-03-06 23:34:31 +00:00
mergify[bot] 5864bf4e90 Merge pull request #11841 from rook/mergify/bp/release-1.11/pr-11822
Multi-cluster-mirroring CI test fix (backport #11822)
2023-03-06 21:39:37 +00:00
Travis Nielsen 3ddc7da267 Merge pull request #11830 from rook/mergify/bp/release-1.11/pr-11804
manifest: fix whitespace issues (backport #11804)
2023-03-06 14:27:24 -07:00
gauravsitlani 36ca16fce3 ci: fix fs multicluster mirroring
Signed-off-by: gauravsitlani <gauravsitlani@riseup.net>
(cherry picked from commit 88df0d8794)
2023-03-06 21:01:56 +00:00
Travis Nielsen b4d5ffbe3a Merge pull request #11838 from rook/mergify/bp/release-1.11/pr-11825
Fix documentation indentation (backport #11825)
2023-03-06 11:03:03 -07:00
AJ Schmidt 6c4507d7e4 docs: fix documentation indentation
It seems that this `deviceFilter` list item is indented too far.

This PR deindents it one level.

Signed-off-by: AJ Schmidt <ajs4392@gmail.com>
(cherry picked from commit da0ed4d21f)
2023-03-06 15:03:49 +00:00
gauravsitlani 5bea2695c8 manifest: fix whitespace issues
Signed-off-by: gauravsitlani <gauravsitlani@riseup.net>
(cherry picked from commit 75ec7bffc0)
2023-03-03 17:45:13 +00:00
Travis Nielsen d70d8ad608 Merge pull request #11813 from rook/mergify/bp/release-1.11/pr-11584
external: add realm support for external cluster (backport #11584)
2023-03-02 11:59:15 -07:00
Travis Nielsen 3250629791 Merge pull request #11816 from rook/mergify/bp/release-1.11/pr-11665
object: make OBC genUserID unique across clusters (backport #11665)
2023-03-02 11:57:52 -07:00
Travis Nielsen 4def787153 Merge pull request #11807 from rook/mergify/bp/release-1.11/pr-11797
ceph: add osd container ports only if mcs is enabled (backport #11797)
2023-03-02 11:56:37 -07:00
mergify[bot] c883571e83 Merge pull request #11824 from rook/mergify/bp/release-1.11/pr-11818
ci: Fix the multus integration test (backport #11818)
2023-03-02 16:28:40 +00:00
subhamkrai a0b696918d ci: fix multus ci
Signed-off-by: subhamkrai <srai@redhat.com>
(cherry picked from commit d983f3620e)
2023-03-02 15:52:49 +00:00
mergify[bot] d8111c9e28 Merge pull request #11812 from rook/mergify/bp/release-1.11/pr-11221
file: check if fs exists before checking dependencies (backport #11221)
2023-03-01 22:42:19 +00:00
Blaine Gardner 0ced2b6f84 object: make OBC genUserID unique across clusters
Rook's implementation of OBC's GenerateUserID could generate colliding
user IDs for multisite clusters where each site is configured with the
same namespace/name of CephObjectStore. Add the Ceph cluster FSID to the
generated name to ensure the names won't conflict for multiple sites.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
(cherry picked from commit 2733375ca4)
2023-03-01 22:29:44 +00:00
parth-gr 1344036419 external: add realm support for external cluster
if a cluster won't use the deafult realm and try to
execute the python script it will fail to vaildate rgw
as the rgw-admin-user would be created on default realm
So creating user in specific realm if the realm name is passed

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 96ea7817f8)
2023-03-01 19:43:40 +00:00
zhucan 6f36d10a12 file: check if fs exists before checking dependencies
Signed-off-by: zhucan <zhucan.k8s@gmail.com>
(cherry picked from commit 46c2bef9bc)
2023-03-01 19:18:26 +00:00
mergify[bot] e34b77fa86 Merge pull request #11810 from rook/mergify/bp/release-1.11/pr-11808
docs: change old version hint in docs (backport #11808)
2023-03-01 17:43:44 +00:00
Alexander Trost ed2c6e3255 docs: change old version hint in docs
Resolves https://github.com/rook/rook.github.io/issues/144

Signed-off-by: Alexander Trost <galexrt@googlemail.com>
(cherry picked from commit a5131d7309)
2023-03-01 17:06:08 +00:00
sp98 5cb72de8d0 osd: add container ports only if mcs is enabled
Add container ports for OSD container only when multi cluster service is
enabled in the cluster spec.

Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit 12bbc9b1a8)
2023-03-01 16:30:18 +00:00
Travis Nielsen 5a1136c4cb Merge pull request #11794 from rook/mergify/bp/release-1.11/pr-11760
core: on crash pod ensure rook version label is not set (backport #11760)
2023-02-28 11:59:23 -07:00
Ben Gao 0cccf48a1f core: on crash pod ensure rook version label is not set
ceph crash pod gets rook version label added unintentionally, which is only for deployment label.
changes include:
1, make a copy of the labels for pod spec from deployment labels just before adding rook version label.
2, add unit test to make sure it works as designed.
This fix along with pr 11674 is to stop ceph daemons pod restarting unnecessarily after upgrading rook operator.

Signed-off-by: Ben Gao <bengao168@msn.com>
(cherry picked from commit ed6ed25257)
2023-02-28 18:25:38 +00:00
Travis Nielsen 4f465e7786 Merge pull request #11781 from travisn/release-1.11.0
build: Set the release version to v1.11.0
v1.11.0
2023-02-27 17:49:14 -07:00
travisn dc4995f090 build: set the release version to v1.11.0
For the new minor rook release we set the examples and documentation
to v1.11.0

Signed-off-by: travisn <tnielsen@redhat.com>
2023-02-27 16:37:21 -07:00
Travis Nielsen 19dd7a29ba Merge pull request #11779 from rook/mergify/bp/release-1.11/pr-11778
ci: Enable snyk flag not to build vcs (backport #11778)
2023-02-27 16:18:56 -07:00
travisn 0f51a42711 ci: enable snyk flag not to build vcs
The snyk check is failing because the -buildvcs flag
is defaulting to true. Let's disable this flag to
get the check passing.

Signed-off-by: travisn <tnielsen@redhat.com>
(cherry picked from commit 9197966ed4)
2023-02-27 23:16:43 +00:00
Travis Nielsen 46f1cf3325 Merge pull request #11776 from rook/mergify/bp/release-1.11/pr-11772
doc: use kubectl replace instead of apply for crd updates (backport #11772)
2023-02-27 15:28:21 -07:00
Blaine Gardner b0b02e8ba0 docs: use kubectl replace instead of apply for crd updates
'kubectl apply --server-side' still doesn't always update CRDs
correctly if a CRD is too big to have its last applied annotation. Use
'kubectl replace' instead.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
(cherry picked from commit 38f896ea30)
2023-02-27 22:04:18 +00:00
Travis Nielsen ef647485b4 Merge pull request #11774 from rook/mergify/bp/release-1.11/pr-11567
osd: handle device name change and device removel correctly (backport #11567)
2023-02-27 12:33:59 -07:00
Satoru Takeuchi 0e4103a51c osd: handle device name change and device removel correctly
If a kernel device name change happens and a block device file
in the OSD directory becomes dangling link, this OSD fails
to start continuously. This problem can be resolved by confirming
the validity of the device file and recreating it if necessary.

The original problem happened in host-based clusters. A similar
problem exists in PVC-based clusters. In this case, if a PV,
corresponds to an existing OSD, and points to a missing block
device file, the OSD pod fails to consume this PV. Although this
behavior is undesirable, I don't think this problem should be
handled in Rook. If doing so, we must re-create the existing PV.
Rook shouldn't do such work.

Closes: https://github.com/rook/rook/issues/10860

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
(cherry picked from commit 3a44a394b5)
2023-02-27 18:55:21 +00:00
Travis Nielsen dd227e6cf5 Merge pull request #11771 from rook/mergify/bp/release-1.11/pr-11578
Support multi cluster service (backport #11578)
2023-02-27 11:38:52 -07:00
sp98 c69c5a16fd core: export mon and OSD services
Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit 7292ac5927)
2023-02-27 10:23:43 -07:00