Commit Graph
11660 Commits
Author SHA1 Message Date
Travis Nielsen fb02f500be Merge pull request #14962 from travisn/ci-latest-squid
ci: Default to the latest stable squid instead of devel
2024-11-04 15:36:59 -07:00
Travis Nielsen b229240faa ci: default to the latest stable squid instead of devel
The devel images have been fairly stable for Rook to test
against, but on occasion there are regressions from
Ceph development that affect the Rook CI. For stability during
Rook development, use the latest stable version of ceph for
PRs, master, and release tests. The daily CI will still use
the devel images from Ceph.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-11-04 14:10:36 -07:00
Travis Nielsen 0b666c0a3f Merge pull request #14952 from travisn/fs-standby-update
mds: Wait for mds standby upgrade for same fs
2024-11-04 10:40:00 -07:00
Travis Nielsen 13495aea5a Merge pull request #14941 from travisn/detect-version-resources
core: Set resources on the detect version job
2024-11-04 10:14:38 -07:00
Travis Nielsen bebe5bd402 Merge pull request #14949 from travisn/schedule-all-nodes
osd: Allow scheduling on unschedulable nodes
2024-11-01 14:17:43 -06:00
Travis Nielsen 99d60c5bba mds: wait for mds standby upgrade for same fs
The upgrade of the mds daemons pauses to wait for the
stopping of standby daemons before the filesystem upgrade
is completed. If there are multiple filesystems, there
could be standbys for other filesystems that will not be
stopped at the time of the upgrade of another filesystem.
Thus, the standbys may not upgrade and be stuck on the
previous version. Now, the standby upgrade will only wait
for standbys for the same filesystem.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-11-01 14:03:13 -06:00
Travis Nielsen 18c9261d0b Merge pull request #14943 from travisn/obsolete-object-test
test: Remove obsolete object user test flag
2024-11-01 07:21:04 -06:00
Travis Nielsen 98638de22d Merge pull request #14936 from cybozu-go/doc-take-multicluster-into-account-for-datadirhostpath
doc: clarify dataDirHostPath must be unique for each cluster
2024-10-31 17:16:28 -06:00
Satoru Takeuchi 62d99330d6 doc: clarify dataDirHostPath must be unique for each cluster
If there are multiple clusters, `dataDirHostPath` must be unique
for each cluster. However, it's not documented yet.
In addition, `ceph-teardown.md` was also updated because
the original document assumes that `dataDirHostPath` is
`/var/lib/rook` and the files for a cluster `rook-ceph` is
under `/var/lib/rook/rook-ceph`.

related issue:
https://github.com/rook/rook/issues/14790

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2024-10-31 22:15:17 +00:00
Travis Nielsen f489f99e13 core: set resources on the cmd reporter jobs
If the cmd-reporter key is set under the resources
element in the CephCluster CR, the memory and cpu request
and limits will be set on the ceph detect version job
and network job accordingly.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-31 14:52:57 -06:00
Travis Nielsen 7fbe4e7db5 osd: allow scheduling on unschedulable nodes
For nodes that are explicitly requested for deploying
OSDs, they will be skipped temporarily if not
schedulable or not ready. A future reconcile is
expected to schedule them. Allow the OSDs to be
scheduled even on these nodes that are temporarily
down, even if it blocks the reconcile from completing.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-31 14:05:36 -06:00
Travis Nielsen 0ae1916312 Merge pull request #14944 from cybozu-go/test-avoidalways--running-tmate-session
doc: avoid always enabling tmate session
2024-10-31 08:06:40 -06:00
Travis Nielsen d725b31e59 Merge pull request #14942 from travisn/no-csi-version-check
csi: Remove version check for k8s and cephcsi
2024-10-31 07:31:37 -06:00
Satoru Takeuchi 47ca3fd245 doc: avoid always enabling tmate session
tmate session is always enabled by mistake. This bug is
introduced in the following PR.

https://github.com/rook/rook/pull/14934

We should enable this if `inputs.debug-ci` is `true`.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2024-10-31 06:00:49 +00:00
Travis Nielsen f60f4443df test: remove obsolete object user test flag
In Rook v1.6 some new properties were added for
ceph object store users, so the CI was skipping
validation of that setting in the upgrade test.
Now we are far past the need for that flag, and we
can assume the latest flags exist for the tests.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-30 15:03:24 -06:00
Travis Nielsen 2ff429e479 csi: remove version check for k8s and cephcsi
The version checks for the csi driver are removed now
since they are all obsolete. The K8s version and cephcsi
versions are no longer checked. Anyway, the move to the
csi operator would take ownership of version checks
needed in the future, so for now we simplify rook
deployment of the csi driver.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-30 14:03:51 -06:00
Blaine Gardner 4e8d4dee41 Merge pull request #14934 from cybozu-go/make-debug-ci-label-work-again
test: make debug-ci label work again
2024-10-30 11:25:11 -06:00
Blaine Gardner c01741260e Merge pull request #14922 from obnoxxx/make-generate-systematic
Make generating make targets more  systematic
2024-10-30 10:58:25 -06:00
Michael AdamandBlaine Gardner 04741fb899 build: make generating make targets more systematic
This addresses a suggestion from a review comment in another PR.

The goal of this change is to make generating make targets more systematic.

Firstly, generating targets are made available under a more systematic naming
 following the pattern of "gen.foo".
more concretely, the following targets are introduced as aliases of the corresponding existing
 targets:

* gen.codegen
* gen.rbac
* gen.crds
* gen.docs
* gen.crd-docs

additionally, a  new "generate" make target is added that invokes all generating targets.

Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
Signed-off-by: Michael Adam <obnox@samba.org>
2024-10-30 12:11:01 +01:00
Satoru Takeuchi 448f42ab12 test: make debug-ci label work again
cmoposite workflow can't use `github` variable.

close: https://github.com/rook/rook/issues/14898

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2024-10-30 01:44:07 +00:00
Travis Nielsen 45e05ee09f Merge pull request #14921 from rook/dependabot/go_modules/k8s-dependencies-e3707453b0
build(deps): bump the k8s-dependencies group with 7 updates
2024-10-29 13:16:22 -06:00
dependabot[bot] 8382c084e4 build(deps): bump the k8s-dependencies group with 7 updates
Bumps the k8s-dependencies group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.31.1` | `0.31.2` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.31.1` | `0.31.2` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.31.1` | `0.31.2` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.31.1` | `0.31.2` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.31.1` | `0.31.2` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.31.1` | `0.31.2` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.19.0` | `0.19.1` |

Updates `k8s.io/api` from 0.31.1 to 0.31.2
- [Commits](https://github.com/kubernetes/api/compare/v0.31.1...v0.31.2)

Updates `k8s.io/apiextensions-apiserver` from 0.31.1 to 0.31.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.31.1...v0.31.2)

Updates `k8s.io/apimachinery` from 0.31.1 to 0.31.2
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.31.1...v0.31.2)

Updates `k8s.io/cli-runtime` from 0.31.1 to 0.31.2
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.31.1...v0.31.2)

Updates `k8s.io/client-go` from 0.31.1 to 0.31.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.31.1...v0.31.2)

Updates `k8s.io/cloud-provider` from 0.31.1 to 0.31.2
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.31.1...v0.31.2)

Updates `sigs.k8s.io/controller-runtime` from 0.19.0 to 0.19.1
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.19.0...v0.19.1)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-29 12:30:37 -06:00
subham rai e78a4832de Merge pull request #14918 from rook/dependabot/github_actions/github/codeql-action-3.27.0
build(deps): bump github/codeql-action from 3.26.13 to 3.27.0
2024-10-29 21:15:45 +05:30
Travis Nielsen ac2c5cb0a2 Merge pull request #14913 from travisn/roadmap-1.16
doc: Update the tentative roadmap for the 1.16 release
2024-10-29 07:41:01 -06:00
Travis Nielsen 6021f70a59 Merge pull request #14928 from parth-gr/external-doc-fix1
docs: fix external doc broken links
2024-10-29 07:40:02 -06:00
parth-gr d061382661 docs: fix external doc broken links
some of the links have the full path
which is not working in the doc server,
but works locally

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-10-29 17:33:35 +05:30
subham rai 3eef446b14 Merge pull request #14917 from rook/dependabot/github_actions/actions/setup-python-5.3.0
build(deps): bump actions/setup-python from 5.2.0 to 5.3.0
2024-10-29 13:11:09 +05:30
subham rai 2c41e22f80 Merge pull request #14916 from rook/dependabot/github_actions/actions/checkout-4.2.2
build(deps): bump actions/checkout from 4.2.1 to 4.2.2
2024-10-29 13:10:46 +05:30
subham rai 01a7d62747 Merge pull request #14919 from rook/dependabot/github_actions/actions/setup-go-5.1.0
build(deps): bump actions/setup-go from 5.0.2 to 5.1.0
2024-10-29 13:10:24 +05:30
Travis Nielsen be53292e51 Merge pull request #14910 from cybozu-go/test-specify-ceph-image-correctly
test: specify ceph image correctly
2024-10-28 12:59:57 -06:00
Travis Nielsen 280cb922ab doc: update the roadmap for the 1.16 release
The roadmap doc is now updated for v1.16 with potential
features and fixes we hope to include.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-28 11:14:54 -06:00
dependabot[bot] 6f4ad530e0 build(deps): bump actions/setup-go from 5.0.2 to 5.1.0
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.2 to 5.1.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32...41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-28 12:35:50 +00:00
dependabot[bot] f1cd919564 build(deps): bump github/codeql-action from 3.26.13 to 3.27.0
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.13 to 3.27.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/f779452ac5af1c261dce0346a8f964149f49322b...662472033e021d55d94146f66f6058822b0b39fd)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-28 12:35:43 +00:00
dependabot[bot] 56752e5890 build(deps): bump actions/setup-python from 5.2.0 to 5.3.0
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/f677139bbe7f9c59b41e40162b753c062f5d49a3...0b93645e9fea7318ecaed2b359559ac225c90a2b)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-28 12:35:31 +00:00
dependabot[bot] 734da26d89 build(deps): bump actions/checkout from 4.2.1 to 4.2.2
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871...11bd71901bbe5b1630ceea73d27597364c9af683)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-28 12:35:26 +00:00
Blaine Gardner 4c812f573b Merge pull request #14835 from BlaineEXE/rgw-use-system-certs-for-tls
object: also use system certs for validating RGW cert
2024-10-25 11:57:26 -06:00
Blaine Gardner 7bb72a0171 object: also use system certs for validating RGW cert
When generating the HTTP client used for RGW admin ops, use both system
certs as well as the user-given cert.

As a real world example, admins may use ACME to rotate Letsencrypt certs
every 2 months. For an external CephObjectStore, the cert used by Rook
and RGW may not be rotated at the same time. This can cause the Rook
operator to fail CephObjectStore reconciliation until both certs agree.

When Rook also relies on system certs in the container, Rook's
reconciliation will not have reconciliation failures because
Letsencrypt's well-known and trusted root certificates can be loaded
from the system to validate the RGW's newly-rotated cert.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-10-25 11:22:11 -06:00
Blaine Gardner c7dfe7837e Merge pull request #14884 from cobaltcore-dev/rgw-default-placement
rgw: support custom name for default pool placement
2024-10-25 10:30:58 -06:00
Travis Nielsen 48c7661c1f Merge pull request #14906 from travisn/test-wait-for-mon-daemon
test: Wait for mon daemons rather than mon canaries
2024-10-25 09:58:22 -06:00
Travis Nielsen b52ba6baca test: wait for mon daemons rather than mon canaries
The mon canaries may be created even when the mon daemons
are not created thereafter during the integration tests.
Therefore, the integration tests need to also query a label
specific to the mon daemon so the canaries are not a distraction
to the test.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2024-10-25 09:17:02 -06:00
Satoru Takeuchi 36721edae8 test: specify ceph image correctly
`encryption-pvc-kms-ibm-kp` workflow replaces the name of ceph-image.
Since the dest value is always empty by mistake, this workflow
always fails.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2024-10-25 11:50:56 +00:00
Artem Torubarov b47dff9770 rgw: support custom name for default pool placement
introduce Default flag to CRD

Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
2024-10-25 12:52:06 +02:00
Satoru Takeuchi f50734962b Merge pull request #14901 from guits/add-udev-bindmount
osd: mount /run/udev in the init container for ceph-volume activate
2024-10-25 16:18:08 +09:00
Travis Nielsen 3b94c50d8b Merge pull request #14818 from iPraveenParihar/kms/vault-keyrotation
kms: key rotation support for vault kms
2024-10-24 11:38:33 -06:00
Blaine Gardner 7a4cf8d93c Merge pull request #14819 from BlaineEXE/holder-pods-remove-config
multus: finish deprecating holder pods
2024-10-24 10:55:02 -06:00
Travis Nielsen 58df41e0cf Merge pull request #14895 from Madhu-1/cleanup-block
core: Cleanup blockpool with annotation
2024-10-24 10:28:31 -06:00
Guillaume Abrioux dbcd0d46dd osd: mount /run/udev in the init container for ceph-volume activate
The /run/udev directory is now mounted in the OSD init container. This change
is necessary because `ceph-volume activate` needs access to /run/udev [1] in order
to properly handle devices. Without this mount, `ceph-volume activate` could
fail to discover devices during OSD initialization.

[1] https://github.com/ceph/ceph/commit/c2e8c295dc46f1bd74861feb163d9d82f8bb5509

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2024-10-24 17:16:10 +02:00
Blaine Gardner 8491c427f1 Merge pull request #14834 from jhoblitt/feature/obc-bucket-quota
object: add bucketMaxObjects & bucketMaxSize to obc
2024-10-23 16:42:21 -06:00
Blaine Gardner 5539eedd1b multus: finish deprecating holder pods
Finish the process of deprecating holder pods by removing Rook's ability
to deploy them. The intent of this change is to make the most
superficial changes possible to accomplish this. There are still
remnants of code in Rook (particularly the CSI controller) that helped
configure or deploy holder pods. Due to the risk of breaking some
features, cleanup work of hose remnants will be deferred for future
work.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-10-23 16:29:02 -06:00
Joshua Hoblitt f64027bf43 test: add obc bucketMaxObjects integration test
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2024-10-23 14:39:38 -07:00