The csi version is no longer checked by Rook. If the user
changes the default csi version, it's their responsibility
to ensure it is updated according to the upgrade guide,
we just don't officially have a min version anymore.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 26ff895f0a)
In the unit test that ensures `rgwCommandFlags` works properly, ignore
the ordering of the flags. Golang maps are used underneath, which
results in random flag ordering. This is fine as long as the
`rgwCommandFlags` are still guaranteed to be appended to the args Rook
normally applies.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 37c3cc9fba)
Add a sample to the CephObjectStore Advanced configuration section which
shows how the new `rgwConfig` option can be used with the
`additionalVolumeMounts` setting.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit c845d36b20)
Use testify/assert.Equal() to compare maps. Comparing string
representations of maps is supposed to be stable but is flaking in GH
actions CI.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 92c95fcc16)
the rgw operations for s3 can now be accessible using sidecar
rgw-ops-log availabe in json form that can be further filtered logging
for observability, this will set the rgw_enable_ops_log setting
Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
(cherry picked from commit c5d27467d6)
The docker.io/rook/ceph image contains vulnerabilities in the s5cmd binary.
A new version of s5cmd was released on 16th December which resolves these issues.
Signed-off-by: TomHellier <me@tomhellier.com>
(cherry picked from commit a87843de62)
update CephObjecStore examples to set bulk=true for data pools by default
Signed-off-by: Artem Torubarov <artem.torubarov@clyso.com>
(cherry picked from commit e3c3aafe09)
Implement #15119
Allow users to override RGW configurations by specifying Ceph config
options in the CephObjectStore. For configurations that require RGW to
be restarted when the config is applied, allow configs to be specified
as CLI arguments to the RGW as well.
This is an advanced option and is documented as such. Users should be
careful to understand the values they are setting, as there is no
validation to prevent the object store from breaking when these configs
are used.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit aaa16488de)
With the updated dependencies, the csi unit tests
require new default fields in the comparison of the
json test blob.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 2fdf173ddf)
Fix the issue when using with external ceph cluster, ceph exporter
secret isn't created which cause ceph-exporter fail to run. By
default this option is false means ceph-exporter will run for
external cluster.
monitoring
metricsDisabled: false
This patch also adds metricsDisabled option to helm values.yaml.
fixes#14275
Signed-off-by: Yaguang Tang <heut20008@gmail.com>
(cherry picked from commit 1563d32fbb)
This change refactors inline roundup code to a function
roundup_size_MiB that takes a size(in bytes) as argument and returns
the smallest number of Mibibytes larger than or equal to the given size.
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 26b4fb06d5)
The ci was using a pretty old version og golangci-lint.
This updates to the latest version.
Additionally, it silences some
gosec integer conversion overflow false positves
and fixes some real errors of this category
and string format errors found by golangci-lint, while at it.
Co-authored-by: Blaine Gardner <b.blaine.gardner@gmail.com>
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit df511fb58f)
To allow the caller to pass in their own transport when testing.
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 57b7eeec80)
Add a s3Agent field to bucket.Provisioner struct as a step towards
allowing the s3Agent / s3 client to be mocked in unit tests.
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit e5f79dba7f)
With the release of K8s 1.32, we update the CI and docs
to support this new release, to maintain the most recent
six releases of K8s.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 7c2f41e72e)
With the v19.2.0 release being out for some time now,
update the default version to be deployed with Rook
as v19.2.0.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 07d8012d36)
cephcsi 3.13.0 is released today and
update the Rook to use the latest image
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 07f5700a87)
This reverts commit a941b3c33f.
Stop creating the 'cosi' user in the CephObjectStore reconcile. This
step often fails for some amount of time during initial object store
creation, causing frequent user concern. It has also been the source of
some reported failures that would otherwise be non-breaking for certain
users.
Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit fc08e87d44)
Ceph has changed the image build process to only require a
dockerfile and stop using the ceph-container repo. The
daily images are pushed to the quay.io/ceph-ci/ceph repo,
so the Rook CI will now start using those images.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 85375bf073)
The dashboard admin rgw user has timing isssues in the CI.
For now, just suppress the CI failure and log the error
until we can spend more time to get a reliable wait for the
user creation.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 23f3db1261)
subham rai
Travis Nielsen
Blaine Gardner
Deepika Upadhyay
TomHellier
Artem Torubarov
Michael Adam
Yaguang Tang
Silvio Ankermann
Joshua Hoblitt
mergify[bot]
Madhu Rajanna