Commit Graph
5293 Commits
Author SHA1 Message Date
Sébastien Han fd57eff0f8 Merge pull request #5906 from subhamkrai/gosec-CI
ci: adding gosec tool in ci
2020-07-30 10:21:02 +02:00
subhamkrai 22216899b9 ci: adding gosec tool in ci
this commit will add gosec check in ci
and it will help us increase code quality.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-30 13:36:17 +05:30
Sébastien Han 44355a921b Merge pull request #5920 from binoue/fix-log-output
ci: fix log output
2020-07-30 08:59:12 +02:00
Sébastien Han ef434e8f68 Merge pull request #5913 from Madhu-1/csi-del
ceph: update clusterrole of operator for csidrivers
2020-07-30 08:42:58 +02:00
Travis Nielsen 034d128623 Merge pull request #5923 from subhamkrai/allgosec-error
ceph: handling all the gosec errors
2020-07-29 23:31:23 -06:00
subhamkrai 0279025e9e ceph: handling all the gosec errors
a few of the gosec errors were left. so
this commit will resolve all the errors.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-30 08:19:55 +05:30
binoue bb224733f6 ceph: fix log output
fix log output

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
2020-07-30 07:26:20 +09:00
Travis Nielsen 4bc2cf1dc1 Merge pull request #5925 from nixpanic/ceph/POOL_NO_REDUNDANCY
ceph: do not warn about no redundancy in test cluster
2020-07-29 13:35:32 -06:00
Niels de Vos bb2b4096d1 ceph: do not warn about no redundancy in test cluster
In test environments the default pool size is set to 1, so there is no
redundancy. This causes recent Ceph versions to complain with
HEALTH_WARN as POOL_NO_REDUNDANCY get set.

By disabling the mon_warn_on_pool_no_redundancy option in ceph.conf, the
warning is not reported and the cluster is marked HEALTHY.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-07-29 13:25:12 -06:00
Travis Nielsen eec88e79b0 Merge pull request #5917 from travisn/enable-1.4-backport-bot
ci: Enable 1.4 backport bot
2020-07-29 11:25:53 -06:00
Travis Nielsen 6302b54c27 ci: add mergify backport target for release-1.4
With the v1.4 release we will need mergify to support
the automatic backports based on the PR label.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-07-29 10:03:55 -06:00
Travis Nielsen 4abaaf083c ci: remove 1.1 backport target
There is no longer a need to support backports to v1.1,
so removing the mergify rule.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-07-29 09:55:28 -06:00
Sébastien Han f4ca7127d4 Merge pull request #5919 from cybozu-go/fix-chart
ceph: remove duplicated lines from Helm chart
2020-07-29 17:33:23 +02:00
Sébastien Han a3d30edb64 Merge pull request #5916 from travisn/reduce-stale-pr-timeout
ci: Reduce the PR stale time to 90 days
2020-07-29 09:15:08 +02:00
Madhu Rajanna 28f0471106 ceph: update clusterrole of operator for csidrivers
updated the clusterrole of the rook operator
to delete the csidrivers object when csi-drivers
are disabled, without the required access rook operator
cannot delete the csidrivers object.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-07-29 09:41:26 +05:30
Travis Nielsen fd29a8691e Merge pull request #4868 from nizamial09/file_permission
rook: Changing the file and directory permissions to most narrow poss…
2020-07-28 21:45:12 -06:00
Masayuki Ishii e89a1f1738 ceph: remove duplicated lines from Helm chart
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
2020-07-29 00:17:48 +00:00
Travis Nielsen 998b3f29ea ceph: reduce the file permissions to fix gosec errors
File permissions need to be reduced to the minimum to avoid config
files from being accessed. While a connection to the pod would be
required to access the files, min privileges are set just as
another layer of security. This fixes gosec error G306.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-07-28 15:46:24 -06:00
Nizamudeen 041618dacb ceph: change the file and directory permissions to most narrow possible
This commit fixes where there are areas in which files and directories are
written and created with statically defined permissions. Many of these
permissions are rather open, potentially allowing other system tenants to
view and interact with their contents, which may be sensitive.

Fixed G303: Poor file permissions used for directory by using the most narrow permission

Resoves: https://github.com/rook/rook/issues/4580

Signed-off-by: Nizamudeen <nia@redhat.com>
2020-07-28 15:46:12 -06:00
Travis Nielsen 785e866dd2 ci: reduce the PR stale time to 90 days
The stalebot has not been closing PRs that are stale.
Reducing the timeout from 6 months to 3 months.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-07-28 15:31:15 -06:00
Travis Nielsen da142be079 Merge pull request #5894 from subhamkrai/gosec-error-G104
ceph: handling gosec errors code g104  and g404
v1.4.0-alpha.0
2020-07-28 14:35:59 -06:00
subhamkrai de8e93274d ceph: handling gosec errors code g104
this commit handles all the gosec g104
(i.e Audit errors not checked) error.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-28 23:52:23 +05:30
Travis Nielsen 704e80d1b5 Merge pull request #5912 from rohantmp/rohantmp-patch-1
Core: Add comment warning to keep k8sutil hashing consistent for name…
2020-07-28 10:41:47 -06:00
Travis Nielsen 1ee29b9c63 Merge pull request #5895 from subhamkrai/nosec-error
ceph: suppress gosec errors for g204,g304,g101
2020-07-28 08:25:58 -06:00
Travis Nielsen 9e6429b4c8 Merge pull request #5893 from subhamkrai/gosec-error-G601
ceph: handling gosec error code g601
2020-07-28 08:25:00 -06:00
Travis Nielsen f6b7aac3b6 Merge pull request #5908 from leseb/split-osd-files
ceph: split osd code in files
2020-07-28 07:37:46 -06:00
Rohan Joseph 82b062f91d core: add comment warning to keep k8sutil hashing consistent
The name generation utils need to provide consistent outputs across
versions so that names generated based on values are consistent and
older generated keys are not lost.

Signed-off-by: Rohan CJ <rohantmp@gmail.com>
2020-07-28 12:51:54 +05:30
Sébastien Han c2db463eb2 Merge pull request #5907 from aruniiird/rgw_endpoint_validations_optional
ceph: make 'rgw_endpoint' check/validation also optional
2020-07-28 08:42:52 +02:00
subhamkrai 465a0f0aec ceph: handling gosec error code g601
this commit handles all the gosec g601
error code (i.e Implicit memory aliasing
of items from a range statement).

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-28 11:34:49 +05:30
subhamkrai bcd7faed4e ceph: suppress gosec errors for g204, g304, g101
this commit suppress the gosec errors for

g204: Audit use of command execution.
g304: File path provided as taint input.
g101: Look for hard coded credentials.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-07-28 11:10:48 +05:30
Sébastien Han 71dff530d3 ceph: split osd code in files
Makes the code more readable and decoupled into files.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-07-27 23:21:14 +02:00
Travis Nielsen 22ba4591f3 Merge pull request #5888 from Madhu-1/csi-v3.0.0
ceph: update ceph-csi to v3.0.0 release
2020-07-27 14:05:29 -06:00
Arun Kumar Mohan 59a3be6d75 ceph: make 'rgw_endpoint' check/validation also optional
As 'rgw_endpoint' argument itself is optional, making it's check / validation also optional

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-07-27 22:31:31 +05:30
Madhu Rajanna 0204bac9d1 ceph: add documentation for rbd volume cloning
added new documentation for rbd volume cloning

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-07-27 20:51:42 +05:30
Madhu Rajanna 2c524550f3 ceph: move rbd snapshot to new document
moved the rbd snapshot content to a new
document.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-07-27 20:51:38 +05:30
Sébastien Han d5aee01ee3 Merge pull request #5901 from leseb/validate-prefix-rgw-pool
ceph: validate pools with prefix
2020-07-27 17:19:45 +02:00
Travis Nielsen d6b81c9151 Merge pull request #5899 from leseb/optinal-rgw
ceph: make rgw option on external script
2020-07-27 09:10:15 -06:00
Sébastien Han c964998fa3 Merge pull request #5903 from anmolsachan/telemeter
Added rules for PVC requested and used capacity for telemeter and updated PV count query
2020-07-27 17:01:46 +02:00
Anmol Sachan a42616967d ceph: updated the PV count query for telemeter
Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
2020-07-27 20:18:13 +05:30
Anmol Sachan f3eea6ebb7 ceph: added rules for PVC requested and used capacity for telemeter
This commit adds recording rules to monitor aggregated (requested and used) capacity of the PVCs for block and file type PVCs, via the telemeter.

Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
2020-07-27 20:16:12 +05:30
Sébastien Han 5d02a29d76 Merge pull request #5900 from leseb/monitoring-rules-v15
ceph: add monitoring rules for octopus
2020-07-27 15:29:09 +02:00
Sébastien Han f5e77a2486 Merge pull request #5890 from hookak/patch-1
[skip ci] Docs: update OSD_DATA_DIR path in script
2020-07-27 15:04:55 +02:00
Sébastien Han cc9c9814d2 Merge pull request #5892 from travisn/gosec-errors
Suppress gosec errors for closing files
2020-07-27 15:04:07 +02:00
Sébastien Han b35c065db5 ceph: validate pools with prefix
Now the rgw pool with a given prefix will also be checked by the script.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-07-27 14:55:08 +02:00
Sébastien Han 44cd526fff Merge pull request #5883 from leseb/rm-sc-external
ceph: remove storageclass-bucket-retain-external.yaml
2020-07-27 11:50:58 +02:00
Sébastien Han 11df9994b5 Merge pull request #5891 from travisn/codegen-sync
ceph: Update codegen for recent changes
2020-07-27 11:38:06 +02:00
Sébastien Han 6a643e9522 ceph: add monitoring rules for octopus
Add monitoring rules for octopus clusters.

Closes: https://github.com/rook/rook/issues/5897
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-07-27 10:16:49 +02:00
Madhu Rajanna 6aef231896 ceph: add pvc-clone.yaml for rbd
added pvc-clone.yaml for rbd pvc volume
cloning.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-07-27 13:46:39 +05:30
Madhu Rajanna cc3b4e6906 ceph: remove check for kubernetes version
as we are going to deploy snapshotter by
default we are going to remove the kubernetes
version check.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-07-27 13:45:56 +05:30
Madhu Rajanna 4a1198ee12 ceph: add RBAC for alpha snapshot
Added back the required RBAC to support
snapshot  Alpha version.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-07-27 13:42:32 +05:30