Commit Graph
10802 Commits
Author SHA1 Message Date
Blaine Gardner feacb6424e ci: fix detection of GH actions extra disk
The 'extra' block device attached to GH actions runners has changed size
twice in 3 months. The previous strategy of detecting the disk by size
is becoming harder to maintain. Additionally, the block size with recent
changes (75G) is now the same as the boot device (also 75G), making the
method inexact.

The method can now be summarized as, "find the boot disk and choose the
disk that isn't the boot disk to be the 'extra' one used."

Prior to this, we used a one-liner based on `lsblk`. While we could
still make this a one-liner, the method is now updated to 2 effective
lines, plus debug text output to stderr to help if we need to debug
further in the future.

Of note, the 'extra' disk has a mount point of "/mnt", but it is unclear
whether this is a reliable heuristic for detecting the extra disk. For
years now, GH action runners have had only 2 disks. Therefore, it seems
slightly more likely that a heuristic to "choose the non-boot disk" will
be a more robust long-term solution.

If this strategy proves to be unreliable in the future, it may be wise
to consider whether "the device with a partition mounted to '/mnt'"
would be a good alternative.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-02-05 17:55:16 -07:00
Travis Nielsen 577c7cc636 Merge pull request #13675 from subhamkrai/ci-fix-disk-size
ci: disk in github action increased to 75G from 64G
2024-02-05 10:28:59 -07:00
subhamkraiandJan Klippel 6b0deb32d9 ci: disk in github action increased to 75G from 64G
the disk size in the github action machine has
increased from 64G to 75G. Now, we detech the version
automatically not fetching hard coded value.

Co-authored-by: Jan Klippel <jan.klippel@uhurutec.com>
Signed-off-by: subhamkrai <srai@redhat.com>
2024-02-05 22:24:03 +05:30
Travis Nielsen 7f7e8d44fa Merge pull request #13623 from thotz/ceph-cosi-driver-name-namespace-check
object: add check specific to name and namespace for ceph cosi driver
2024-02-05 09:01:18 -07:00
Travis Nielsen 73427c9091 Merge pull request #13615 from riya-singhal31/node-name
csi: update network fence CR name
2024-02-05 07:10:49 -07:00
Santosh Pillai f5fcf96e04 Merge pull request #13652 from travisn/cm-skip-reconcile
core: Skip reconcile if override configmap is empty
2024-02-05 12:43:07 +05:30
travisn 0240ee8563 core: skip reconcile if override configmap is empty
If the configmap rook-config-override is empty,
there is no need to trigger the reconcile to update
the ceph daemons. This configmap update is causing
unnecessary reconciles periodically in some clusters
even when it is empty.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-02-01 14:29:20 -07:00
Blaine Gardner 21a99f33b2 Merge pull request #13670 from BlaineEXE/ci-add-gofmt-check
ci: check for gofmt usage in golangci-lint
2024-02-01 12:12:06 -07:00
Blaine Gardner c98ce0a56b ci: check for gofmt usage in golangci-lint
This is needed because not all contributors may be using gomft to format
source code, and this could result in inconsistent usage over time.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-02-01 10:26:46 -07:00
Travis Nielsen 60d6fe5362 Merge pull request #13663 from iPraveenParihar/fix/netNamespaceFilePath-generation
csi: Fix NetNamespaceFilePath generation with namespace instead of name
2024-02-01 09:32:33 -07:00
Travis Nielsen e39ee8caba Merge pull request #13653 from travisn/exporter-delete-ns
exporter: Don't delete exporter service on daemon deletion
2024-02-01 09:30:32 -07:00
subham rai 949016d53a Merge pull request #13639 from rook/dependabot/go_modules/github-dependencies-99794afd47
build(deps): bump the github-dependencies group with 5 updates
2024-02-01 16:33:35 +05:30
Praveen M 67ff924b57 csi: fix NetNamespaceFilePath generation
Corrected the NetNamespaceFilePath generation in the
subvolumegroup & radosnamespace controller by replacing
the cephCluster.Name with cephCluster.Namespace.

Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-02-01 11:24:08 +05:30
dependabot[bot] 6cdb48e989 build(deps): bump the github-dependencies group with 5 updates
Bumps the github-dependencies group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) | `1.50.0` | `1.50.5` |
| [github.com/google/uuid](https://github.com/google/uuid) | `1.5.0` | `1.6.0` |
| [github.com/hashicorp/vault/api](https://github.com/hashicorp/vault) | `1.10.0` | `1.11.0` |
| [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) | `0.71.0` | `0.71.2` |
| [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator) | `0.71.0` | `0.71.2` |

Updates `github.com/aws/aws-sdk-go` from 1.50.0 to 1.50.5
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.50.0...v1.50.5)

Updates `github.com/google/uuid` from 1.5.0 to 1.6.0
- [Release notes](https://github.com/google/uuid/releases)
- [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/uuid/compare/v1.5.0...v1.6.0)

Updates `github.com/hashicorp/vault/api` from 1.10.0 to 1.11.0
- [Release notes](https://github.com/hashicorp/vault/releases)
- [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md)
- [Commits](https://github.com/hashicorp/vault/compare/v1.10.0...v1.11.0)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.71.0 to 0.71.2
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.71.0...v0.71.2)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.71.0 to 0.71.2
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.71.0...v0.71.2)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/google/uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/hashicorp/vault/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-01-31 16:41:12 -07:00
Travis Nielsen 6739e32d33 Merge pull request #13644 from rkachach/fix_issue_13594
mgr: use the ac-user-set-password cmd to update the password
2024-01-31 08:45:36 -07:00
Travis Nielsen 2f82d0a520 Merge pull request #13655 from parth-gr/objectstore-fix-zonegroup
object: fix the default multisite zonegroup creation
2024-01-31 07:56:54 -07:00
Jiffin Tony Thottan 5b5e1c0292 object: add check specific to name and namespace for ceph cosi driver
The name for cephcosi driver should be ceph-cosi-driver and namespace
should same as the rook operator. Otherwise request need to be failed.

Fixes: #13025
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2024-01-31 11:32:47 +05:30
parth-gr a9c77280c6 object: fix the deafult multisite zonegroup creation
there was a bug in the code which doesn't
sets realm if we try to get the zonegoup
so because of that 1.12 this backport pr
for original change was not working

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-01-31 10:06:44 +05:30
travisn a1fc70f2fc exporter: dont delete exporter service on daemon deletion
The exporter service and service monitor should not
be deleted if an individual daemon is being removed
from a node. As long as the exporter is enabled with
v18 and newer, the exporter service and service monitor
should exist. Clusters were seeing their metrics stop
collection when the exporter service and service monitor
would disappear, especially when multiple clusters are
configured.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-01-30 16:23:10 -07:00
Travis Nielsen 4a12234bbe Merge pull request #13646 from parth-gr/k8s-min
docs: clarify the k8s versioning in the doc
2024-01-30 10:51:09 -07:00
parth-gr bad4e972ee docs: clarify the k8s versioning in the doc
we need to clarify what all version we do support

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-01-30 23:03:58 +05:30
Redouane Kachach cb028f3a28 mgr: use the ac-user-set-password cmd to update the password
previous code was calling the following command to create the
dashboard user:
> ceph dashboard ac-user-create <username> -i <password-file>
this works the first time when the user doesn't exist, however subsequent
calls for example when the password has changed or when the secret was
deleted from k8s, will not take place as this command will succeeded
because the user already exists but the password is not updated in
this case. The fix consists in adding an explicit call to the command:
> ceph dashboard ac-user-set-password <username> -i <password-file>
which ensures the password is updated correctly in the access control db

Fixes: https://github.com/rook/rook/issues/13594

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-30 18:04:44 +01:00
Blaine Gardner 60cc943197 Merge pull request #13610 from rkachach/fix_issue_pvc_minikube_test
test: updating spec by an extra disk and the .mgr pool configuration
2024-01-30 09:56:18 -07:00
Travis Nielsen 1a50482868 Merge pull request #13645 from parth-gr/black-python
ci: reformat the python script
2024-01-30 09:28:43 -07:00
Blaine Gardner 8802648456 Merge pull request #13621 from thotz/cosicrdupdate
object: watch updates for cosidriver crd
2024-01-30 09:06:29 -07:00
parth-gr 75fcffd08c ci: reformat the python scripts
currently there is a new release of black
formatter so updating it with new release

Closes: https://github.com/rook/rook/issues/13630

Signe-off-by: parth-gr <partharora1010@gmail.com>
Signed-off-by: parth-gr <paarora@redhat.com>
2024-01-30 20:17:49 +05:30
Travis Nielsen 3b1a428688 Merge pull request #13622 from Madhu-1/csi-name-prefix
csi: option to customize csi driver name prefix
2024-01-29 10:55:55 -07:00
Jiffin Tony Thottan 3da2331fa3 object: watch updates for cosidriver crd
The changes made to cosi driver are reflected. Add the cosidriver crd to
predicate workflow.

Fixes: #12545
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2024-01-29 22:15:21 +05:30
Redouane Kachach 02f86dea24 test: adding a clarification note about this spec file usage
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-29 17:30:42 +01:00
Madhu Rajanna c35a8532aa csi: option to customize csi driver name prefix
For now we are using the operator namespace name
as the prefix for the csi driver, This PR provides
an option for the users if someone wants to have
their own prefix for the csi driver, if someone tries
to change the prefix for existing csi driver rook
operator will fail to reconcile the csi driver.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-01-29 10:54:25 +01:00
Travis Nielsen f85ba88089 Merge pull request #13604 from rkachach/fix_issue_13577
mgr: fixing dashboard configuration handling
2024-01-25 18:51:50 -07:00
Redouane Kachach 39c06d2fa5 mgr: adding logic to keep retrying in case mgr config delete fails
we dont set removeMgrDaemonConfiguration to true unless all the
delete operations went successfull.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-25 21:55:13 +01:00
Riya Singhal c2e3cf367c csi: update network fence CR name
this commit updates the name of network fence CR to
node name + driver name, which will allow the creation of
multiple network fence per drivers on the same node, and
modifies the unit test and deletion procedure for the
same.

Signed-off-by: Riya Singhal <rsinghal@redhat.com>
2024-01-26 00:18:00 +05:30
Travis Nielsen 034756df0e Merge pull request #13620 from subhamkrai/update-go-mod
build: update go dependencies
2024-01-25 11:15:09 -07:00
Travis Nielsen 3512e149f0 Merge pull request #13619 from travisn/operator-limits
operator: Increase resource limits to 1.5 CPU
2024-01-25 11:14:36 -07:00
travisn ca28887403 operator: increase cpu limits
The operator needs to burst significantly when reconciling,
then will quiet down and nearly not consume any cpu.
Therefore, we allow the operator to burst to more than
a full cpu instead of limiting it to a half cpu.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-01-25 10:12:55 -07:00
Travis Nielsen 2d83858ae4 Merge pull request #13618 from sam6258/badquote
build: fix bad quotation in make help
2024-01-25 09:26:25 -07:00
subhamkrai f8af64ae02 test: update unit test to add TypeMeta
with controller runtime v0.17.0, fake client
set TypeMeta for unstructured only, for other
types we need to add TypeMeta.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-01-25 18:56:59 +05:30
subhamkrai 38004bd355 build: update go dependencies
updating go dependencies, like kubernetes api, controller runtime, NAD
client.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-01-25 18:55:29 +05:30
Scott Miller e28c107a76 build: fix bad quotation in make help
Signed-off-by: Scott Miller <smiller1@coreweave.com>
2024-01-25 13:01:01 +00:00
Redouane Kachach 57e3937d40 mgr: fixing dashboard configuration handling
previously, the dashboard parameters supported by Rook were stored in the
daemon configuration section (mgr.X, for example). This differs from
Cephadm-based deployments, where all configurations are stored in the
global mgr configuration section. This variance could result in
configuration mismatches between the active and standby dashboards.
Furthermore, all Ceph dashboard documentation exclusively points to
the global mgr configuration section and makes no use of individual
daemons sections.

Fixes: https://github.com/rook/rook/issues/13577

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-25 10:22:08 +01:00
Santosh Pillai e8002a6d98 Merge pull request #13532 from rkachach/fix_issue_dev_script_refactor
dev: improving the handling of arguments within the script
2024-01-25 13:14:17 +05:30
Redouane Kachach 605710ee0f test: adding new variables for minikube parameters configuration
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-24 13:39:45 +01:00
Travis Nielsen ab31635d9b Merge pull request #13609 from eb4x/fixins
helm: minor fixes
2024-01-23 10:47:16 -07:00
Redouane Kachach 7884b2a3ed test: updating spec by an extra disk and the .mgr pool configuration
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-23 16:23:00 +01:00
Erik Berg 2a225ac718 helm: remove duplicate key for toolbox keyring
We set `ceph_secret=${ROOK_CEPH_SECRET}` just a couple lines above,
and this duplicate is probably just an oversight.

This duplicate key is not present in the similar scripts in
  examples/toolbox.yaml
  examples/toolbox-operator-image.yaml

Signed-off-by: Erik Berg <erikberg@usit.uio.no>
2024-01-23 11:54:00 +01:00
Erik Berg 9a2d8505e7 helm: fix indentation/whitespace
Removing whitespace for consistency and wrong indentation level.
There's one actual "oopsie-fix" in here for CSI_ENABLE_READ_AFFINITY

Signed-off-by: Erik Berg <erikberg@usit.uio.no>
2024-01-23 11:53:46 +01:00
Santosh Pillai f6cadd548c Merge pull request #13590 from sp98/osd-migration-fix
osd: fix operator reconcile during OSD migration
2024-01-23 06:11:55 +05:30
Travis Nielsen 76b97dcc04 Merge pull request #13597 from travisn/no-exporter-reconcile
exporter: Skip reconcile on exporter deletion
2024-01-22 09:38:21 -07:00
travisn 995a64fb3a exporter: skip reconcile on exporter deletion
The exporter pod is ephemeral and frequently being deleted
and re-created when ceph daemons are created. Therefore,
we need to skip reconciling based on the deletion
of the exporter deployment.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-01-19 14:49:44 -07:00