forked from rook/rook
Sébastien Han
9f2867e12a
Now, the CephObjectStoreUser CRD is managed with the controller-runtime. So the watcher is outside of the main controller reconciliation loop of CephCluster which brings numerous benefit such as: * having its own reconciliation loop * won't block anything from the main CephCluster controller loop * fast than waiting for CephCluster loop to completion Partially close: https://github.com/rook/rook/issues/1981 Signed-off-by: Sébastien Han <seb@redhat.com>
86 lines
3.7 KiB
Go
86 lines
3.7 KiB
Go
/*
|
|
Copyright 2020 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package controller
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"time"
|
|
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
|
|
"github.com/rook/rook/pkg/operator/k8sutil"
|
|
kerrors "k8s.io/apimachinery/pkg/api/errors"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"sigs.k8s.io/controller-runtime/pkg/client"
|
|
"sigs.k8s.io/controller-runtime/pkg/reconcile"
|
|
)
|
|
|
|
var (
|
|
// ImmediateRetryResult Return this for a immediate retry of the reconciliation loop with the same request object.
|
|
ImmediateRetryResult = reconcile.Result{Requeue: true}
|
|
// WaitForRequeueIfCephClusterNotReadyAfter requeue after 10sec if the operator is not ready
|
|
WaitForRequeueIfCephClusterNotReadyAfter = 10 * time.Second
|
|
// WaitForRequeueIfCephClusterNotReady waits for the CephCluster to be ready
|
|
WaitForRequeueIfCephClusterNotReady = reconcile.Result{Requeue: true, RequeueAfter: WaitForRequeueIfCephClusterNotReadyAfter}
|
|
)
|
|
|
|
// IsReadyToReconcile determines if a controller is ready to reconcile or not
|
|
func IsReadyToReconcile(client client.Client, clustercontext *clusterd.Context, namespacedName types.NamespacedName) (cephv1.ClusterSpec, bool, bool, reconcile.Result) {
|
|
namespacedName.Name = namespacedName.Namespace
|
|
cephClusterExists := true
|
|
|
|
// Running ceph commands won't work and the controller will keep re-queuing so I believe it's fine not to check
|
|
// Make sure a CephCluster exists before doing anything
|
|
cephCluster := &cephv1.CephCluster{}
|
|
err := client.Get(context.TODO(), namespacedName, cephCluster)
|
|
if err != nil {
|
|
if kerrors.IsNotFound(err) {
|
|
cephClusterExists = false
|
|
logger.Errorf("CephCluster resource %q not found in namespace %q", namespacedName.Name, namespacedName.Namespace)
|
|
return cephv1.ClusterSpec{}, false, cephClusterExists, ImmediateRetryResult
|
|
} else if err != nil {
|
|
logger.Errorf("failed to fetch CephCluster %v", err)
|
|
return cephv1.ClusterSpec{}, false, cephClusterExists, ImmediateRetryResult
|
|
}
|
|
}
|
|
|
|
logger.Debugf("CephCluster resource %q found in namespace %q", namespacedName.Name, namespacedName.Namespace)
|
|
|
|
// If the cluster is ready
|
|
if cephCluster.Status.Phase == k8sutil.ReadyStatus {
|
|
// Test a Ceph command to verify the Operator is ready
|
|
// This is done to silence errors when the operator just started and cannot reconcile yet
|
|
_, err = cephclient.Status(clustercontext, namespacedName.Namespace, true)
|
|
if err != nil {
|
|
if strings.Contains(err.Error(), "error calling conf_read_file") {
|
|
logger.Info("operator is not ready to run ceph command, cannot reconcile yet.")
|
|
return cephCluster.Spec, false, cephClusterExists, WaitForRequeueIfCephClusterNotReady
|
|
}
|
|
// We should not arrive there
|
|
logger.Errorf("ceph command error %v", err)
|
|
return cephCluster.Spec, false, cephClusterExists, ImmediateRetryResult
|
|
}
|
|
logger.Debugf("operator is ready to run ceph command, reconciling")
|
|
return cephCluster.Spec, true, cephClusterExists, reconcile.Result{}
|
|
}
|
|
|
|
logger.Debugf("CephCluster resource %q found in namespace %q but not ready yet", namespacedName.Name, namespacedName.Namespace)
|
|
return cephCluster.Spec, false, cephClusterExists, ImmediateRetryResult
|
|
}
|