Files
my-rook-config/pkg/operator/ceph/csi/ceph_connection.go
T
Travis Nielsen 76e9c04b36 csi: disable read affinity for ceph v20.2.0
Read affinity in Ceph v20.2.0 can cause corruption.
Disable this feature for this version of Ceph to
avoid hitting any corruption in this case. When the next
patch release is out for tentacle, this issue will be
resolved and when upgrading to it, read affinity would
automatically be re-enabled if needed.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2026-01-12 13:46:43 -07:00

117 lines
4.4 KiB
Go

/*
Copyright 2024 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package csi
import (
"os"
"strings"
"github.com/pkg/errors"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
"github.com/rook/rook/pkg/operator/ceph/cluster/osd/topology"
cephver "github.com/rook/rook/pkg/operator/ceph/version"
"github.com/rook/rook/pkg/operator/k8sutil"
csiopv1 "github.com/ceph/ceph-csi-operator/api/v1"
kerrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/client"
)
func CreateUpdateCephConnection(c client.Client, clusterInfo *cephclient.ClusterInfo, clusterSpec cephv1.ClusterSpec) error {
// Create a cephconnection CR in the namespace of the operator, with the namespace of the cephcluster CR
csiCephConnection := &csiopv1.CephConnection{}
csiCephConnection.Name = clusterInfo.NamespacedName().Namespace
csiCephConnection.Namespace = os.Getenv(k8sutil.PodNamespaceEnvVar)
logger.Infof("Configuring ceph connection CR %q in namespace %q", csiCephConnection.Name, csiCephConnection.Namespace)
spec, err := generateCephConnSpec(c, clusterInfo, clusterSpec)
if err != nil {
return errors.Wrapf(err, "failed to set ceph connection CR %q in namespace %q", csiCephConnection.Name, clusterInfo.Namespace)
}
err = c.Get(clusterInfo.Context, types.NamespacedName{Name: csiCephConnection.Name, Namespace: csiCephConnection.Namespace}, csiCephConnection)
if err != nil {
if kerrors.IsNotFound(err) {
csiCephConnection.Spec = spec
err = c.Create(clusterInfo.Context, csiCephConnection)
if err != nil {
return errors.Wrapf(err, "failed to create ceph connection CR %q", csiCephConnection.Name)
}
logger.Infof("Successfully created ceph connection CR %q", csiCephConnection.Name)
return nil
}
return errors.Wrap(err, "failed to get ceph connection CR")
}
csiCephConnection.Spec = spec
err = c.Update(clusterInfo.Context, csiCephConnection)
if err != nil {
return errors.Wrapf(err, "failed to update ceph connection CR %q", csiCephConnection.Name)
}
logger.Infof("Successfully updated ceph connection CR %q", csiCephConnection.Name)
return nil
}
func generateCephConnSpec(c client.Client, clusterInfo *cephclient.ClusterInfo, clusterSpec cephv1.ClusterSpec) (csiopv1.CephConnectionSpec, error) {
csiClusterConnSpec := csiopv1.CephConnectionSpec{}
if ReadAffinityEnabled(clusterSpec.CSI.ReadAffinity.Enabled, clusterInfo.CephVersion) {
crushLabels := clusterSpec.CSI.ReadAffinity.CrushLocationLabels
if len(crushLabels) == 0 {
logger.Debug("using default crush topology labels")
crushLabels = strings.Split(topology.GetDefaultTopologyLabels(), ",")
}
csiClusterConnSpec.ReadAffinity = &csiopv1.ReadAffinitySpec{
CrushLocationLabels: crushLabels,
}
}
cephRBDMirrorList := &cephv1.CephRBDMirrorList{}
err := c.List(clusterInfo.Context, cephRBDMirrorList, &client.ListOptions{Namespace: clusterInfo.Namespace})
if err != nil {
return csiClusterConnSpec, errors.Wrapf(err, "failed to list CephRBDMirror resource")
}
if len(cephRBDMirrorList.Items) == 0 {
logger.Debug("no ceph CephRBDMirror found")
} else {
// Currently, only single RBD mirror is supported
csiClusterConnSpec.RbdMirrorDaemonCount = cephRBDMirrorList.Items[0].Spec.Count
}
csiClusterConnSpec.Monitors = MonEndpoints(clusterInfo.AllMonitors(), clusterSpec.RequireMsgr2())
return csiClusterConnSpec, nil
}
func ReadAffinityEnabled(desiredEnabled bool, version cephver.CephVersion) bool {
if !desiredEnabled {
return false
}
logger.Debugf("checking if read affinity is supported for Ceph version %q", version.String())
// Read affinity causes corruption on Ceph v20.2.0, so always disable it for that version
if version.Major == 20 && version.Minor == 2 && version.Extra == 0 {
logger.Warningf("read affinity disabled for Ceph version v20.2.0")
return false
}
return true
}