forked from rook/rook
parth-gr
94450c0db7
With a osd resize operation, currently pvc and pv may takes more time then expected. And so the osd dont get resized and need manual re-start as currently we don't have a watch on osd's controller that watches pv and get it resized. add a wait time till pvc is not resized Signed-off-by: parth-gr <partharora1010@gmail.com>
71 lines
2.8 KiB
Go
71 lines
2.8 KiB
Go
/*
|
|
Copyright 2021 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package k8sutil
|
|
|
|
import (
|
|
"context"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
storagev1 "k8s.io/api/storage/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"sigs.k8s.io/controller-runtime/pkg/client"
|
|
)
|
|
|
|
// ExpandPVCIfRequired will expand the PVC if requested size is greater than the actual size of existing PVC
|
|
func ExpandPVCIfRequired(ctx context.Context, client client.Client, desiredPVC *v1.PersistentVolumeClaim, currentPVC *v1.PersistentVolumeClaim) bool {
|
|
desiredSize, desiredOK := desiredPVC.Spec.Resources.Requests[v1.ResourceStorage]
|
|
currentSize, currentOK := currentPVC.Spec.Resources.Requests[v1.ResourceStorage]
|
|
if !desiredOK || !currentOK {
|
|
logger.Debugf("desired or current size are not specified for PVC %q", currentPVC.Name)
|
|
return false
|
|
}
|
|
|
|
if desiredSize.Value() > currentSize.Value() {
|
|
|
|
if currentPVC.Spec.StorageClassName == nil || *(currentPVC.Spec.StorageClassName) == "" {
|
|
logger.Infof("cannot expand PVC %q because storage class is not provided", currentPVC.ObjectMeta.Name)
|
|
return false
|
|
}
|
|
|
|
// get StorageClass
|
|
storageClass := &storagev1.StorageClass{}
|
|
err := client.Get(ctx, types.NamespacedName{Name: *(currentPVC.Spec.StorageClassName)}, storageClass)
|
|
if err != nil {
|
|
logger.Errorf("failed to get storageClass %q. %v", *(currentPVC.Spec.StorageClassName), err)
|
|
return false
|
|
}
|
|
|
|
if storageClass.AllowVolumeExpansion == nil || !*(storageClass.AllowVolumeExpansion) {
|
|
logger.Infof("cannot expand PVC %q. storage class %q does not allow expansion", currentPVC.ObjectMeta.Name, storageClass.ObjectMeta.Name)
|
|
return false
|
|
}
|
|
|
|
currentPVC.Spec.Resources.Requests[v1.ResourceStorage] = desiredSize
|
|
logger.Infof("updating PVC %q size from %s to %s", currentPVC.Name, currentSize.String(), desiredSize.String())
|
|
if err = client.Update(ctx, currentPVC); err != nil {
|
|
// log the error, but don't fail the reconcile
|
|
logger.Errorf("failed to update PVC size. %v", err)
|
|
return false
|
|
}
|
|
logger.Infof("successfully updated PVC %q size", currentPVC.Name)
|
|
return true
|
|
} else if desiredSize.Value() < currentSize.Value() {
|
|
logger.Warningf("ignoring request to shrink PVC %q size from %s to %s, only expansion is allowed", currentPVC.Name, currentSize.String(), desiredSize.String())
|
|
}
|
|
return false
|
|
}
|