feedc0de/platformio-core
1
0
Fork 0
forked from platformio/platformio-core
Code Pull Requests Activity

test/runners/unity.py: fixed warnings: [-Wunused-parameter] (#4610)

Browse Source 
They appear when the tests are run with the `Wextra` flag.

I know of 3 possible solutions:
* A.) `static_cast<void>(unusedParameter);` – the preferred C++ way, but `unity` can also be used with `C`
* B.) `(void) unusedParameter;` – "old" C–style casting – the one I used – compatible with both C and C++
* C.) remove `unusedParameter` var from the function arguments – but keeping the name better explains what it is

```
Library Manager: Installing throwtheswitch/Unity @ ^2.5.2
Unpacking  [####################################]  100%
Library Manager: Unity@2.5.2 has been installed!
.pio/build/native/unity_config/unity_config.c:39:37: warning: unused parameter 'baudrate' [-Wunused-parameter]
void unityOutputStart(unsigned long baudrate) { }
                                    ^
1 warning generated.
Testing...
```
This commit is contained in:
Dawid Nowak
2023-05-01 13:30:27 +02:00
committed by GitHub
parent 4596acab81
commit f6aa95a4fe
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
platformio/test/runners/unity.py
View File

@ -114,7 +114,7 @@ $framework_config_code
native=dict(
code="""
#include <stdio.h>
void unityOutputStart(unsigned long baudrate) { }
void unityOutputStart(unsigned long baudrate) { (void) baudrate; }
void unityOutputChar(unsigned int c) { putchar(c); }
void unityOutputFlush(void) { fflush(stdout); }
void unityOutputComplete(void) { }
@ -155,7 +155,7 @@ void unityOutputComplete(void) { }
espidf=dict(
code="""
#include <stdio.h>
void unityOutputStart(unsigned long baudrate) { }
void unityOutputStart(unsigned long baudrate) { (void) baudrate; }
void unityOutputChar(unsigned int c) { putchar(c); }
void unityOutputFlush(void) { fflush(stdout); }
void unityOutputComplete(void) { }
@ -165,7 +165,7 @@ void unityOutputComplete(void) { }
zephyr=dict(
code="""
#include <sys/printk.h>
void unityOutputStart(unsigned long baudrate) { }
void unityOutputStart(unsigned long baudrate) { (void) baudrate; }
void unityOutputChar(unsigned int c) { printk("%c", c); }
void unityOutputFlush(void) { }
void unityOutputComplete(void) { }