feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Replace QLinkedList

Browse Source 
Task-number: QTCREATORBUG-24098
Change-Id: I611bab2bbd47c969c64037173f5ea68240ca28ff
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2020-06-23 07:26:58 +02:00
parent f922a0bbf1
commit 00f685cba4
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/valgrind/callgrindvisualisation.cpp
View File

@@ -33,17 +33,17 @@
#include <valgrind/callgrind/callgrindproxymodel.h> #include <valgrind/callgrind/callgrindproxymodel.h>
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
#include <QAbstractItemModel>
#include <QDebug>
#include <QGraphicsRectItem> #include <QGraphicsRectItem>
#include <QGraphicsScene> #include <QGraphicsScene>
#include <QGraphicsSimpleTextItem> #include <QGraphicsSimpleTextItem>
#include <QMouseEvent> #include <QMouseEvent>
#include <QStaticText>
#include <QStyleOptionGraphicsItem>
#include <QPair> #include <QPair>
#include <QPersistentModelIndex> #include <QPersistentModelIndex>
#include <QLinkedList> #include <QStaticText>
#include <QAbstractItemModel> #include <QStyleOptionGraphicsItem>
#include <QDebug> #include <QVector>
#define VISUALISATION_DEBUG 0 #define VISUALISATION_DEBUG 0
// Margin from hardcoded value in: // Margin from hardcoded value in:
@@ -364,7 +364,7 @@ void Visualization::populateScene()
qreal total = 0; qreal total = 0;
using Pair = QPair<QModelIndex, qreal>; using Pair = QPair<QModelIndex, qreal>;
QLinkedList<Pair> costs; QVector<Pair> costs;
for (int row = 0; row < d->m_model->rowCount(); ++row) { for (int row = 0; row < d->m_model->rowCount(); ++row) {
const QModelIndex index = d->m_model->index(row, DataModel::InclusiveCostColumn); const QModelIndex index = d->m_model->index(row, DataModel::InclusiveCostColumn);
@@ -402,7 +402,7 @@ void Visualization::populateScene()
// add the canvas elements to the scene // add the canvas elements to the scene
qreal used = sceneHeight * 0.1; qreal used = sceneHeight * 0.1;
foreach (const Pair &cost, costs) { for (const Pair &cost : qAsConst(costs)) {
const QModelIndex &index = cost.first; const QModelIndex &index = cost.first;
const QString text = index.data().toString(); const QString text = index.data().toString();