feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Do not disable run configs because of project parsing

Browse Source 
After project parsing has ended, the run configurations are set up from
the information provided by the parse, and that information is valid
until the end of the next parse. There does not appear to be a reason to
prevent users from e.g. editing command line arguments or starting the
application just because the project is currently being parsed.

Task-number: QTCREATORBUG-22548
Change-Id: Ib5e77c747fc2483650bcab22e07881ee7d93500b
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2019-08-14 15:28:03 +02:00
parent 09cb507f4f
commit 020c2914c3
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -148,7 +148,7 @@ void GlobalOrProjectAspect::resetProjectToGlobalSettings()
necessary data as the RunControl may continue to exist after the RunConfiguration
has been destroyed.
A RunConfiguration disables itself when the project is parsing or has no parsing
A RunConfiguration disables itself if the project has no parsing
data available. The disabledReason() method can be used to get a user-facing string
describing why the RunConfiguration considers itself unfit for use.
@@ -164,8 +164,6 @@ RunConfiguration::RunConfiguration(Target *target, Core::Id id)
: ProjectConfiguration(target, id)
{
QTC_CHECK(target && target == this->target());
connect(target->project(), &Project::parsingStarted,
this, [this]() { updateEnabledState(); });
connect(target->project(), &Project::parsingFinished,
this, [this]() { updateEnabledState(); });
@@ -235,12 +233,11 @@ void RunConfiguration::setEnabled(bool enabled)
QString RunConfiguration::disabledReason() const
{
if (target()->project()->isParsing())
return tr("The Project is currently being parsed.");
if (!target()->project()->hasParsingData()) {
QString msg = tr("The project could not be fully parsed.");
if (!project()->hasParsingData()) {
QString msg = project()->isParsing() ? tr("The project is currently being parsed.")
: tr("The project could not be fully parsed.");
const FilePath projectFilePath = buildTargetInfo().projectFilePath;
if (!projectFilePath.exists())
if (!projectFilePath.isEmpty() && !projectFilePath.exists())
msg += '\n' + tr("The project file \"%1\" does not exist.").arg(projectFilePath.toString());
return msg;
}
@@ -269,9 +266,7 @@ QWidget *RunConfiguration::createConfigurationWidget()
void RunConfiguration::updateEnabledState()
{
Project *p = target()->project();
setEnabled(!p->isParsing() && p->hasParsingData());
setEnabled(project()->hasParsingData());
}
void RunConfiguration::addAspectFactory(const AspectFactory &aspectFactory)