Fix some clang warnings about unused lambda captures

There are more, but we need to keep those because MSVC believes they are
required. This is the subset that satisifies both compilers.

Change-Id: I0b0a63d5496acc119a7f0513d3a1da0b76fa1fca
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/plugins/autotest/autotestplugin.cpp

@@ -157,7 +157,7 @@ AutotestPluginPrivate::AutotestPluginPrivate()
             this, [this] { m_runconfigCache.clear(); });
 
     connect(sessionManager, &ProjectExplorer::SessionManager::aboutToRemoveProject,
-            this, [this] (ProjectExplorer::Project *project) {
+            this, [] (ProjectExplorer::Project *project) {
         auto it = s_projectSettings.find(project);
         if (it != s_projectSettings.end()) {
             delete it.value();

src/plugins/coreplugin/documentmanager.cpp

@@ -275,7 +275,7 @@ DocumentManager::DocumentManager(QObject *parent)
     m_instance = this;
 
     connect(Utils::GlobalFileChangeBlocker::instance(), &Utils::GlobalFileChangeBlocker::stateChanged,
-            this, [this](bool blocked) {
+            this, [](bool blocked) {
         d->m_postponeAutoReload = blocked;
         if (!blocked)
             QTimer::singleShot(500, m_instance, &DocumentManager::checkForReload);

src/plugins/debugger/debuggermainwindow.cpp

@@ -250,7 +250,7 @@ DebuggerMainWindowPrivate::DebuggerMainWindowPrivate(DebuggerMainWindow *parent)
     m_toolBarDock = dock;
     q->addDockWidget(Qt::BottomDockWidgetArea, m_toolBarDock);
 
-    connect(viewButton, &QAbstractButton::clicked, this, [this, viewButton] {
+    connect(viewButton, &QAbstractButton::clicked, this, [viewButton] {
         ActionContainer *viewsMenu = ActionManager::actionContainer(Core::Constants::M_VIEW_VIEWS);
         viewsMenu->menu()->exec(viewButton->mapToGlobal(QPoint()));
     });

src/plugins/debugger/lldb/lldbengine.cpp

@@ -673,7 +673,7 @@ void LldbEngine::requestModuleSymbols(const QString &moduleName)
 {
     DebuggerCommand cmd("fetchSymbols");
     cmd.arg("module", moduleName);
-    cmd.callback = [this, moduleName](const DebuggerResponse &response) {
+    cmd.callback = [moduleName](const DebuggerResponse &response) {
         const GdbMi &symbols = response.data["symbols"];
         QString moduleName = response.data["module"].data();
         Symbols syms;

src/plugins/help/helpplugin.cpp

@@ -373,7 +373,7 @@ HelpWidget *HelpPluginPrivate::createHelpWidget(const Context &context, HelpWidg
             &LocalHelpManager::returnOnCloseChanged,
             widget,
             &HelpWidget::updateCloseButton);
-    connect(widget, &HelpWidget::closeButtonClicked, this, [this, widget] {
+    connect(widget, &HelpWidget::closeButtonClicked, this, [widget] {
         if (widget->widgetStyle() == HelpWidget::SideBarWidget)
             RightPaneWidget::instance()->setShown(false);
         else if (widget->viewerCount() == 1 && LocalHelpManager::returnOnClose())

src/plugins/qmldesigner/components/integration/designdocument.cpp

@@ -488,7 +488,7 @@ void DesignDocument::paste()
             }
         }
 
-        rewriterView()->executeInTransaction("DesignDocument::paste1", [this, &view, selectedNodes, targetNode](){
+        rewriterView()->executeInTransaction("DesignDocument::paste1", [&view, selectedNodes, targetNode](){
             QList<ModelNode> pastedNodeList;
 
             int offset = double(qrand()) / RAND_MAX * 20 - 10;

src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp

@@ -602,7 +602,7 @@ void NavigatorTreeModel::moveNodesInteractive(NodeAbstractProperty &parentProper
 {
     QTC_ASSERT(m_view, return);
 
-    m_view->executeInTransaction("NavigatorTreeModel::moveNodesInteractive",[this, &parentProperty, modelNodes, targetIndex](){
+    m_view->executeInTransaction("NavigatorTreeModel::moveNodesInteractive",[&parentProperty, modelNodes, targetIndex](){
         const TypeName propertyQmlType = parentProperty.parentModelNode().metaInfo().propertyTypeName(parentProperty.name());
         foreach (const ModelNode &modelNode, modelNodes) {
             if (modelNode.isValid()

src/plugins/qmldesigner/components/navigator/navigatorview.cpp

@@ -155,7 +155,7 @@ void NavigatorView::handleChangedExport(const ModelNode &modelNode, bool exporte
     if (rootNode.hasProperty(modelNodeId))
         rootNode.removeProperty(modelNodeId);
     if (exported) {
-        executeInTransaction("NavigatorTreeModel:exportItem", [this, modelNode](){
+        executeInTransaction("NavigatorTreeModel:exportItem", [modelNode](){
             QmlObjectNode qmlObjectNode(modelNode);
             qmlObjectNode.ensureAliasExport();
         });