feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakePM: Fix disappearing of the CMake settings page

Browse Source 
The ProjectExplorer::Task::Error will result in having
m_kitErrorsForProject in targetsettingspanel.cpp which in
TargetItem::updateSubItems() recreates the build settings page.

By reporting the CMake project loading as Task::Warning the above
case is avoided the project build settings page is not
disappearing anymore.

Change-Id: Ib2523e6ea86fe5ad6e4bbee4e101b47cb350a68d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Cristian Adam
2022-03-29 20:09:02 +02:00
parent 17ef9bc35c
commit 0341f83ad1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
View File

@@ -514,7 +514,7 @@ void CMakeBuildSystem::combineScanAndParse(bool restoredFromBackup)
if (restoredFromBackup) if (restoredFromBackup)
project()->addIssue( project()->addIssue(
CMakeProject::IssueType::Error, CMakeProject::IssueType::Warning,
tr("<b>CMake configuration failed<b>" tr("<b>CMake configuration failed<b>"
"<p>The backup of the previous configuration has been restored.</p>" "<p>The backup of the previous configuration has been restored.</p>"
"<p>Have a look at the Issues pane or in the \"Projects > Build\" settings " "<p>Have a look at the Issues pane or in the \"Projects > Build\" settings "
@@ -532,7 +532,7 @@ void CMakeBuildSystem::combineScanAndParse(bool restoredFromBackup)
updateFallbackProjectData(); updateFallbackProjectData();
project()->addIssue( project()->addIssue(
CMakeProject::IssueType::Error, CMakeProject::IssueType::Warning,
tr("<b>Failed to load project<b>" tr("<b>Failed to load project<b>"
"<p>Have a look at the Issues pane or in the \"Projects > Build\" settings " "<p>Have a look at the Issues pane or in the \"Projects > Build\" settings "
"for more information about the failure.</p")); "for more information about the failure.</p"));