feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Code cosmetics

Browse Source 
Remove dead code

Change-Id: I07c30fdd777f2bdaf7695d740448fffb65349e9c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-11-09 13:49:58 +01:00
parent 05ba1a0ff9
commit 03447f1734
1 changed files with 0 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/plugins/debugger/debuggerplugin.cpp
View File

@@ -1065,13 +1065,6 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments,
m_engineManagerWindow->setWindowTitle(tr("Debugger Perspectives")); m_engineManagerWindow->setWindowTitle(tr("Debugger Perspectives"));
m_engineManagerWindow->setObjectName(DOCKWIDGET_ENGINEMANAGER); m_engineManagerWindow->setObjectName(DOCKWIDGET_ENGINEMANAGER);
//act = m_snapshotAction = new QAction(tr("Create Snapshot"), this);
//act->setProperty(Role, RequestCreateSnapshotRole);
//act->setIcon(Icons::SNAPSHOT.icon());
// connect(act, &QAction::triggered,
// this, &DebuggerPluginPrivate::handleOperateByInstructionTriggered);
// Logging // Logging
m_globalLogWindow = new GlobalLogWindow; m_globalLogWindow = new GlobalLogWindow;
@@ -1290,22 +1283,11 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments,
debugMenu->addSeparator(); debugMenu->addSeparator();
//cmd = ActionManager::registerAction(m_snapshotAction,
// "Debugger.Snapshot", cppDebuggercontext);
//cmd->setDefaultKeySequence(QKeySequence(tr("Ctrl+D,Ctrl+S")));
//cmd->setAttribute(Command::CA_Hide);
//debugMenu->addAction(cmd);
ActionManager::registerAction(&m_frameDownAction, ActionManager::registerAction(&m_frameDownAction,
"Debugger.FrameDown", cppDebuggercontext); "Debugger.FrameDown", cppDebuggercontext);
ActionManager::registerAction(&m_frameUpAction, ActionManager::registerAction(&m_frameUpAction,
"Debugger.FrameUp", cppDebuggercontext); "Debugger.FrameUp", cppDebuggercontext);
// cmd = ActionManager::registerAction(action(OperateByInstruction),
// Constants::OPERATE_BY_INSTRUCTION, cppDebuggercontext);
// cmd->setAttribute(Command::CA_Hide);
// debugMenu->addAction(cmd);
cmd = ActionManager::registerAction(&m_breakAction, "Debugger.ToggleBreak"); cmd = ActionManager::registerAction(&m_breakAction, "Debugger.ToggleBreak");
cmd->setDefaultKeySequence(QKeySequence(useMacShortcuts ? tr("F8") : tr("F9"))); cmd->setDefaultKeySequence(QKeySequence(useMacShortcuts ? tr("F8") : tr("F9")));
debugMenu->addAction(cmd); debugMenu->addAction(cmd);
@@ -1314,14 +1296,6 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments,
debugMenu->addSeparator(); debugMenu->addSeparator();
// currently broken
// auto qmlUpdateOnSaveDummyAction = new QAction(tr("Apply Changes on Save"), this);
// qmlUpdateOnSaveDummyAction->setCheckable(true);
// qmlUpdateOnSaveDummyAction->setIcon(Icons::APPLY_ON_SAVE.icon());
// qmlUpdateOnSaveDummyAction->setEnabled(false);
// cmd = ActionManager::registerAction(qmlUpdateOnSaveDummyAction, Constants::QML_UPDATE_ON_SAVE);
// debugMenu->addAction(cmd);
auto qmlShowAppOnTopDummyAction = new QAction(tr("Show Application on Top"), this); auto qmlShowAppOnTopDummyAction = new QAction(tr("Show Application on Top"), this);
qmlShowAppOnTopDummyAction->setCheckable(true); qmlShowAppOnTopDummyAction->setCheckable(true);
qmlShowAppOnTopDummyAction->setIcon(Icons::APP_ON_TOP.icon()); qmlShowAppOnTopDummyAction->setIcon(Icons::APP_ON_TOP.icon());
@@ -1398,24 +1372,10 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments,
m_perspective.useSubPerspectiveSwitcher(EngineManager::engineChooser()); m_perspective.useSubPerspectiveSwitcher(EngineManager::engineChooser());
m_perspective.addToolBarAction(&m_startAction); m_perspective.addToolBarAction(&m_startAction);
// QAction *operateByInstructionAction = action(OperateByInstruction);
// operateByInstructionAction->setText(tr("Start in Operate by Instruction mode"));
// QAction *enableReverseDebuggingAction = action(EnableReverseDebugging);
// enableReverseDebuggingAction->setText(tr("Start with recording information to reverse step if possible"));
//// Icons::SINGLE_INSTRUCTION_MODE.icon()};
// Action m_enableReverseDebuggingAction{tr("Start with recording information to reverse step if possible"),
// Icons::REVERSE_MODE.icon()}
// m_perspective.addToolbarAction(operateByInstructionAction);
m_perspective.addWindow(m_breakpointManagerWindow, Perspective::SplitVertical, nullptr); m_perspective.addWindow(m_breakpointManagerWindow, Perspective::SplitVertical, nullptr);
m_perspective.addWindow(m_globalLogWindow, Perspective::SplitHorizontal, m_breakpointManagerWindow, false); m_perspective.addWindow(m_globalLogWindow, Perspective::SplitHorizontal, m_breakpointManagerWindow, false);
m_perspective.addWindow(m_engineManagerWindow, Perspective::AddToTab, m_globalLogWindow); m_perspective.addWindow(m_engineManagerWindow, Perspective::AddToTab, m_globalLogWindow);
// connect(action(EnableReverseDebugging), &SavedAction::valueChanged,
// this, &DebuggerPluginPrivate::enableReverseDebuggingTriggered);
setInitialState(); setInitialState();
connect(SessionManager::instance(), &SessionManager::startupProjectChanged, connect(SessionManager::instance(), &SessionManager::startupProjectChanged,