feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppTools: Fix revision check in CppLocatorData

Browse Source 
Bug was exhibited by running e.g.

 ./qtcreator -test CppEditor,test_quickfix_MoveFuncDefOutside_FreeFuncToCppNS \
   -test CppTools,test_cpplocatorfilters_CppLocatorFilter:CppFunctionsFilter-WithNamespacePrefix

Change-Id: I57d96a8f7bf0aea6eb11cb68d1b981808533ce41
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
Nikolai Kosjar
2015-01-19 11:35:19 +01:00
parent 21f272a8c7
commit 046f510e19
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/cpptools/cpplocatordata.cpp
View File

@@ -54,8 +54,7 @@ void CppLocatorData::onDocumentUpdated(const CPlusPlus::Document::Ptr &document)
int i = 0, ei = m_pendingDocuments.size(); int i = 0, ei = m_pendingDocuments.size();
for (; i < ei; ++i) { for (; i < ei; ++i) {
const CPlusPlus::Document::Ptr &doc = m_pendingDocuments.at(i); const CPlusPlus::Document::Ptr &doc = m_pendingDocuments.at(i);
if (doc->fileName() == document->fileName() if (doc->fileName() == document->fileName() && doc->revision() <= document->revision()) {
&& doc->revision() < document->revision()) {
m_pendingDocuments[i] = document; m_pendingDocuments[i] = document;
break; break;
} }