feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Pop up task window on first error

Browse Source 
... rather than only at the end of the build process.

Fixes: QTCREATORBUG-27702
Change-Id: I114ef2898f26904e29d96b2cf65dcae4ee9a6121
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2022-06-13 14:21:23 +02:00
parent 7f7768cdd1
commit 04a23c38f0
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/projectexplorer/buildmanager.cpp
View File

@@ -228,6 +228,7 @@ public:
QStringList m_stepNames;
int m_progress = 0;
int m_maxProgress = 0;
bool m_poppedUpTaskWindow = false;
bool m_running = false;
bool m_isDeploying = false;
// is set to true while canceling, so that nextBuildStep knows that the BuildStep finished because of canceling
@@ -489,6 +490,10 @@ void BuildManager::updateTaskCount()
{
const int errors = getErrorTaskCount();
ProgressManager::setApplicationLabel(errors > 0 ? QString::number(errors) : QString());
if (errors > 0 && !d->m_poppedUpTaskWindow) {
showTaskWindow();
d->m_poppedUpTaskWindow = true;
}
}
void BuildManager::finish()
@@ -516,6 +521,7 @@ void BuildManager::clearBuildQueue()
d->m_buildQueue.clear();
d->m_enabledState.clear();
d->m_running = false;
d->m_poppedUpTaskWindow = false;
d->m_isDeploying = false;
d->m_previousBuildStepProject = nullptr;
d->m_currentBuildStep = nullptr;
@@ -752,6 +758,7 @@ void BuildManager::nextStep()
d->m_currentBuildStep->run();
} else {
d->m_running = false;
d->m_poppedUpTaskWindow = false;
d->m_isDeploying = false;
d->m_previousBuildStepProject = nullptr;
d->m_progressFutureInterface->reportFinished();