feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Skip one temporary string in constructor

Browse Source 
Instead of creating a temporary string we simply call append directly.

Change-Id: I75ffd80a4359a19892b196f5d1ddb50b90c5a2cd
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
This commit is contained in:
Marco Bubke
2023-07-20 11:15:06 +02:00
parent bb635325e7
commit 0533636758
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/libs/utils/smallstring.h
View File

@@ -108,13 +108,9 @@ public:
static_assert(!std::is_array<Type>::value, "Input type is array and not char pointer!"); static_assert(!std::is_array<Type>::value, "Input type is array and not char pointer!");
} }
BasicSmallString(const QString &qString) BasicSmallString(const QString &qString) { append(qString); }
: BasicSmallString(BasicSmallString::fromQString(qString))
{}
BasicSmallString(const QStringView qStringView) BasicSmallString(const QStringView qStringView) { append(qStringView); }
: BasicSmallString(BasicSmallString::fromQStringView(qStringView))
{}
BasicSmallString(const QByteArray &qByteArray) BasicSmallString(const QByteArray &qByteArray)
: BasicSmallString(qByteArray.constData(), qByteArray.size()) : BasicSmallString(qByteArray.constData(), qByteArray.size())
@@ -127,9 +123,7 @@ public:
{ {
} }
BasicSmallString(const std::wstring &wstring) BasicSmallString(const std::wstring &wstring) { append(wstring); }
: BasicSmallString(BasicSmallString::fromQStringView(wstring))
{}
template<typename BeginIterator, template<typename BeginIterator,
typename EndIterator, typename EndIterator,