feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

StudioWelcome: Avoid using sender()

Browse Source 
Change-Id: I3d075867c9114f52ead920b3120904fc79bba775
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Jarek Kobus
2022-09-02 16:11:42 +02:00
parent bf99841eb9
commit 05eec13ade
2 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/studiowelcome/wizardhandler.cpp
View File

@@ -87,8 +87,10 @@ void WizardHandler::initializeProjectPage(QWizardPage *page)
auto *jpp = dynamic_cast<ProjectExplorer::JsonProjectPage *>(page); auto *jpp = dynamic_cast<ProjectExplorer::JsonProjectPage *>(page);
QTC_ASSERT(jpp, return); QTC_ASSERT(jpp, return);
QObject::connect(jpp, &ProjectExplorer::JsonProjectPage::statusMessageChanged, this, &WizardHandler::statusMessageChanged); QObject::connect(jpp, &ProjectExplorer::JsonProjectPage::statusMessageChanged,
QObject::connect(jpp, &ProjectExplorer::JsonProjectPage::completeChanged, this, &WizardHandler::onProjectIntroCompleteChanged); this, &WizardHandler::statusMessageChanged);
QObject::connect(jpp, &ProjectExplorer::JsonProjectPage::completeChanged,
this, [this, jpp] { emit projectCanBeCreated(jpp->isComplete()); });
} }
void WizardHandler::initializeFieldsPage(QWizardPage *page) void WizardHandler::initializeFieldsPage(QWizardPage *page)
@@ -100,14 +102,6 @@ void WizardHandler::initializeFieldsPage(QWizardPage *page)
fieldsPage->initializePage(); fieldsPage->initializePage();
} }
void WizardHandler::onProjectIntroCompleteChanged()
{
auto *page = dynamic_cast<ProjectExplorer::JsonProjectPage *>(QObject::sender());
QTC_ASSERT(page, return);
emit projectCanBeCreated(page->isComplete());
}
QStandardItemModel *WizardHandler::getScreenFactorModel(ProjectExplorer::JsonFieldPage *page) QStandardItemModel *WizardHandler::getScreenFactorModel(ProjectExplorer::JsonFieldPage *page)
{ {
auto *field = page->jsonField("ScreenFactor"); auto *field = page->jsonField("ScreenFactor");

1
src/plugins/studiowelcome/wizardhandler.h
View File

@@ -71,7 +71,6 @@ private:
private slots: private slots:
void onWizardResetting(); void onWizardResetting();
void onProjectIntroCompleteChanged();
private: private:
Utils::Wizard *m_wizard = nullptr; Utils::Wizard *m_wizard = nullptr;