forked from qt-creator/qt-creator
Fix off-by-one error which stops qtchooser finding qmake
At startup, qtcreator prints an error: % qtcreator "The command \"/qmake\" could not be started." This appears to be because of an off-by-one error in BuildableHelperLibrary::qtChooserToQmakePath(const QString &path) which parses the output of a call to "qtchooser -print-env" to extract the value of the QTTOOLDIR variable. The code attempts to move past the prefix string to find the end quote, but by moving one too few characters it finds the starting quote instead, resulting in a zero length string result. Change-Id: I74368f10a81eda2286ae735bdc595c0f92e4e665 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
committed by
Eike Ziller
parent
4d79ffb8f3
commit
0735253139
@@ -50,7 +50,7 @@ QString BuildableHelperLibrary::qtChooserToQmakePath(const QString &path)
|
||||
int pos = output.indexOf(toolDir);
|
||||
if (pos == -1)
|
||||
return QString();
|
||||
pos += toolDir.count() - 1;
|
||||
pos += toolDir.count();
|
||||
int end = output.indexOf('\"', pos);
|
||||
if (end == -1)
|
||||
return QString();
|
||||
|
Reference in New Issue
Block a user