Renamed TaskHub::popup to requestPopup and removed boolean flag.

* TaskHub does not pop up itself because it is not a widget.
* popup(true) is never used and may lead to bad user experience.
* use boolean flag goes agains Qt API design guidelines.

Change-Id: Idf28a8d4af66022961d94f1d1cdeeaf155b67c52
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>

src/plugins/analyzerbase/analyzerruncontrol.cpp

@@ -179,7 +179,7 @@ void AnalyzerRunControl::addTask(Task::TaskType type, const QString &description
     TaskHub *hub = ProjectExplorerPlugin::instance()->taskHub();
     hub->addTask(Task(type, description, Utils::FileName::fromUserInput(file), line,
                       Core::Id(Constants::ANALYZERTASK_ID)));
-    hub->popup(false);
+    hub->requestPopup();
 }
 
 } // namespace Analyzer

src/plugins/projectexplorer/taskhub.cpp

@@ -151,9 +151,9 @@ void TaskHub::setCategoryVisibility(const Core::Id &categoryId, bool visible)
     emit categoryVisibilityChanged(categoryId, visible);
 }
 
-void TaskHub::popup(bool withFocus)
+void TaskHub::requestPopup()
 {
-    emit popupRequested(withFocus);
+    emit popupRequested(false);
 }
 
 QIcon TaskHub::taskTypeIcon(Task::TaskType t) const

src/plugins/projectexplorer/taskhub.h

@@ -58,7 +58,7 @@ public:
     void showTaskInEditor(unsigned int id);
     void setCategoryVisibility(const Core::Id &categoryId, bool visible);
 
-    void popup(bool withFocus);
+    void requestPopup();
 
     QIcon taskTypeIcon(ProjectExplorer::Task::TaskType t) const;
 signals:

src/plugins/qmljseditor/qmljseditorplugin.cpp

@@ -367,7 +367,7 @@ void QmlJSEditorPlugin::runSemanticScan()
     m_qmlTaskManager->updateSemanticMessagesNow();
     TaskHub *hub = ProjectExplorerPlugin::instance()->taskHub();
     hub->setCategoryVisibility(Constants::TASK_CATEGORY_QML_ANALYSIS, true);
-    hub->popup(false);
+    hub->requestPopup();
 }
 
 void QmlJSEditorPlugin::checkCurrentEditorSemanticInfoUpToDate()