feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix clang warnings about unwanted copies in range loops

Browse Source 
Change-Id: I11ae3317fd251a463809ee48917d2daf0f8b43d1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Christian Kandeler
2020-06-03 13:45:30 +02:00
parent e2ae2ad41d
commit 0d60ee3906
4 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/libs/cplusplus/LookupContext.cpp
View File

@@ -1142,8 +1142,7 @@ ClassOrNamespace *ClassOrNamespace::nestedType(const Name *name,
int maximumArgumentsMatched = 0; int maximumArgumentsMatched = 0;
for (const std::pair<const TemplateNameId *, ClassOrNamespace *> &p : for (const auto &p : specializations) {
specializations) {
const TemplateNameId *templateSpecialization = p.first; const TemplateNameId *templateSpecialization = p.first;
ClassOrNamespace *specializationClassOrNamespace = p.second; ClassOrNamespace *specializationClassOrNamespace = p.second;

2
src/plugins/android/androidconfigurations.cpp
View File

@@ -616,7 +616,7 @@ QVector<AndroidDeviceInfo> AndroidConfig::connectedDevices(const FilePath &adbTo
if (adbDevs.empty()) if (adbDevs.empty())
return devices; return devices;
for (const QString line : adbDevs) // remove the daemon logs for (const QString &line : adbDevs) // remove the daemon logs
if (line.startsWith("* daemon")) if (line.startsWith("* daemon"))
adbDevs.removeOne(line); adbDevs.removeOne(line);
adbDevs.removeFirst(); // remove "List of devices attached" header line adbDevs.removeFirst(); // remove "List of devices attached" header line

2
src/plugins/android/androidtoolmanager.cpp
View File

@@ -206,7 +206,7 @@ AndroidDeviceInfoList AndroidToolManager::androidVirtualDevices(const Utils::Fil
if (avds.empty()) if (avds.empty())
return devices; return devices;
for (const QString line : avds) // remove the daemon logs for (const QString &line : avds) // remove the daemon logs
if (line.startsWith("* daemon")) if (line.startsWith("* daemon"))
avds.removeOne(line); avds.removeOne(line);

2
src/plugins/qmldesigner/components/connectioneditor/delegates.cpp
View File

@@ -309,7 +309,7 @@ QWidget *ConnectionDelegate::createEditor(QWidget *parent, const QStyleOptionVie
} }
QStringList trigger = connectionModel->getflowActionTriggerForRow(index.row()); QStringList trigger = connectionModel->getflowActionTriggerForRow(index.row());
for (const QString action : trigger) { for (const QString &action : trigger) {
connectionComboBox->addItem(tr("Activate FlowAction %1").arg(nameForAction(action)), action); connectionComboBox->addItem(tr("Activate FlowAction %1").arg(nameForAction(action)), action);
} }
} }