feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't repeat the same code

Browse Source 
Change-Id: Ied1d816481bef760a49a4572e9fda1f6ac538daa
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Jarek Kobus
2020-12-11 13:47:39 +01:00
parent 365ae293fc
commit 12810caea1
1 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugins/texteditor/texteditor.cpp
View File

@@ -618,6 +618,7 @@ public:
void updateSyntaxInfoBar(const Highlighter::Definitions &definitions, const QString &fileName); void updateSyntaxInfoBar(const Highlighter::Definitions &definitions, const QString &fileName);
void configureGenericHighlighter(const KSyntaxHighlighting::Definition &definition); void configureGenericHighlighter(const KSyntaxHighlighting::Definition &definition);
void rememberCurrentSyntaxDefinition(); void rememberCurrentSyntaxDefinition();
void openLinkUnderCursor(bool openInNextSplit);
public: public:
TextEditorWidget *q; TextEditorWidget *q;
@@ -1958,22 +1959,12 @@ void TextEditorWidget::redo()
void TextEditorWidget::openLinkUnderCursor() void TextEditorWidget::openLinkUnderCursor()
{ {
const bool openInNextSplit = alwaysOpenLinksInNextSplit(); d->openLinkUnderCursor(alwaysOpenLinksInNextSplit());
findLinkAt(textCursor(),
[openInNextSplit, self = QPointer<TextEditorWidget>(this)](const Link &symbolLink) {
if (self)
self->openLink(symbolLink, openInNextSplit);
}, true, openInNextSplit);
} }
void TextEditorWidget::openLinkUnderCursorInNextSplit() void TextEditorWidget::openLinkUnderCursorInNextSplit()
{ {
const bool openInNextSplit = !alwaysOpenLinksInNextSplit(); d->openLinkUnderCursor(!alwaysOpenLinksInNextSplit());
findLinkAt(textCursor(),
[openInNextSplit, self = QPointer<TextEditorWidget>(this)](const Link &symbolLink) {
if (self)
self->openLink(symbolLink, openInNextSplit);
}, true, openInNextSplit);
} }
void TextEditorWidget::findUsages() void TextEditorWidget::findUsages()
@@ -3247,6 +3238,16 @@ void TextEditorWidgetPrivate::rememberCurrentSyntaxDefinition()
Highlighter::rememberDefinitionForDocument(definition, m_document.data()); Highlighter::rememberDefinitionForDocument(definition, m_document.data());
} }
void TextEditorWidgetPrivate::openLinkUnderCursor(bool openInNextSplit)
{
q->findLinkAt(q->textCursor(),
[openInNextSplit, self = QPointer<TextEditorWidget>(q)](const Link &symbolLink) {
if (self)
self->openLink(symbolLink, openInNextSplit);
}, true, openInNextSplit);
}
bool TextEditorWidget::codeFoldingVisible() const bool TextEditorWidget::codeFoldingVisible() const
{ {
return d->m_codeFoldingVisible; return d->m_codeFoldingVisible;