feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: optimize updating the paste action

Browse Source 
Selecting text with the mouse emits QClipboard::changed many times on
systems that updates the clipboard on selection changes and checking
whether the clipboard text is empty in the slot is potentially slow.
Debounce calling the update paste action code to reduce checking the
clipboard text.

Fixes: QTCREATORBUG-33073
Change-Id: Ib8a6d4ed7a3688bc543e51ea7e9f012746c9630f
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
David Schulz
2025-06-17 09:10:45 +02:00
parent 529f835c11
commit 1369bec9e2
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/texteditor/texteditor.cpp
View File

@@ -1098,6 +1098,7 @@ public:
QAction *m_jumpToFileAction = nullptr;
QAction *m_jumpToFileInNextSplitAction = nullptr;
QList<QAction *> m_modifyingActions;
bool m_updatePasteActionScheduled = false;
};
class TextEditorWidgetFind : public BaseTextFind<TextEditorWidget>
@@ -1281,7 +1282,16 @@ TextEditorWidgetPrivate::TextEditorWidgetPrivate(TextEditorWidget *parent)
connect(q, &PlainTextEdit::copyAvailable,
this, &TextEditorWidgetPrivate::updateCopyAction);
connect(qApp->clipboard(), &QClipboard::changed, this, &TextEditorWidgetPrivate::updatePasteAction);
connect(qApp->clipboard(), &QClipboard::dataChanged, this, [this] {
// selecting text with the mouse can cause the clipboard to change quite often and the
// check whether the clipboard text is empty in update paste action is potentially
// expensive. So we only schedule the update if it is not already scheduled.
if (m_updatePasteActionScheduled)
return;
m_updatePasteActionScheduled = true;
QTimer::singleShot(100, this, &TextEditorWidgetPrivate::updatePasteAction);
});
m_parenthesesMatchingTimer.setSingleShot(true);
m_parenthesesMatchingTimer.setInterval(50);
@@ -4772,6 +4782,7 @@ void TextEditorWidgetPrivate::updateCopyAction(bool hasCopyableText)
void TextEditorWidgetPrivate::updatePasteAction()
{
m_updatePasteActionScheduled = false;
if (m_pasteAction)
m_pasteAction->setEnabled(!q->isReadOnly() && !qApp->clipboard()->text(QClipboard::Mode::Clipboard).isEmpty());
}