feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Rename BuildStepFactory::cloneStep{,Creator}

Browse Source 
It clones the functor to create the step, not a step as such.

Change-Id: Ie07b321e28fae888bb800a574a717251f3661a2f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2023-04-05 14:18:11 +02:00
parent aa5472ac1b
commit 14ecda9ca2
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/boot2qt/qdbplugin.cpp
View File

@@ -101,7 +101,7 @@ class QdbDeployStepFactory : public BuildStepFactory
public:
explicit QdbDeployStepFactory(Id existingStepId)
{
cloneStep(existingStepId);
cloneStepCreator(existingStepId);
setSupportedConfiguration(Constants::QdbDeployConfigurationId);
setSupportedStepList(ProjectExplorer::Constants::BUILDSTEPS_DEPLOY);
}

2
src/plugins/projectexplorer/buildstep.cpp
View File

@@ -380,7 +380,7 @@ QString BuildStepFactory::displayName() const
return m_displayName;
}
void BuildStepFactory::cloneStep(Utils::Id exitstingStepId, Utils::Id overrideNewStepId)
void BuildStepFactory::cloneStepCreator(Id exitstingStepId, Id overrideNewStepId)
{
m_stepId = {};
m_creator = {};

2
src/plugins/projectexplorer/buildstep.h
View File

@@ -171,7 +171,7 @@ protected:
m_stepId = id;
m_creator = [id](BuildStepList *bsl) { return new BuildStepType(bsl, id); };
}
void cloneStep(Utils::Id exitstingStepId, Utils::Id overrideNewStepId = {});
void cloneStepCreator(Utils::Id exitstingStepId, Utils::Id overrideNewStepId = {});
void setSupportedStepList(Utils::Id id);
void setSupportedStepLists(const QList<Utils::Id> &ids);

2
src/plugins/qnx/qnxplugin.cpp
View File

@@ -46,7 +46,7 @@ class QnxDeployStepFactory : public BuildStepFactory
public:
QnxDeployStepFactory(Utils::Id existingStepId, Utils::Id overrideId = {})
{
cloneStep(existingStepId, overrideId);
cloneStepCreator(existingStepId, overrideId);
setSupportedConfiguration(Constants::QNX_QNX_DEPLOYCONFIGURATION_ID);
setSupportedStepList(ProjectExplorer::Constants::BUILDSTEPS_DEPLOY);
}