feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Replace the last QSharedPointer usage with std::shared_ptr

Browse Source 
Replace it in Pty::Data. Remove the usage of shared pointer
from PathListPlainTextEdit.

According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I5f19edf438eed3dde17b0f9abf570d2b53df93d7
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2024-02-01 11:33:42 +01:00
parent f193aeed47
commit 14ff95b1bf
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/libs/utils/pathlisteditor.cpp
View File

@@ -10,7 +10,6 @@
#include <QMimeData> #include <QMimeData>
#include <QPlainTextEdit> #include <QPlainTextEdit>
#include <QPushButton> #include <QPushButton>
#include <QSharedPointer>
#include <QTextBlock> #include <QTextBlock>
#include <QVBoxLayout> #include <QVBoxLayout>
@@ -64,9 +63,9 @@ void PathListPlainTextEdit::insertFromMimeData(const QMimeData *source)
// replace separator // replace separator
QString text = source->text().trimmed(); QString text = source->text().trimmed();
text.replace(HostOsInfo::pathListSeparator(), QLatin1Char('\n')); text.replace(HostOsInfo::pathListSeparator(), QLatin1Char('\n'));
QSharedPointer<QMimeData> fixed(new QMimeData); QMimeData *fixed = new QMimeData;
fixed->setText(text); fixed->setText(text);
QPlainTextEdit::insertFromMimeData(fixed.data()); QPlainTextEdit::insertFromMimeData(fixed);
} else { } else {
QPlainTextEdit::insertFromMimeData(source); QPlainTextEdit::insertFromMimeData(source);
} }

2
src/libs/utils/processinterface.h
View File

@@ -55,7 +55,7 @@ public:
private: private:
QSize m_size{80, 60}; QSize m_size{80, 60};
QSharedPointer<SharedData> m_data; std::shared_ptr<SharedData> m_data;
}; };
} // namespace Pty } // namespace Pty