feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: No need to update the reader when it already is up to date

Browse Source 
The reader notifies us about the configuration being changed, so there
is no need to tell it about those changes again.

Change-Id: I458947babf1cd9c50a66ea7863f37d1e43d6c5f2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Tobias Hunger
2016-12-01 14:15:52 +01:00
parent 0edb16d4f3
commit 168c5c67a2
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/builddirmanager.cpp
View File

@@ -466,10 +466,8 @@ void BuildDirManager::checkConfiguration()
box->setDefaultButton(defaultButton); box->setDefaultButton(defaultButton);
int ret = box->exec(); int ret = box->exec();
if (ret == QMessageBox::Apply) { if (ret == QMessageBox::Apply)
m_buildConfiguration->setCMakeConfiguration(newConfig); m_buildConfiguration->setCMakeConfiguration(newConfig);
updateReaderData(); // Apply changes to reader
}
} }
} }