feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppEditor: Add property name to the generated signal

Browse Source 
Task-number: QTCREATORBUG-26184
Change-Id: I4689dfb8b74de154092b7916188159432a5c827d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Artem Sokolovskii
2021-08-31 11:58:47 +02:00
parent d59f0f1051
commit 17c6fb866c
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/cppeditor/cppquickfix_test.cpp
View File

@@ -2801,7 +2801,7 @@ public:
N2::test*getBar() const;
void setBar(const custom<N2::test> &newBar);
signals:
void barChanged(N2::test*);
void barChanged(N2::test*bar);
private:
Q_PROPERTY(N2::test* bar READ getBar NOTIFY barChanged)
};
@@ -3598,7 +3598,7 @@ void CppEditorPlugin::test_quickfix_InsertQtPropertyMembers_data()
" }\n"
"\n"
"signals:\n"
" void itChanged(int);\n"
" void itChanged(int it);\n"
"\n"
"private:\n"
" int m_it;\n"
@@ -3631,7 +3631,7 @@ void CppEditorPlugin::test_quickfix_InsertQtPropertyMembers_data()
" }\n"
"\n"
"signals:\n"
" void itChanged(int);\n"
" void itChanged(int it);\n"
"\n"
"private:\n"
" int m_it;\n"
@@ -3693,7 +3693,7 @@ void CppEditorPlugin::test_quickfix_InsertQtPropertyMembers_data()
" emit itChanged(m_it);\n"
" }\n"
"signals:\n"
" void itChanged(int);\n"
" void itChanged(int it);\n"
"};\n"
"\n"
"int XmarksTheSpot::getIt() const\n"

4
src/plugins/cppeditor/cppquickfixes.cpp
View File

@@ -4121,8 +4121,8 @@ void GetterSetterRefactoringHelper::performGeneration(ExistingGetterSetterData d
// signal declaration
if (generateFlags & Flag::GenerateSignal) {
const auto &paramType = overview.prettyType(returnTypeHeader);
const QString newValue = m_settings->signalWithNewValue ? paramType : QString();
const auto &parameter = overview.prettyType(returnTypeHeader, data.qPropertyName);
const QString newValue = m_settings->signalWithNewValue ? parameter : QString();
const QString declaration = QString("void %1(%2);\n").arg(data.signalName, newValue);
addHeaderCode(InsertionPointLocator::Signals, declaration);
}