feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangStaticAnalyzer: Update comment about -dumpversion

Browse Source 
Change-Id: I268e23dd6f73efcde0e6efcb04e3c0ffb946a11b
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This commit is contained in:
Nikolai Kosjar
2017-09-04 10:33:07 +02:00
parent c2ef4b52d3
commit 1847034371
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/clangstaticanalyzer/clangstaticanalyzerutils.cpp
View File

@@ -126,7 +126,9 @@ ClangExecutableVersion clangExecutableVersion(const QString &executable)
Utils::SynchronousProcess runner; Utils::SynchronousProcess runner;
runner.setEnvironment(environment.toStringList()); runner.setEnvironment(environment.toStringList());
runner.setTimeoutS(10); runner.setTimeoutS(10);
// We would prefer "-dumpversion", but that one returns some old version number. // We would prefer "-dumpversion", but that one is only there for GCC compatibility
// and returns some static/old version.
// See also https://bugs.llvm.org/show_bug.cgi?id=28597
const QStringList arguments(QLatin1String(("--version"))); const QStringList arguments(QLatin1String(("--version")));
const Utils::SynchronousProcessResponse response = runner.runBlocking(executable, arguments); const Utils::SynchronousProcessResponse response = runner.runBlocking(executable, arguments);
if (response.result != Utils::SynchronousProcessResponse::Finished) if (response.result != Utils::SynchronousProcessResponse::Finished)