feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove various RunControl::report* functions

Browse Source 
The interface has now moved to the RunWorkers.

Change-Id: I1ebf74c081697b8e44926ab00053417f9f60647d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2017-05-23 13:12:07 +02:00
parent 0448ac5ce2
commit 19a47fed29
2 changed files with 2 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -1150,16 +1150,6 @@ void RunControl::bringApplicationToForeground()
#endif
}
void RunControl::reportApplicationStart()
{
QTC_CHECK(false);// FIXME: Legacy
}
void RunControl::reportApplicationStop()
{
QTC_CHECK(false);// FIXME: Legacy
}
void RunControl::bringApplicationToForegroundInternal()
{
#ifdef Q_OS_OSX
@@ -1315,12 +1305,6 @@ void SimpleTargetRunner::onProcessError(QProcess::ProcessError)
reportStopped();
}
void RunControl::reportFailure(const QString &msg)
{
d->showError(msg);
d->setState(RunControlState::Stopped);
}
// RunWorkerPrivate
RunWorkerPrivate::RunWorkerPrivate(RunWorker *runWorker, RunControl *runControl)

8
src/plugins/projectexplorer/runconfiguration.h
View File

@@ -469,10 +469,6 @@ public:
virtual void notifyRemoteSetupFailed(const QString &) {} // Same.
virtual void notifyRemoteFinished() {} // Same.
void reportApplicationStart(); // FIXME: Don't use
void reportApplicationStop(); // FIXME: Don't use
void reportFailure(const QString &msg = QString());
static bool showPromptToStopDialog(const QString &title, const QString &text,
const QString &stopButtonText = QString(),
const QString &cancelButtonText = QString(),
@@ -505,8 +501,8 @@ signals:
const QString &msg, Utils::OutputFormat format);
void aboutToStart();
void starting();
void started(); // Use reportApplicationStart!
void finished(); // Use reportApplicationStop!
void started();
void finished();
void applicationProcessHandleChanged(QPrivateSignal); // Use setApplicationProcessHandle
private: