feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Remove unused custom notification

Browse Source 
This notification is only for debugging and breaks encapsulation.

Change-Id: I20faeb76d24cc42417b3cc2e289041c70edd6157
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This commit is contained in:
Thomas Hartmann
2020-08-21 17:18:53 +02:00
parent 52622a036b
commit 1d53e37b6d
2 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qmldesigner/components/debugview/debugview.cpp
View File

@@ -422,10 +422,7 @@ void DebugView::instancesChildrenChanged(const QVector<ModelNode> & nodeList)
void DebugView::customNotification(const AbstractView *view, const QString &identifier, const QList<ModelNode> &nodeList, const QList<QVariant> &data) void DebugView::customNotification(const AbstractView *view, const QString &identifier, const QList<ModelNode> &nodeList, const QList<QVariant> &data)
{ {
if (identifier == "PuppetStatus" && data.count() == 1) { if (isDebugViewEnabled()) {
m_debugViewWidget->setPuppetStatus(data.constFirst().toString());
} else if (isDebugViewEnabled()) {
QTextStream message; QTextStream message;
QString string; QString string;
message.setString(&string); message.setString(&string);

3
src/plugins/qmldesigner/designercore/instances/puppetcreator.cpp
View File

@@ -495,9 +495,6 @@ QProcessEnvironment PuppetCreator::processEnvironment() const
} }
#ifndef QMLDESIGNER_TEST #ifndef QMLDESIGNER_TEST
auto view = QmlDesignerPlugin::instance()->viewManager().nodeInstanceView();
view->emitCustomNotification("PuppetStatus", {}, {QVariant(m_qrcMapping)});
// set env var if QtQuick3D import exists // set env var if QtQuick3D import exists
QmlDesigner::Import import = QmlDesigner::Import::createLibraryImport("QtQuick3D", "1.0"); QmlDesigner::Import import = QmlDesigner::Import::createLibraryImport("QtQuick3D", "1.0");
if (m_model->hasImport(import, true, true)) if (m_model->hasImport(import, true, true))