feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Don't be too eager to throw out SDK-registered cmakes

Browse Source 
Change-Id: I6a35e7599b61068deaf34aeb86ba53bc4120c47c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
hjk
2022-03-11 13:13:24 +01:00
parent 6973ee14c4
commit 1de60ddeaf
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/cmakeprojectmanager/cmaketoolsettingsaccessor.cpp
View File

@@ -128,7 +128,12 @@ mergeTools(std::vector<std::unique_ptr<CMakeTool>> &sdkTools,
std::unique_ptr<CMakeTool> userTool = std::move(userTools[0]);
userTools.erase(std::begin(userTools));
int userToolIndex = Utils::indexOf(result, Utils::equal(&CMakeTool::id, userTool->id()));
int userToolIndex = Utils::indexOf(result, [&userTool](const std::unique_ptr<CMakeTool> &tool) {
// Id should be sufficient, but we have older "mis-registered" docker based items.
// Make sure that these don't override better new values from the sdk by
// also checking the actual executable.
return userTool->id() == tool->id() && userTool->cmakeExecutable() == tool->cmakeExecutable();
});
if (userToolIndex >= 0) {
// Replace the sdk tool with the user tool, so any user changes do not get lost
result[userToolIndex] = std::move(userTool);