feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Add missing reset of state variable

Browse Source 
The m_skipBuilding variable in AndroidBuildApkStep needs to be re-
calculated on every call to init().
Also add some debug statements that will help us find out why it becomes
true in the first place.

Task-number: QTCREATORBUG-23572
Change-Id: I058b58cf0e511557d1fad7e5bd03048a7d8b9c69
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
This commit is contained in:
Christian Kandeler
2020-03-11 17:23:12 +01:00
parent 2c842453b0
commit 1de9e9e402
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/android/androidbuildapkstep.cpp
View File

@@ -230,9 +230,11 @@ bool AndroidBuildApkStep::init()
m_inputFile = node->data(Constants::AndroidDeploySettingsFile).toString(); m_inputFile = node->data(Constants::AndroidDeploySettingsFile).toString();
if (m_inputFile.isEmpty()) { if (m_inputFile.isEmpty()) {
qCDebug(buildapkstepLog) << "no input file" << rc << node << buildKey;
m_skipBuilding = true; m_skipBuilding = true;
return true; return true;
} }
m_skipBuilding = false;
if (m_buildTargetSdk.isEmpty()) { if (m_buildTargetSdk.isEmpty()) {
emit addOutput(tr("Android build SDK not defined. Check Android settings."), emit addOutput(tr("Android build SDK not defined. Check Android settings."),