CMakeLists: Allow for internal plugin registration

add_qtc_plugin now takes a flag "INTERNAL_ONLY". These internal plugins
will not show up in the project configuration nor in the feature summary.

This flag is used by the tests that build plugins.

Change-Id: I1912dd62221b2624ed7326df381fbbceccefbdac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

cmake/QtCreatorAPI.cmake

@@ -362,7 +362,7 @@ endfunction(add_qtc_library)
 
 function(add_qtc_plugin target_name)
   cmake_parse_arguments(_arg
-    "EXPERIMENTAL;SKIP_DEBUG_CMAKE_FILE_CHECK;SKIP_INSTALL"
+    "EXPERIMENTAL;SKIP_DEBUG_CMAKE_FILE_CHECK;SKIP_INSTALL;INTERNAL_ONLY"
     "VERSION;COMPAT_VERSION;PLUGIN_JSON_IN;PLUGIN_PATH;PLUGIN_NAME;OUTPUT_NAME"
     "CONDITION;DEPENDS;PUBLIC_DEPENDS;DEFINES;PUBLIC_DEFINES;INCLUDES;PUBLIC_INCLUDES;PLUGIN_DEPENDS;PLUGIN_RECOMMENDS;SOURCES;EXPLICIT_MOC"
     ${ARGN}
@@ -392,7 +392,11 @@ function(add_qtc_plugin target_name)
   if (DEFINED ENV{QTC_${_build_plugin_var}})
     set(_build_plugin_default "$ENV{QTC_${_build_plugin_var}}")
   endif()
-  set(${_build_plugin_var} "${_build_plugin_default}" CACHE BOOL "Build plugin ${name}.")
+  if (_arg_INTERNAL_ONLY)
+    set(${_build_plugin_var} "${_build_plugin_default}")
+  else()
+    set(${_build_plugin_var} "${_build_plugin_default}" CACHE BOOL "Build plugin ${name}.")
+  endif()
 
   if ((${_arg_CONDITION}) AND ${_build_plugin_var})
     set(_plugin_enabled ON)
@@ -400,7 +404,9 @@ function(add_qtc_plugin target_name)
     set(_plugin_enabled OFF)
   endif()
 
-  add_feature_info("Plugin ${name}" _plugin_enabled "${_extra_text}")
+  if (NOT _arg_INTERNAL_ONLY)
+    add_feature_info("Plugin ${name}" _plugin_enabled "${_extra_text}")
+  endif()
   if (NOT _plugin_enabled)
     return()
   endif()

tests/auto/extensionsystem/pluginmanager/circularplugins/plugin1/CMakeLists.txt

@@ -4,4 +4,5 @@ add_qtc_plugin(plugin1
     plugin1.cpp plugin1.h
   PLUGIN_PATH "${TEST_PLUGIN_PATH}"
   SKIP_INSTALL
- )
+  INTERNAL_ONLY
+)

tests/auto/extensionsystem/pluginmanager/circularplugins/plugin2/CMakeLists.txt

@@ -4,4 +4,5 @@ add_qtc_plugin(plugin2
     plugin2.cpp plugin2.h
   PLUGIN_PATH "${TEST_PLUGIN_PATH}"
   SKIP_INSTALL
- )
+  INTERNAL_ONLY
+)

tests/auto/extensionsystem/pluginmanager/circularplugins/plugin3/CMakeLists.txt

@@ -4,4 +4,5 @@ add_qtc_plugin(plugin3
     plugin3.cpp plugin3.h
   PLUGIN_PATH "${TEST_PLUGIN_PATH}"
   SKIP_INSTALL
- )
+  INTERNAL_ONLY
+)

tests/auto/extensionsystem/pluginmanager/correctplugins1/plugin1/CMakeLists.txt

@@ -5,4 +5,5 @@ add_qtc_plugin(correct_plugin1
     plugin1.cpp plugin1.h
   PLUGIN_PATH "${TEST_PLUGIN_PATH}"
   SKIP_INSTALL
+  INTERNAL_ONLY
 )

tests/auto/extensionsystem/pluginmanager/correctplugins1/plugin2/CMakeLists.txt

@@ -5,4 +5,5 @@ add_qtc_plugin(correct_plugin2
     plugin2.cpp plugin2.h
   PLUGIN_PATH "${TEST_PLUGIN_PATH}"
   SKIP_INSTALL
+  INTERNAL_ONLY
 )

tests/auto/extensionsystem/pluginmanager/correctplugins1/plugin3/CMakeLists.txt

@@ -5,4 +5,5 @@ add_qtc_plugin(correct_plugin3
     plugin3.cpp plugin3.h
   PLUGIN_PATH "${TEST_PLUGIN_PATH}"
   SKIP_INSTALL
+  INTERNAL_ONLY
 )

tests/auto/extensionsystem/pluginspec/testplugin/CMakeLists.txt

@@ -18,6 +18,7 @@ add_qtc_plugin(testplugin
   PROPERTIES
     OUTPUT_NAME ${plugin_output_name}
   SKIP_INSTALL
+  INTERNAL_ONLY
 )
 
 # The empty string gets removed if I put it above