feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Fix FilePathView constructor

Browse Source 
Do not keep pointer of a temporary object.

Change-Id: I5251c7dbc8581be96afaa947e1a58adaeb0b17e3
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This commit is contained in:
Ivan Donchevskii
2017-11-29 10:31:22 +01:00
committed by Marco Bubke
parent 9ad760efda
commit 21b8e10814
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/libs/clangsupport/filepathview.h
View File

@@ -45,8 +45,9 @@ public:
{ {
} }
template <typename String> template <typename String,
explicit FilePathView(String filePath) typename = std::enable_if_t<std::is_lvalue_reference<String>::value>>
explicit FilePathView(String &&filePath)
: FilePathView(filePath.data(), filePath.size()) : FilePathView(filePath.data(), filePath.size())
{ {
} }

5
src/libs/clangsupport/nativefilepathview.h
View File

@@ -44,8 +44,9 @@ public:
{ {
} }
template <typename String> template <typename String,
explicit NativeFilePathView(String filePath) typename = std::enable_if_t<std::is_lvalue_reference<String>::value>>
explicit NativeFilePathView(String &&filePath)
: NativeFilePathView(filePath.data(), filePath.size()) : NativeFilePathView(filePath.data(), filePath.size())
{ {
} }